From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 316B3C43603 for ; Fri, 20 Dec 2019 13:19:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E74321D7E for ; Fri, 20 Dec 2019 13:19:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E74321D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A58276EC2F; Fri, 20 Dec 2019 13:19:36 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C23E6EC2F for ; Fri, 20 Dec 2019 13:19:35 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 05:19:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,336,1571727600"; d="scan'208";a="213574642" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga008.fm.intel.com with SMTP; 20 Dec 2019 05:19:32 -0800 Received: by stinkbox (sSMTP sendmail emulation); Fri, 20 Dec 2019 15:19:32 +0200 Date: Fri, 20 Dec 2019 15:19:32 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Manasi Navare Message-ID: <20191220131932.GK1208@intel.com> References: <20191219215117.929-1-manasi.d.navare@intel.com> <20191219215117.929-3-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191219215117.929-3-manasi.d.navare@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dp: Disable Port sync mode correctly on teardown X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Dec 19, 2019 at 01:51:17PM -0800, Manasi Navare wrote: > While clearing the Ports ync mode enable and master select bits > we need to clear the register completely instead of using disable masks > = > v2: > * Just write 0 to the reg (Ville) > * Rebase > = > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 > Cc: Ville Syrj=E4l=E4 > Cc: Jani Nikula > Fixes: 51528afe7c5e ("drm/i915/display/icl: Disable transcoder port sync = as part of crtc_disable() sequence") > Signed-off-by: Manasi Navare > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i= 915/display/intel_ddi.c > index c9ba7d7f3787..c484f6df5d87 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3861,7 +3861,6 @@ static void icl_disable_transcoder_port_sync(const = struct intel_crtc_state *old_ > struct intel_crtc *crtc =3D to_intel_crtc(old_crtc_state->uapi.crtc); > struct drm_i915_private *dev_priv =3D to_i915(crtc->base.dev); > i915_reg_t reg; > - u32 trans_ddi_func_ctl2_val; > = > if (old_crtc_state->master_transcoder =3D=3D INVALID_TRANSCODER) > return; > @@ -3870,9 +3869,7 @@ static void icl_disable_transcoder_port_sync(const = struct intel_crtc_state *old_ > transcoder_name(old_crtc_state->cpu_transcoder)); > = > reg =3D TRANS_DDI_FUNC_CTL2(old_crtc_state->cpu_transcoder); 'reg' is rather pointless now. Reviewed-by: Ville Syrj=E4l=E4 > - trans_ddi_func_ctl2_val =3D ~(PORT_SYNC_MODE_ENABLE | > - PORT_SYNC_MODE_MASTER_SELECT_MASK); > - I915_WRITE(reg, trans_ddi_func_ctl2_val); > + I915_WRITE(reg, 0); > } > = > static void intel_ddi_post_disable(struct intel_encoder *encoder, > -- = > 2.19.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx