From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FCDC43603 for ; Fri, 20 Dec 2019 14:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4994F21D7E for ; Fri, 20 Dec 2019 14:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576852522; bh=YCDTaLPBYm/FSHUKf5B+vQAhJ61Kj7eBRk7Oijl1now=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YMuIcSzTf6W4HmXr7b8ySGDNkdXCQXOjG2iCl6AiS6WF1xWnAZHf03wFx0W4e0Ig5 VOIYKJb+2Sm24Cw0fzKsHfemCOUcLRRRh9qn090y2/ZOOHzCFg+5p4Rsk+VdjuRKbT /JfSO9/00XZCYSnKIKJPQQQUq542UayyGfwwSv04= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728408AbfLTOfV (ORCPT ); Fri, 20 Dec 2019 09:35:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:39560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728359AbfLTOfI (ORCPT ); Fri, 20 Dec 2019 09:35:08 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13E8424680; Fri, 20 Dec 2019 14:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576852507; bh=YCDTaLPBYm/FSHUKf5B+vQAhJ61Kj7eBRk7Oijl1now=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZR6FoVSBN7FouFkxRJKlx0qHpeRvhq+7MV+FYQYRRvfxVB8Di0mnSueObm/iOvf+y pwqhBH2IE2yYeeJa/KMGNDdrPwRvAf8xUbEZTkB+lF8FKNFKXlv512lUs2IU66w3LN dpCDUZb0cLFTplqd85Yk8mkFs5WlYk3eLrCEmACI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: David Howells , Marc Dionne , Jonathan Billings , Sasha Levin , linux-afs@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 26/34] afs: Fix creation calls in the dynamic root to fail with EOPNOTSUPP Date: Fri, 20 Dec 2019 09:34:25 -0500 Message-Id: <20191220143433.9922-26-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191220143433.9922-1-sashal@kernel.org> References: <20191220143433.9922-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells [ Upstream commit 1da4bd9f9d187f53618890d7b66b9628bbec3c70 ] Fix the lookup method on the dynamic root directory such that creation calls, such as mkdir, open(O_CREAT), symlink, etc. fail with EOPNOTSUPP rather than failing with some odd error (such as EEXIST). lookup() itself tries to create automount directories when it is invoked. These are cached locally in RAM and not committed to storage. Signed-off-by: David Howells Reviewed-by: Marc Dionne Tested-by: Jonathan Billings Signed-off-by: Sasha Levin --- fs/afs/dynroot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/afs/dynroot.c b/fs/afs/dynroot.c index f29c6dade7f62..069273a2483f9 100644 --- a/fs/afs/dynroot.c +++ b/fs/afs/dynroot.c @@ -145,6 +145,9 @@ static struct dentry *afs_dynroot_lookup(struct inode *dir, struct dentry *dentr ASSERTCMP(d_inode(dentry), ==, NULL); + if (flags & LOOKUP_CREATE) + return ERR_PTR(-EOPNOTSUPP); + if (dentry->d_name.len >= AFSNAMEMAX) { _leave(" = -ENAMETOOLONG"); return ERR_PTR(-ENAMETOOLONG); -- 2.20.1