From: Oleg Nesterov <oleg@redhat.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] x86: Remove force_iret()
Date: Fri, 20 Dec 2019 20:35:44 +0100 [thread overview]
Message-ID: <20191220193543.GD13464@redhat.com> (raw)
In-Reply-To: <20191219115812.102620-1-brgerst@gmail.com>
On 12/19, Brian Gerst wrote:
>
> force_iret() was originally intended to prevent the return to user mode with
> the SYSRET or SYSEXIT instructions, in cases where the register state could
> have been changed to be incompatible with those instructions. The entry code
> has been significantly reworked since then, and register state is validated
> before SYSRET or SYSEXIT are used. force_iret() no longer serves its original
> purpose and can be eliminated.
Plus iiuc today force_iret() == set_thread_flag(TIF_NOTIFY_RESUME) simply has
no effect on asm paths.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-12-20 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 11:58 [PATCH] x86: Remove force_iret() Brian Gerst
2019-12-20 1:49 ` Andy Lutomirski
2019-12-20 3:48 ` Brian Gerst
2019-12-20 10:10 ` David Laight
2019-12-20 10:30 ` Andy Lutomirski
2019-12-20 10:59 ` David Laight
2019-12-20 21:20 ` Andy Lutomirski
2019-12-20 12:18 ` Brian Gerst
2019-12-20 12:35 ` David Laight
2019-12-20 19:35 ` Oleg Nesterov [this message]
2020-01-08 20:30 ` [tip: x86/asm] " tip-bot2 for Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220193543.GD13464@redhat.com \
--to=oleg@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.