From: Yangtao Li <tiny.windzz@gmail.com>
To: daniel.lezcano@linaro.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Cc: Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH v2 4/4] clocksource: timer-ti-dm: switch to platform_get_irq
Date: Sat, 21 Dec 2019 17:30:27 +0000 [thread overview]
Message-ID: <20191221173027.30716-5-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20191221173027.30716-1-tiny.windzz@gmail.com>
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/clocksource/timer-ti-dm.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index aa2ede266edf..bd16efb2740b 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -780,7 +780,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
{
unsigned long flags;
struct omap_dm_timer *timer;
- struct resource *irq;
struct device *dev = &pdev->dev;
const struct dmtimer_platform_data *pdata;
int ret;
@@ -796,11 +795,9 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
return -ENODEV;
}
- irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (unlikely(!irq)) {
- dev_err(dev, "%s: no IRQ resource.\n", __func__);
- return -ENODEV;
- }
+ timer->irq = platform_get_irq(pdev, 0);
+ if (timer->irq < 0)
+ return timer->irq;
timer = devm_kzalloc(dev, sizeof(*timer), GFP_KERNEL);
if (!timer)
@@ -830,7 +827,6 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
if (pdata)
timer->errata = pdata->timer_errata;
- timer->irq = irq->start;
timer->pdev = pdev;
pm_runtime_enable(dev);
--
2.17.1
next prev parent reply other threads:[~2019-12-21 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 17:30 [PATCH v2 0/4] clocksource: do some cleanup Yangtao Li
2019-12-21 17:30 ` [PATCH v2 1/4] clocksource: em_sti: convert to devm_platform_ioremap_resource Yangtao Li
2020-01-16 21:31 ` [tip: timers/core] clocksource/drivers/em_sti: Convert " tip-bot2 for Yangtao Li
2019-12-21 17:30 ` [PATCH v2 2/4] clocksource: em_sti: fix variable declaration in em_sti_probe Yangtao Li
2020-01-16 21:31 ` [tip: timers/core] clocksource/drivers/em_sti: Fix " tip-bot2 for Yangtao Li
2019-12-21 17:30 ` [PATCH v2 3/4] clocksource: timer-ti-dm: convert to devm_platform_ioremap_resource Yangtao Li
2020-01-16 21:31 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: Convert " tip-bot2 for Yangtao Li
2019-12-21 17:30 ` Yangtao Li [this message]
2020-01-16 21:31 ` [tip: timers/core] clocksource/drivers/timer-ti-dm: Switch to platform_get_irq tip-bot2 for Yangtao Li
2019-12-21 18:29 ` [PATCH v2 0/4] clocksource: do some cleanup Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221173027.30716-5-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.