From: Pavel Machek <pavel@ucw.cz>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt: bindings: lm3692x: Document new properties
Date: Sat, 21 Dec 2019 20:15:15 +0100 [thread overview]
Message-ID: <20191221191515.GF32732@amd> (raw)
In-Reply-To: <35a23315938909c80e7772838e1de0d2d46302f2.1576499103.git.agx@sigxcpu.org>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Mon 2019-12-16 13:28:05, Guido Günther wrote:
> We allow configuration of brightness mode and over voltage
> protection.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
> @@ -18,6 +18,10 @@ Required properties:
> Optional properties:
> - enable-gpios : gpio pin to enable/disable the device.
> - vled-supply : LED supply
> + - ti,brightness-mapping-exponential: Whether to use exponential
> + brightness mapping
> + - ti,overvoltage-volts: Overvoltage protection in Volts, can
> + be 0 (unprotected), 21, 25 or 29V
>
We usually use microvolts in various device tree properties...
Exponential mapping s not really property of the hardware, is it? Does
it belong here or somewhere in the backlight binding?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-12-21 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:28 [PATCH 0/2] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-16 12:28 ` [PATCH 1/2] dt: bindings: lm3692x: Document new properties Guido Günther
2019-12-17 12:41 ` Dan Murphy
2019-12-21 19:15 ` Pavel Machek [this message]
2019-12-24 11:45 ` Guido Günther
2019-12-26 19:19 ` Rob Herring
2019-12-27 10:16 ` Guido Günther
2019-12-16 12:28 ` [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-17 12:53 ` Dan Murphy
2019-12-17 15:40 ` Guido Günther
2019-12-17 17:01 ` Dan Murphy
2019-12-21 19:17 ` Pavel Machek
2019-12-24 11:30 ` Guido Günther
2019-12-21 19:18 ` Pavel Machek
2019-12-24 11:26 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221191515.GF32732@amd \
--to=pavel@ucw.cz \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.