From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors Date: Sat, 21 Dec 2019 20:59:56 -0500 Message-ID: <20191222015956.GA63378@mit.edu> References: <20191218130935.32402-1-agruenba@redhat.com> <20191218185216.GA7497@magnolia> <20191218192331.GA7473@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191218192331.GA7473@magnolia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: "Darrick J. Wong" Cc: Jan Kara , Adrian Hunter , Chris Mason , Andreas Dilger , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Christoph Hellwig , Ilya Dryomov , linux-ext4 , Josef Bacik , Alexander Viro , David Sterba , Jaegeuk Kim , Ceph Development , Artem Bityutskiy , Jeff Layton , LKML , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel , linux-mtd@lists.infradead.org, Linus Torvalds , linux-btrfs@vger.kernel.org List-Id: ceph-devel.vger.kernel.org On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote: > *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes > more sense. Er, I guess I don't mind pushing via iomap tree, but could > we get some acks from Ted and any of the ceph maintainers? Acked-by: Theodore Ts'o My only nit is the same one Jan raised, which is should page_mkwrite_check_truncate() be an inline function? - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF89C3F68F for ; Sun, 22 Dec 2019 02:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33F47206D8 for ; Sun, 22 Dec 2019 02:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726449AbfLVCBF (ORCPT ); Sat, 21 Dec 2019 21:01:05 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:48635 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726086AbfLVCBF (ORCPT ); Sat, 21 Dec 2019 21:01:05 -0500 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBM1xvSc030406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Dec 2019 20:59:57 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id DA5AB420822; Sat, 21 Dec 2019 20:59:56 -0500 (EST) Date: Sat, 21 Dec 2019 20:59:56 -0500 From: "Theodore Y. Ts'o" To: "Darrick J. Wong" Cc: Andreas Gruenbacher , Alexander Viro , Christoph Hellwig , Linus Torvalds , LKML , Jeff Layton , Sage Weil , Ilya Dryomov , Andreas Dilger , Jaegeuk Kim , Chao Yu , linux-xfs@vger.kernel.org, linux-fsdevel , Richard Weinberger , Artem Bityutskiy , Adrian Hunter , Ceph Development , linux-ext4 , linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Jan Kara Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors Message-ID: <20191222015956.GA63378@mit.edu> References: <20191218130935.32402-1-agruenba@redhat.com> <20191218185216.GA7497@magnolia> <20191218192331.GA7473@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191218192331.GA7473@magnolia> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote: > *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes > more sense. Er, I guess I don't mind pushing via iomap tree, but could > we get some acks from Ted and any of the ceph maintainers? Acked-by: Theodore Ts'o My only nit is the same one Jan raised, which is should page_mkwrite_check_truncate() be an inline function? - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23201C2D0C3 for ; Sun, 22 Dec 2019 02:00:44 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D69FF206C3 for ; Sun, 22 Dec 2019 02:00:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="KfGuEiUm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="XcN2pAt7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D69FF206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iiqXz-00035Z-2Q; Sun, 22 Dec 2019 02:00:43 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iiqXx-00035N-VV for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Dec 2019 02:00:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2qEYO0x6euIDQsPuQlnVZgH4EwXjUmOWQOSUlq6rg10=; b=KfGuEiUmXpTXN6r6tjhbSr386Q SO0c2YyK7BqxLme+lKl9jZtdqVrp/h75Pqgr1YUB32eyoC7aIL1/HzI60ZQmlx3MAjixEcMRnODpW 7VXlj+uFW0FE2bqi+XanyqXHOwWb5yx951F6qJmHC2cBcnoG9pQEo/MbrJIpGaDeOgi8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2qEYO0x6euIDQsPuQlnVZgH4EwXjUmOWQOSUlq6rg10=; b=XcN2pAt7vnCCfqmXL0Mj3yIr7Q TF+VqrvpKwB34oqdAWKLHyN6oeBfNxPmlgLO117yKrQPx0BQQ7vSVtiXovYOuRRsKYxfHgoYwwHgZ cH9rdFytK4LPGII/zeUWdkcnk6n5S2yZn7r3FlXPSK+N99MZVYqlQ0HF0TervWijqZR0=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iiqXw-00CEwY-0y for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Dec 2019 02:00:41 +0000 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBM1xvSc030406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Dec 2019 20:59:57 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id DA5AB420822; Sat, 21 Dec 2019 20:59:56 -0500 (EST) Date: Sat, 21 Dec 2019 20:59:56 -0500 From: "Theodore Y. Ts'o" To: "Darrick J. Wong" Message-ID: <20191222015956.GA63378@mit.edu> References: <20191218130935.32402-1-agruenba@redhat.com> <20191218185216.GA7497@magnolia> <20191218192331.GA7473@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191218192331.GA7473@magnolia> User-Agent: Mutt/1.12.2 (2019-09-21) X-Headers-End: 1iiqXw-00CEwY-0y Subject: Re: [f2fs-dev] [PATCH v3] fs: Fix page_mkwrite off-by-one errors X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Adrian Hunter , Chris Mason , Andreas Dilger , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Christoph Hellwig , Ilya Dryomov , linux-ext4 , Josef Bacik , Alexander Viro , David Sterba , Jaegeuk Kim , Ceph Development , Artem Bityutskiy , Jeff Layton , LKML , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel , linux-mtd@lists.infradead.org, Linus Torvalds , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote: > *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes > more sense. Er, I guess I don't mind pushing via iomap tree, but could > we get some acks from Ted and any of the ceph maintainers? Acked-by: Theodore Ts'o My only nit is the same one Jan raised, which is should page_mkwrite_check_truncate() be an inline function? - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23DCC2D0C3 for ; Sun, 22 Dec 2019 02:00:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C50B7206C3 for ; Sun, 22 Dec 2019 02:00:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MV1bpKu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C50B7206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d6XxJI2CFe2yPhMTliiK88L+9a6ML3Hbh771Fkv5FHI=; b=MV1bpKu+ZleTei XGgWkwsPvvakLB5QHvBTPN3XhHrnSiY+edkoBlS097KBsUWW+BUDwQauyLr5F8RWNZUOQZwU3Y7Vc RRNsNpBUVwbjCH7XoweWsMVGk2C1QTCN+YYACX8cwx8Nx38w9BNneH1JXNHnbkMAFwn2l6Gk2YeWb Wrzjl80Mn6TzAaR7sDex0Uo73NlydwExH+E+nqHf9e8BXGSJCZCweMct88CHGKYnlkMCp9WcFpvn6 6yE7eq1CLNZWsL7NXvkXxDPLxl8HOHksLqa1OuOyyDF/KRMxiC2z2cpOg6c982+FeTK+2rBGEPGtd IIRUc2Tn8vQqUICKEubA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiqXq-0006il-Al; Sun, 22 Dec 2019 02:00:34 +0000 Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iiqXk-0006i9-ET for linux-mtd@lists.infradead.org; Sun, 22 Dec 2019 02:00:29 +0000 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xBM1xvSc030406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 21 Dec 2019 20:59:57 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id DA5AB420822; Sat, 21 Dec 2019 20:59:56 -0500 (EST) Date: Sat, 21 Dec 2019 20:59:56 -0500 From: "Theodore Y. Ts'o" To: "Darrick J. Wong" Subject: Re: [PATCH v3] fs: Fix page_mkwrite off-by-one errors Message-ID: <20191222015956.GA63378@mit.edu> References: <20191218130935.32402-1-agruenba@redhat.com> <20191218185216.GA7497@magnolia> <20191218192331.GA7473@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191218192331.GA7473@magnolia> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191221_180028_655628_50D3B573 X-CRM114-Status: UNSURE ( 6.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Adrian Hunter , Chris Mason , Andreas Dilger , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Christoph Hellwig , Ilya Dryomov , linux-ext4 , Chao Yu , Josef Bacik , Alexander Viro , David Sterba , Jaegeuk Kim , Ceph Development , Artem Bityutskiy , Jeff Layton , LKML , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel , linux-mtd@lists.infradead.org, Linus Torvalds , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Dec 18, 2019 at 11:23:31AM -0800, Darrick J. Wong wrote: > *OH*, because we're stuffing the value in ret2, not ret. Ok, that makes > more sense. Er, I guess I don't mind pushing via iomap tree, but could > we get some acks from Ted and any of the ceph maintainers? Acked-by: Theodore Ts'o My only nit is the same one Jan raised, which is should page_mkwrite_check_truncate() be an inline function? - Ted ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/