From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E603CC2D0D0 for ; Mon, 23 Dec 2019 11:36:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C36D92073A for ; Mon, 23 Dec 2019 11:36:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C36D92073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ijM0F-0004uK-90; Mon, 23 Dec 2019 11:35:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1ijM0D-0004uF-EI for xen-devel@lists.xenproject.org; Mon, 23 Dec 2019 11:35:57 +0000 X-Inumbo-ID: 5d8ad1ee-2578-11ea-88e7-bc764e2007e4 Received: from mail-wr1-f68.google.com (unknown [209.85.221.68]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d8ad1ee-2578-11ea-88e7-bc764e2007e4; Mon, 23 Dec 2019 11:35:48 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id y11so16273524wrt.6 for ; Mon, 23 Dec 2019 03:35:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HLf7UDzjHO46QZ+r4g/DQtLvnK9ZgG13FP1Rb0ijduQ=; b=hByPU2rDE3cv8YI3tMVIfddMIUIXd7mJH6aaYOSYTxI3Zhnpus9YTDIlbVBNRARQSK bo1P4dmWr0rZLxbSu645NmSYYzN23AcbhPDAkrFvUR69ThrsDk2PkcW86rwcvzcRMDN9 vVk5/1kC7WXJ9dEVTgG2jk7sgHIC8UnuuAZXRYUafNo5MTx6wHDxvB7f8OIqlBhH2mJA 1FunSj1omu+kCLV8SCYkiKxIULY7ipTe3j0Hxr3tZpW5WslZZz8gQYPhDJaIkPVlkXXc Vp15ZYX8cpJyt4NL9XuihdAMdmqxAXmUxqmiOvVemxe6awjhSX0dydz7cyt/ujCCvNSS jleg== X-Gm-Message-State: APjAAAX9gxvszcC3h8MXsD2HQM7hoDz3en4PR355xpmToLC060y0+zLA 7/lNg1le9iqD8a0+5t52eho= X-Google-Smtp-Source: APXvYqz93/AcG8Tzkn6CEiCbg3U9AEeAW5KZcv3jLL8eB1/yo9AokuwM9YpW25WmFlKY/8HxY5MEzA== X-Received: by 2002:adf:fc0c:: with SMTP id i12mr31296335wrr.74.1577100948094; Mon, 23 Dec 2019 03:35:48 -0800 (PST) Received: from debian (38.163.200.146.dyn.plus.net. [146.200.163.38]) by smtp.gmail.com with ESMTPSA id c15sm20231097wrt.1.2019.12.23.03.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2019 03:35:47 -0800 (PST) Date: Mon, 23 Dec 2019 11:35:45 +0000 From: Wei Liu To: Paul Durrant Message-ID: <20191223113545.nwugg7lsorttunuu@debian> References: <20191223095923.2458-1-pdurrant@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191223095923.2458-1-pdurrant@amazon.com> User-Agent: NeoMutt/20180716 Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: support dynamic unbind/bind X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Paul Durrant , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gTW9uLCBEZWMgMjMsIDIwMTkgYXQgMDk6NTk6MjNBTSArMDAwMCwgUGF1bCBEdXJyYW50IHdy b3RlOgpbLi4uXSAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50ZXJm YWNlLmMgYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9pbnRlcmZhY2UuYwo+IGluZGV4IGYxNWJh M2RlNjE5NS4uMGM4YTAyYTFlYWQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRi YWNrL2ludGVyZmFjZS5jCj4gKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50ZXJmYWNl LmMKPiBAQCAtNTg1LDYgKzU4NSw3IEBAIGludCB4ZW52aWZfY29ubmVjdF9jdHJsKHN0cnVjdCB4 ZW52aWYgKnZpZiwgZ3JhbnRfcmVmX3QgcmluZ19yZWYsCj4gIAlzdHJ1Y3QgbmV0X2RldmljZSAq ZGV2ID0gdmlmLT5kZXY7Cj4gIAl2b2lkICphZGRyOwo+ICAJc3RydWN0IHhlbl9uZXRpZl9jdHJs X3NyaW5nICpzaGFyZWQ7Cj4gKwlSSU5HX0lEWCByc3BfcHJvZCwgcmVxX3Byb2Q7Cj4gIAlpbnQg ZXJyOwo+ICAKPiAgCWVyciA9IHhlbmJ1c19tYXBfcmluZ192YWxsb2MoeGVudmlmX3RvX3hlbmJ1 c19kZXZpY2UodmlmKSwKPiBAQCAtNTkzLDcgKzU5NCwxNCBAQCBpbnQgeGVudmlmX2Nvbm5lY3Rf Y3RybChzdHJ1Y3QgeGVudmlmICp2aWYsIGdyYW50X3JlZl90IHJpbmdfcmVmLAo+ICAJCWdvdG8g ZXJyOwo+ICAKPiAgCXNoYXJlZCA9IChzdHJ1Y3QgeGVuX25ldGlmX2N0cmxfc3JpbmcgKilhZGRy Owo+IC0JQkFDS19SSU5HX0lOSVQoJnZpZi0+Y3RybCwgc2hhcmVkLCBYRU5fUEFHRV9TSVpFKTsK PiArCXJzcF9wcm9kID0gUkVBRF9PTkNFKHNoYXJlZC0+cnNwX3Byb2QpOwo+ICsJcmVxX3Byb2Qg PSBSRUFEX09OQ0Uoc2hhcmVkLT5yZXFfcHJvZCk7Cj4gKwo+ICsJQkFDS19SSU5HX0FUVEFDSCgm dmlmLT5jdHJsLCBzaGFyZWQsIHJzcF9wcm9kLCBYRU5fUEFHRV9TSVpFKTsKPiArCj4gKwllcnIg PSAtRUlPOwo+ICsJaWYgKHJlcV9wcm9kIC0gcnNwX3Byb2QgPiBSSU5HX1NJWkUoJnZpZi0+Y3Ry bCkpCj4gKwkJZ290byBlcnJfdW5tYXA7CgpJIHRoaW5rIGl0IG1ha2VzIG1vcmUgc2Vuc2UgdG8g YXR0YWNoIHRoZSByaW5nIGFmdGVyIHRoaXMgY2hlY2sgaGFzIGJlZW4KZG9uZSwgYnV0IEkgY2Fu IHNlZSB5b3Ugd2FudCB0byBzdHJ1Y3R1cmUgY29kZSBsaWtlIHRoaXMgdG8gcmV1c2UgdGhlCnVu bWFwIGVycm9yIHBhdGguCgpTbzoKClJldmlld2VkLWJ5OiBXZWkgTGl1IDx3ZWkubGl1QGtlcm5l bC5vcmc+CgpOaWNlIHdvcmsgYnR3LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZv L3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEB6C2D0D0 for ; Mon, 23 Dec 2019 11:35:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 631A82063A for ; Mon, 23 Dec 2019 11:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577100955; bh=uEFO2Yo2axiENJZnZufLZNM9xiwL3h2PZxVd19dYCp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jeZa5Dbu9ekLfsS4alLueEM7NzuKpAhNwPZQ3tlCa1rpEqm7BsnV+/pC1zCADJThu jez7oSsWE13n0rCwoRftW/FgEMvxpu7CDpy1PZnOy49UmlE/U5XDG4zPmblxCXr5hg Ugpn+Le6slUqqb+8ufgnOzJRzhV4GJJ8nZFzPEkI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727395AbfLWLfy (ORCPT ); Mon, 23 Dec 2019 06:35:54 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36455 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbfLWLfu (ORCPT ); Mon, 23 Dec 2019 06:35:50 -0500 Received: by mail-wr1-f67.google.com with SMTP id z3so16297054wru.3; Mon, 23 Dec 2019 03:35:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HLf7UDzjHO46QZ+r4g/DQtLvnK9ZgG13FP1Rb0ijduQ=; b=qPRER4TqbjX+h4OFzgVXBSmWL2Bth5zX/084Jq9f8xbNHxRq/1L7+FlpFEqRhAHP9h wVGfgxzHihmkNi66DSmcWcdy4YJ8B9C4GCl6uVrPL84+05es37WrjcH0BXo2GK8D06nt 1zkXHeaiKSsPTq58K6gsU3guU1GBFYrcaB0oBXUtEPeqBGGBFhsWpCLrAOUIJJ5UyHWG +v6WHXH25czYVKkEIWahWpcKrIWjq4x9GYoJ7Qq7NpOgcvLPT+e5Wtp8b5YEMcEoc8ja J5GkGqoZou+CODfC85Cp3kNd9g92AJ2laNbpLlYEyivhf1fZlMjyWfJ+EKJntENxP1QJ pHlA== X-Gm-Message-State: APjAAAUBGnjW/C7AfBxFxUW5LQEhjvJUEtJzhFvj/u12dKYWg40mTBUR FDt5/fkuaZuCsph3rLjY1C8= X-Google-Smtp-Source: APXvYqz93/AcG8Tzkn6CEiCbg3U9AEeAW5KZcv3jLL8eB1/yo9AokuwM9YpW25WmFlKY/8HxY5MEzA== X-Received: by 2002:adf:fc0c:: with SMTP id i12mr31296335wrr.74.1577100948094; Mon, 23 Dec 2019 03:35:48 -0800 (PST) Received: from debian (38.163.200.146.dyn.plus.net. [146.200.163.38]) by smtp.gmail.com with ESMTPSA id c15sm20231097wrt.1.2019.12.23.03.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2019 03:35:47 -0800 (PST) Date: Mon, 23 Dec 2019 11:35:45 +0000 From: Wei Liu To: Paul Durrant Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" Subject: Re: [PATCH net-next] xen-netback: support dynamic unbind/bind Message-ID: <20191223113545.nwugg7lsorttunuu@debian> References: <20191223095923.2458-1-pdurrant@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191223095923.2458-1-pdurrant@amazon.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2019 at 09:59:23AM +0000, Paul Durrant wrote: [...] > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index f15ba3de6195..0c8a02a1ead7 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -585,6 +585,7 @@ int xenvif_connect_ctrl(struct xenvif *vif, grant_ref_t ring_ref, > struct net_device *dev = vif->dev; > void *addr; > struct xen_netif_ctrl_sring *shared; > + RING_IDX rsp_prod, req_prod; > int err; > > err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(vif), > @@ -593,7 +594,14 @@ int xenvif_connect_ctrl(struct xenvif *vif, grant_ref_t ring_ref, > goto err; > > shared = (struct xen_netif_ctrl_sring *)addr; > - BACK_RING_INIT(&vif->ctrl, shared, XEN_PAGE_SIZE); > + rsp_prod = READ_ONCE(shared->rsp_prod); > + req_prod = READ_ONCE(shared->req_prod); > + > + BACK_RING_ATTACH(&vif->ctrl, shared, rsp_prod, XEN_PAGE_SIZE); > + > + err = -EIO; > + if (req_prod - rsp_prod > RING_SIZE(&vif->ctrl)) > + goto err_unmap; I think it makes more sense to attach the ring after this check has been done, but I can see you want to structure code like this to reuse the unmap error path. So: Reviewed-by: Wei Liu Nice work btw.