From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D287BC2D0C0 for ; Mon, 23 Dec 2019 12:08:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFA672063A for ; Mon, 23 Dec 2019 12:08:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFA672063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D63B6E28B; Mon, 23 Dec 2019 12:08:03 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id D81B66E28B for ; Mon, 23 Dec 2019 12:08:01 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id E066580514; Mon, 23 Dec 2019 13:07:57 +0100 (CET) Date: Mon, 23 Dec 2019 13:07:56 +0100 From: Sam Ravnborg To: Jani Nikula Subject: Re: [PATCH v1 1/8] drm/print: document logging functions Message-ID: <20191223120756.GA10745@ravnborg.org> References: <20191221095553.13332-1-sam@ravnborg.org> <20191221095553.13332-2-sam@ravnborg.org> <87tv5ruvzf.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87tv5ruvzf.fsf@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=nLXQkpGwCpP5zMdhxRcA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joe Perches , Sean Paul , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jani. > > + * > > + * Each of the debug logging macros use a specific category, and the logging > > + * is filtered by the drm.debug module parameter. The &drm_debug_category enum > > + * specifies the values for the interface. > > + * > > + * Each drm_dbg_ macro logs to a DRM_UT_ category, > > + * except drm_dbg() that logs to DRM_UT_DRIVER. > > * > > * Enabling verbose debug messages is done through the drm.debug parameter, each > > * category being enabled by a bit: > > * > > * - drm.debug=0x1 will enable CORE messages > > * - drm.debug=0x2 will enable DRIVER messages > > + * - drm.debug=0x4 will enable KMS messages > > + * - drm.debug=0x8 will enable PRIME messages > > + * - drm.debug=0x10 will enable ATOMIC messages > > + * - drm.debug=0x20 will enable VBL messages > > + * - drm.debug=0x40 will enable STATE messages > > + * - drm.debug=0x80 will enable LEASE messages > > + * - drm.debug=0x100 will enable DP messages > > Maybe document this stuff in enum drm_debug_category where they're > defined instead? For the logging user it is much more convinient to have the logging filtering explained in one place. The enum already tell part of the story but then the reader needs to hunt for the information. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel