From: "Amadeusz Sławiński" <amade@asmblr.net>
To: Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: "David S . Miller" <davem@davemloft.net>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, "Amadeusz Sławiński" <amade@asmblr.net>
Subject: [PATCH 8/9] rtlwifi: rtl8723be: Make functions static & rm sw.h
Date: Mon, 23 Dec 2019 13:37:14 +0100 [thread overview]
Message-ID: <20191223123715.7177-9-amade@asmblr.net> (raw)
In-Reply-To: <20191223123715.7177-1-amade@asmblr.net>
Some of functions which were exposed in sw.h, are only used in sw.c, so
just make them static. This makes sw.h unnecessary, so remove it.
Signed-off-by: Amadeusz Sławiński <amade@asmblr.net>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c | 7 +++----
drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.h | 13 -------------
2 files changed, 3 insertions(+), 17 deletions(-)
delete mode 100644 drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.h
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
index 3c8528f0ecb3..36209ac5b208 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
@@ -13,7 +13,6 @@
#include "hw.h"
#include "fw.h"
#include "../rtl8723com/fw_common.h"
-#include "sw.h"
#include "trx.h"
#include "led.h"
#include "table.h"
@@ -64,7 +63,7 @@ static void rtl8723be_init_aspm_vars(struct ieee80211_hw *hw)
rtlpci->const_support_pciaspm = rtlpriv->cfg->mod_params->aspm_support;
}
-int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
+static int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
{
int err = 0;
struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -170,7 +169,7 @@ int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
return 0;
}
-void rtl8723be_deinit_sw_vars(struct ieee80211_hw *hw)
+static void rtl8723be_deinit_sw_vars(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
@@ -181,7 +180,7 @@ void rtl8723be_deinit_sw_vars(struct ieee80211_hw *hw)
}
/* get bt coexist status */
-bool rtl8723be_get_btc_status(void)
+static bool rtl8723be_get_btc_status(void)
{
return true;
}
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.h
deleted file mode 100644
index 6ecacf9fbfd7..000000000000
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.h
+++ /dev/null
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright(c) 2009-2014 Realtek Corporation.*/
-
-#ifndef __RTL8723BE_SW_H__
-#define __RTL8723BE_SW_H__
-
-int rtl8723be_init_sw_vars(struct ieee80211_hw *hw);
-void rtl8723be_deinit_sw_vars(struct ieee80211_hw *hw);
-void rtl8723be_init_var_map(struct ieee80211_hw *hw);
-bool rtl8723be_get_btc_status(void);
-
-
-#endif
--
2.24.1
next prev parent reply other threads:[~2019-12-23 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 12:37 [PATCH 0/9] rtlwifi: Cleanups Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 1/9] rtlwifi: rtl8192cu: Fix typo Amadeusz Sławiński
2020-01-26 15:40 ` Kalle Valo
2019-12-23 12:37 ` [PATCH 2/9] rtlwifi: rtl8188ee: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 3/9] rtlwifi: rtl8192ce: " Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 4/9] rtlwifi: rtl8192cu: Remove sw.h header Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 5/9] rtlwifi: rtl8192ee: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 6/9] rtlwifi: rtl8192se: Remove sw.h header Amadeusz Sławiński
2019-12-23 12:37 ` [PATCH 7/9] rtlwifi: rtl8723ae: Make functions static & rm sw.h Amadeusz Sławiński
2019-12-23 12:37 ` Amadeusz Sławiński [this message]
2019-12-23 12:37 ` [PATCH 9/9] rtlwifi: rtl8821ae: " Amadeusz Sławiński
2019-12-24 1:57 ` [PATCH 0/9] rtlwifi: Cleanups Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223123715.7177-9-amade@asmblr.net \
--to=amade@asmblr.net \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.