From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1 2/3] iio: st_lsm6dsx: Drop unneeded OF code
Date: Mon, 23 Dec 2019 16:11:23 +0000 [thread overview]
Message-ID: <20191223161123.6f14e15b@archlinux> (raw)
In-Reply-To: <20191216181925.927-2-andriy.shevchenko@linux.intel.com>
On Mon, 16 Dec 2019 20:19:24 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> There is no need to have OF guard against ID table.
> Drop it for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Agreed. Good to slowly push out this bit of legacy...
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c | 3 +--
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> index cd47ec1fedcb..0fb32131afce 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c
> @@ -12,7 +12,6 @@
> #include <linux/module.h>
> #include <linux/i2c.h>
> #include <linux/slab.h>
> -#include <linux/of.h>
> #include <linux/regmap.h>
>
> #include "st_lsm6dsx.h"
> @@ -122,7 +121,7 @@ static struct i2c_driver st_lsm6dsx_driver = {
> .driver = {
> .name = "st_lsm6dsx_i2c",
> .pm = &st_lsm6dsx_pm_ops,
> - .of_match_table = of_match_ptr(st_lsm6dsx_i2c_of_match),
> + .of_match_table = st_lsm6dsx_i2c_of_match,
> },
> .probe = st_lsm6dsx_i2c_probe,
> .id_table = st_lsm6dsx_i2c_id_table,
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> index 67ff36eac247..eb1086e4a951 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c
> @@ -12,7 +12,6 @@
> #include <linux/module.h>
> #include <linux/spi/spi.h>
> #include <linux/slab.h>
> -#include <linux/of.h>
> #include <linux/regmap.h>
>
> #include "st_lsm6dsx.h"
> @@ -122,7 +121,7 @@ static struct spi_driver st_lsm6dsx_driver = {
> .driver = {
> .name = "st_lsm6dsx_spi",
> .pm = &st_lsm6dsx_pm_ops,
> - .of_match_table = of_match_ptr(st_lsm6dsx_spi_of_match),
> + .of_match_table = st_lsm6dsx_spi_of_match,
> },
> .probe = st_lsm6dsx_spi_probe,
> .id_table = st_lsm6dsx_spi_id_table,
next prev parent reply other threads:[~2019-12-23 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 18:19 [PATCH v1 1/3] iio: st_lsm6dsx: Mark predefined constants with __maybe_unused Andy Shevchenko
2019-12-16 18:19 ` [PATCH v1 2/3] iio: st_lsm6dsx: Drop unneeded OF code Andy Shevchenko
2019-12-23 16:11 ` Jonathan Cameron [this message]
2019-12-16 18:19 ` [PATCH v1 3/3] iio: st_lsm6dsx: Make use of device properties Andy Shevchenko
2019-12-23 16:14 ` Jonathan Cameron
2019-12-23 16:10 ` [PATCH v1 1/3] iio: st_lsm6dsx: Mark predefined constants with __maybe_unused Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223161123.6f14e15b@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.