All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1 2/2] iio: pressure: bmp280: Allow device to be enumerated from ACPI
Date: Mon, 23 Dec 2019 18:06:11 +0000	[thread overview]
Message-ID: <20191223180611.6bd58c44@archlinux> (raw)
In-Reply-To: <20191209182805.56249-2-andriy.shevchenko@linux.intel.com>

On Mon,  9 Dec 2019 20:28:05 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> There is no need to limit the driver use by OF/platform code.
> In this case we simple remove redundant OF parts from the code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied,

Thanks,

Jonathan

> ---
>  drivers/iio/pressure/bmp280-i2c.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
> index 06f90853c141..8b03ea15c0d0 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -1,7 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  #include <linux/module.h>
>  #include <linux/i2c.h>
> -#include <linux/of.h>
>  #include <linux/regmap.h>
>  
>  #include "bmp280.h"
> @@ -37,7 +36,6 @@ static int bmp280_i2c_probe(struct i2c_client *client,
>  				   client->irq);
>  }
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id bmp280_of_i2c_match[] = {
>  	{ .compatible = "bosch,bme280", .data = (void *)BME280_CHIP_ID },
>  	{ .compatible = "bosch,bmp280", .data = (void *)BMP280_CHIP_ID },
> @@ -46,9 +44,6 @@ static const struct of_device_id bmp280_of_i2c_match[] = {
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, bmp280_of_i2c_match);
> -#else
> -#define bmp280_of_i2c_match NULL
> -#endif
>  
>  static const struct i2c_device_id bmp280_i2c_id[] = {
>  	{"bmp280", BMP280_CHIP_ID },
> @@ -62,7 +57,7 @@ MODULE_DEVICE_TABLE(i2c, bmp280_i2c_id);
>  static struct i2c_driver bmp280_i2c_driver = {
>  	.driver = {
>  		.name	= "bmp280",
> -		.of_match_table = of_match_ptr(bmp280_of_i2c_match),
> +		.of_match_table = bmp280_of_i2c_match,
>  		.pm = &bmp280_dev_pm_ops,
>  	},
>  	.probe		= bmp280_i2c_probe,


  reply	other threads:[~2019-12-23 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 18:28 [PATCH v1 1/2] iio: pressure: bmp280: Drop ACPI support Andy Shevchenko
2019-12-09 18:28 ` [PATCH v1 2/2] iio: pressure: bmp280: Allow device to be enumerated from ACPI Andy Shevchenko
2019-12-23 18:06   ` Jonathan Cameron [this message]
2019-12-23 18:06 ` [PATCH v1 1/2] iio: pressure: bmp280: Drop ACPI support Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191223180611.6bd58c44@archlinux \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.