From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E05C2D0CF for ; Tue, 24 Dec 2019 14:12:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7607420643 for ; Tue, 24 Dec 2019 14:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbfLXOMb convert rfc822-to-8bit (ORCPT ); Tue, 24 Dec 2019 09:12:31 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:55079 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfLXOMb (ORCPT ); Tue, 24 Dec 2019 09:12:31 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 3DF8E240007; Tue, 24 Dec 2019 14:12:26 +0000 (UTC) Date: Tue, 24 Dec 2019 15:12:22 +0100 From: Miquel Raynal To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter Cc: Rob Herring , Mark Rutland , , , dri-devel@lists.freedesktop.org, Paul Kocialkowski , Maxime Chevallier , Thomas Petazzoni Subject: Re: [PATCH v2 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Message-ID: <20191224151222.7164810d@xps13> In-Reply-To: <20191224140551.21227-3-miquel.raynal@bootlin.com> References: <20191224140551.21227-1-miquel.raynal@bootlin.com> <20191224140551.21227-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, Miquel Raynal wrote on Tue, 24 Dec 2019 15:05:51 +0100: > Add support for the Satoz SAT050AT40H12R2 RGB panel. > > Signed-off-by: Miquel Raynal > --- > > Changes since v1: > * Switched to display_timing's instead of display_mode. > > drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index ac6f6b5d200d..00538553a188 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2559,6 +2559,31 @@ static const struct panel_desc samsung_ltn140at29_301 = { > }, > }; > > +static const struct display_timing satoz_sat050at40h12r2_timing = { > + .pixelclock = { 33300000, 33300000, 50000000 }, > + .hactive = {800, 800, 800}, > + .hfront_porch = {16, 210, 354}, > + .hback_porch = {46, 46, 46}, > + .hsync_len = {1, 1, 40}, > + .vactive = {480, 480, 480}, > + .vfront_porch = {7, 22, 147}, > + .vback_porch = {23, 23, 23}, > + .vsync_len = {1, 1, 20}, > +}; > + > +static const struct panel_desc satoz_sat050at40h12r2 = { > + .timings = &satoz_sat050at40h12r2_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 108, > + .height = 65, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .reset_time = 10, > + .reset_wait = 1, I dit not generate the patch from the right branch: this is a proposal for the reset GPIO change and should not appear here. Please forget about this series, I will respin a v3 without these two lines. Sorry for the noise. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2119EC2D0D0 for ; Tue, 24 Dec 2019 14:31:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 017C1206D3 for ; Tue, 24 Dec 2019 14:31:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 017C1206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAE1D6E5C6; Tue, 24 Dec 2019 14:30:01 +0000 (UTC) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BAFB89B57 for ; Tue, 24 Dec 2019 14:12:31 +0000 (UTC) Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 3DF8E240007; Tue, 24 Dec 2019 14:12:26 +0000 (UTC) Date: Tue, 24 Dec 2019 15:12:22 +0100 From: Miquel Raynal To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter Subject: Re: [PATCH v2 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Message-ID: <20191224151222.7164810d@xps13> In-Reply-To: <20191224140551.21227-3-miquel.raynal@bootlin.com> References: <20191224140551.21227-1-miquel.raynal@bootlin.com> <20191224140551.21227-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 24 Dec 2019 14:29:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , Rob Herring , Thomas Petazzoni Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGVsbG8sCgpNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZSBv biBUdWUsIDI0IERlYyAyMDE5CjE1OjA1OjUxICswMTAwOgoKPiBBZGQgc3VwcG9ydCBmb3IgdGhl IFNhdG96IFNBVDA1MEFUNDBIMTJSMiBSR0IgcGFuZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWlx dWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KPiAtLS0KPiAKPiBDaGFuZ2Vz IHNpbmNlIHYxOgo+ICogU3dpdGNoZWQgdG8gZGlzcGxheV90aW1pbmcncyBpbnN0ZWFkIG9mIGRp c3BsYXlfbW9kZS4KPiAKPiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jIHwg MjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwt c2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiBpbmRleCBh YzZmNmI1ZDIwMGQuLjAwNTM4NTUzYTE4OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v cGFuZWwvcGFuZWwtc2ltcGxlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwt c2ltcGxlLmMKPiBAQCAtMjU1OSw2ICsyNTU5LDMxIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcGFu ZWxfZGVzYyBzYW1zdW5nX2x0bjE0MGF0MjlfMzAxID0gewo+ICAJfSwKPiAgfTsKPiAgCj4gK3N0 YXRpYyBjb25zdCBzdHJ1Y3QgZGlzcGxheV90aW1pbmcgc2F0b3pfc2F0MDUwYXQ0MGgxMnIyX3Rp bWluZyA9IHsKPiArCS5waXhlbGNsb2NrID0geyAzMzMwMDAwMCwgMzMzMDAwMDAsIDUwMDAwMDAw IH0sCj4gKwkuaGFjdGl2ZSA9IHs4MDAsIDgwMCwgODAwfSwKPiArCS5oZnJvbnRfcG9yY2ggPSB7 MTYsIDIxMCwgMzU0fSwKPiArCS5oYmFja19wb3JjaCA9IHs0NiwgNDYsIDQ2fSwKPiArCS5oc3lu Y19sZW4gPSB7MSwgMSwgNDB9LAo+ICsJLnZhY3RpdmUgPSB7NDgwLCA0ODAsIDQ4MH0sCj4gKwku dmZyb250X3BvcmNoID0gezcsIDIyLCAxNDd9LAo+ICsJLnZiYWNrX3BvcmNoID0gezIzLCAyMywg MjN9LAo+ICsJLnZzeW5jX2xlbiA9IHsxLCAxLCAyMH0sCj4gK307Cj4gKwo+ICtzdGF0aWMgY29u c3Qgc3RydWN0IHBhbmVsX2Rlc2Mgc2F0b3pfc2F0MDUwYXQ0MGgxMnIyID0gewo+ICsJLnRpbWlu Z3MgPSAmc2F0b3pfc2F0MDUwYXQ0MGgxMnIyX3RpbWluZywKPiArCS5udW1fdGltaW5ncyA9IDEs Cj4gKwkuYnBjID0gOCwKPiArCS5zaXplID0gewo+ICsJCS53aWR0aCA9IDEwOCwKPiArCQkuaGVp Z2h0ID0gNjUsCj4gKwl9LAo+ICsJLmJ1c19mb3JtYXQgPSBNRURJQV9CVVNfRk1UX1JHQjg4OF8x WDI0LAo+ICsJLnJlc2V0X3RpbWUgPSAxMCwKPiArCS5yZXNldF93YWl0ID0gMSwKCkkgZGl0IG5v dCBnZW5lcmF0ZSB0aGUgcGF0Y2ggZnJvbSB0aGUgcmlnaHQgYnJhbmNoOiB0aGlzIGlzIGEgcHJv cG9zYWwKZm9yIHRoZSByZXNldCBHUElPIGNoYW5nZSBhbmQgc2hvdWxkIG5vdCBhcHBlYXIgaGVy ZS4gUGxlYXNlIGZvcmdldAphYm91dCB0aGlzIHNlcmllcywgSSB3aWxsIHJlc3BpbiBhIHYzIHdp dGhvdXQgdGhlc2UgdHdvIGxpbmVzLgoKU29ycnkgZm9yIHRoZSBub2lzZS4KClRoYW5rcywKTWlx dcOobApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK