From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Add omap3-echo Date: Tue, 24 Dec 2019 10:45:03 -0800 Message-ID: <20191224184503.GK35479@atomide.com> References: <20191224161005.28083-1-nerv@dawncrow.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20191224161005.28083-1-nerv@dawncrow.de> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?QW5kcsOp?= Hentschel Cc: webmaster@dawncrow.de, linux@arm.linux.org.uk, robh+dt@kernel.org, mark.rutland@arm.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * André Hentschel [191224 16:11]: > This is the first generation Amazon Echo from 2016. > Audio support is not yet implemented. OK looks good to me, just worried about one part: > +&sgx_module { > + status = "disabled"; > +}; We should have a separate am3703.dtsi or whatever the SoC model disabling sgx if not there on the SoC. That way board specific dts files can just include it without having to debug this issue over and over. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFB3C2D0C3 for ; Tue, 24 Dec 2019 18:45:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 929BC206D3 for ; Tue, 24 Dec 2019 18:45:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rZJkC+q6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 929BC206D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yJd1hHKljjcn+RGkhbszTH10M3XAF9ZOBMQwxQF3284=; b=rZJkC+q6MC6kig xLwnabGDi3/MNZYczekkJXclWXyc26SqT8wS2QhDqyYrnR2oAcGD/ZTZjU0I8RvoRKHMsDI8x1wkW Bfd5TBKv5yAeelJ75p1kmtvpsKYPTuegsIyf5+Ko5AsI53HiTbXnnAUHwL5H6GBiq03CTYtfyqc7d qeccEsS2VPCvJ0PFeiYWQ6QmpEuEcSgmOujtn/2EssxyVuGtede0eArTWzDgflCOHU3VrodQJx+nH 4KBDGUqfohujw7HlRPGSG7Sblg9cbrVQ4mMK36ajYQ1vTbzB5GFg6XAN6+FEyM+Djdb3BzpobkAuZ eEHA0JEN3piOZ0X5Gx6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijpBE-0000Om-FG; Tue, 24 Dec 2019 18:45:16 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijpBA-00006H-HV for linux-arm-kernel@lists.infradead.org; Tue, 24 Dec 2019 18:45:15 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 751A88107; Tue, 24 Dec 2019 18:45:46 +0000 (UTC) Date: Tue, 24 Dec 2019 10:45:03 -0800 From: Tony Lindgren To: =?utf-8?B?QW5kcsOp?= Hentschel Subject: Re: [PATCH] ARM: dts: Add omap3-echo Message-ID: <20191224184503.GK35479@atomide.com> References: <20191224161005.28083-1-nerv@dawncrow.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191224161005.28083-1-nerv@dawncrow.de> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191224_104512_620211_15640075 X-CRM114-Status: UNSURE ( 8.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, webmaster@dawncrow.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBBbmRyw6kgSGVudHNjaGVsIDxuZXJ2QGRhd25jcm93LmRlPiBbMTkxMjI0IDE2OjExXToKPiBU aGlzIGlzIHRoZSBmaXJzdCBnZW5lcmF0aW9uIEFtYXpvbiBFY2hvIGZyb20gMjAxNi4KPiBBdWRp byBzdXBwb3J0IGlzIG5vdCB5ZXQgaW1wbGVtZW50ZWQuCgpPSyBsb29rcyBnb29kIHRvIG1lLCBq dXN0IHdvcnJpZWQgYWJvdXQgb25lIHBhcnQ6Cgo+ICsmc2d4X21vZHVsZSB7Cj4gKwlzdGF0dXMg PSAiZGlzYWJsZWQiOwo+ICt9OwoKV2Ugc2hvdWxkIGhhdmUgYSBzZXBhcmF0ZSBhbTM3MDMuZHRz aSBvciB3aGF0ZXZlciB0aGUgU29DIG1vZGVsCmRpc2FibGluZyBzZ3ggaWYgbm90IHRoZXJlIG9u IHRoZSBTb0MuIFRoYXQgd2F5IGJvYXJkIHNwZWNpZmljCmR0cyBmaWxlcyBjYW4ganVzdCBpbmNs dWRlIGl0IHdpdGhvdXQgaGF2aW5nIHRvIGRlYnVnIHRoaXMgaXNzdWUKb3ZlciBhbmQgb3Zlci4K ClJlZ2FyZHMsCgpUb255CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==