From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA4E9C2D0DA for ; Wed, 25 Dec 2019 09:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 867B120730 for ; Wed, 25 Dec 2019 09:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577265826; bh=WA6fzqWeVUiaVXy4CbreGbW6oOuIAQ7Qgv9xU7U+eu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=i8384s15ZcaiUlCl13rqaOfqPKavAlAn1cwP6xdeJcDKHTKcxNsykPDFouo8c2vzx 7wpTIVflZddjxSGYtlJjeIlUhwlc2Am9Xm7kOsNrtsN9n97vA/Ri1e0R09dtI+aD9s rG/e8/uM78QOiB36WOJ/5qoerpPW7BwQzPB2WiIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726106AbfLYJXp (ORCPT ); Wed, 25 Dec 2019 04:23:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:49416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfLYJXp (ORCPT ); Wed, 25 Dec 2019 04:23:45 -0500 Received: from localhost (unknown [5.29.147.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C20720730; Wed, 25 Dec 2019 09:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577265825; bh=WA6fzqWeVUiaVXy4CbreGbW6oOuIAQ7Qgv9xU7U+eu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yglV0gFRLpr1xDh+jIqol2hgtgorLhe2C7NX3JVUnd/h0R2/jzmoaBkjLDDFEkXLO xARkmyfLAz1/Crx3ie2CWg5ztv3G7oZMLJiLZiuCoxcbsdz+Lgvdf5oLyST/quFbQs CZGlHu+RXPjhEQr9e3zZDX+tL5JRiIy3Z9Vy4g6M= Date: Wed, 25 Dec 2019 11:23:41 +0200 From: Leon Romanovsky To: Frank Huang Cc: linux-rdma@vger.kernel.org Subject: Re: rxe panic Message-ID: <20191225092341.GC212002@unreal> References: <20191225063256.GB212002@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Dec 25, 2019 at 03:23:53PM +0800, Frank Huang wrote: > hi leon > > I can not get what you means, do you say the rxe_add_ref(qp) is not needed? It is not what I'm saying. The use of rxe_add_ref(qp) assumes that QP can't disappear while it is called. From what I see in the code, rxe_responder() doesn't guarantee that. Thanks