From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/lvm2: install udev rules
Date: Wed, 25 Dec 2019 23:29:03 +0100 [thread overview]
Message-ID: <20191225232903.6325bb98@windsurf> (raw)
In-Reply-To: <20191203090050.4382-1-p.debruijn@unilogic.nl>
Hello Pascal,
On Tue, 3 Dec 2019 10:00:50 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> Without the device-mapper udev rules, dm devices will not get a proper
> symlink like /dev/disk/by-label/LABEL, which in turn causes fstab
> LABEL= mounts to fails.
>
> And by extension causes shenanigans with systemd, where it will
> unmount a manually mounted disk because it can't resolve the label.
>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> package/lvm2/lvm2.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 7fdb9a7..65576f4 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \
> --enable-pkgconfig \
> --enable-cmdlib \
> --enable-dmeventd \
> + --enable-udev_rules \
Why should this be done unconditionally ? Shouldn't instead this be:
ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
LVM2_CONF_OPTS += --enable-udev_rules
endif
instead ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-25 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 9:00 [Buildroot] [PATCH] package/lvm2: install udev rules Pascal de Bruijn
2019-12-25 22:29 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-02 15:26 Pascal de Bruijn
2020-01-07 20:23 ` Thomas Petazzoni
2020-01-10 20:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191225232903.6325bb98@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.