From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, Merlijn Wajer <merlijn@wizzup.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/3] phy: cpcap-usb: Prevent USB line glitches from waking up modem
Date: Thu, 26 Dec 2019 11:47:45 +0100 [thread overview]
Message-ID: <20191226104745.GJ4033@amd> (raw)
In-Reply-To: <20191222181704.61511-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
On Sun 2019-12-22 10:17:02, Tony Lindgren wrote:
> The micro-USB connector on Motorola Mapphone devices can be muxed between
> the SoC and the mdm6600 modem. But even when used for the SoC, configuring
> the PHY with ID pin grounded will wake up the modem from idle state. Looks
> like the issue is probably caused by line glitches.
>
> We can prevent the glitches by using a previously unknown mode of the
> GPIO mux to prevent the USB lines from being connected to the moden while
> configuring the USB PHY, and enable the USB lines after configuring the
> PHY.
>
> Note that this only prevents waking up mdm6600 as regular USB A-host mode,
> and does not help when connected to a lapdock. The lapdock specific issue
> still needs to be debugged separately.
>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Nothing obviously wrong in the series.
Acked-by: Pavel Machek <pavel@ucw.cz>
Patch 2/ does not apply on top of 5.5-rc3 AFAICT.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2019-12-26 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 18:17 [PATCH 1/3] phy: cpcap-usb: Prevent USB line glitches from waking up modem Tony Lindgren
2019-12-22 18:17 ` [PATCH 2/3] phy: cpcap-usb: Improve host vs docked mode detection Tony Lindgren
2019-12-22 18:17 ` [PATCH 3/3] phy: cpcap-usb: Drop extra write to usb2 register Tony Lindgren
2019-12-26 10:47 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226104745.GJ4033@amd \
--to=pavel@ucw.cz \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.