From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] packfile: replace lseek+read with pread
Date: Thu, 26 Dec 2019 18:59:32 +0000 [thread overview]
Message-ID: <20191226185932.GA19165@dcvr> (raw)
In-Reply-To: <xmqqzhffkku2.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <e@80x24.org> writes:
> >
> > Furthermore, readers of the packfile will be using mmap
> > (or pread to emulate mmap), anyways, so the file description
> > offset does not matter in this case.
>
> s/description/descriptor/ probably.
No, I meant "description" :) The offset is shared in case of dup{,2,3}
syscalls, which only creates a new descriptor, not a new description.
Both the Linux and POSIX lseek(2) manpages say "description".
prev parent reply other threads:[~2019-12-26 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 10:42 [PATCH 0/2] packfile: small syscall reductions Eric Wong
2019-12-26 10:42 ` [PATCH 1/2] packfile: remove redundant fcntl F_GETFD/F_SETFD Eric Wong
2019-12-26 10:42 ` [PATCH 2/2] packfile: replace lseek+read with pread Eric Wong
2019-12-26 18:23 ` Junio C Hamano
2019-12-26 18:32 ` Junio C Hamano
2019-12-26 18:59 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226185932.GA19165@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.