From: Stephen Boyd <sboyd@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] clk: Don't try to enable critical clocks if prepare failed
Date: Thu, 26 Dec 2019 14:01:26 -0800 [thread overview]
Message-ID: <20191226220127.0006B2080D@mail.kernel.org> (raw)
In-Reply-To: <20191225163429.29694-1-linux@roeck-us.net>
Quoting Guenter Roeck (2019-12-25 08:34:29)
> The following traceback is seen if a critical clock fails to prepare.
>
> bcm2835-clk 3f101000.cprman: plld: couldn't lock PLL
> ------------[ cut here ]------------
> Enabling unprepared plld_per
> WARNING: CPU: 1 PID: 1 at drivers/clk/clk.c:1014 clk_core_enable+0xcc/0x2c0
> ...
> Call trace:
> clk_core_enable+0xcc/0x2c0
> __clk_register+0x5c4/0x788
> devm_clk_hw_register+0x4c/0xb0
> bcm2835_register_pll_divider+0xc0/0x150
> bcm2835_clk_probe+0x134/0x1e8
> platform_drv_probe+0x50/0xa0
> really_probe+0xd4/0x308
> driver_probe_device+0x54/0xe8
> device_driver_attach+0x6c/0x78
> __driver_attach+0x54/0xd8
> ...
>
> Check return values from clk_core_prepare() and clk_core_enable() and
> bail out if any of those functions returns an error.
>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 99652a469df1 ("clk: migrate the count of orphaned clocks at init")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2019-12-26 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 16:34 [PATCH] clk: Don't try to enable critical clocks if prepare failed Guenter Roeck
2019-12-26 9:51 ` Jerome Brunet
2019-12-26 17:22 ` Guenter Roeck
2019-12-26 21:59 ` Stephen Boyd
2019-12-27 4:05 ` Guenter Roeck
2019-12-26 22:01 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226220127.0006B2080D@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.