From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <nks@flawful.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static
Date: Thu, 26 Dec 2019 22:56:43 -0800 [thread overview]
Message-ID: <20191227065643.GN1908628@ripper> (raw)
In-Reply-To: <20191223141934.19837-6-nks@flawful.org>
On Mon 23 Dec 06:19 PST 2019, Niklas Cassel wrote:
> drivers/power/avs/qcom-cpr.c:1081:15:
> warning: no previous prototype for ‘cpr_get_opp_hz_for_req’
>
> Detected when running make with W=1.
>
And now also Reported-by: kbuild test robot <lkp@intel.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Niklas Cassel <nks@flawful.org>
> ---
> drivers/power/avs/qcom-cpr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 484dd498f8b9..9247f53550b3 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -1078,8 +1078,8 @@ static unsigned int cpr_get_fuse_corner(struct dev_pm_opp *opp)
> return fuse_corner;
> }
>
> -unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
> - struct device *cpu_dev)
> +static unsigned long cpr_get_opp_hz_for_req(struct dev_pm_opp *ref,
> + struct device *cpu_dev)
> {
> u64 rate = 0;
> struct device_node *ref_np;
> --
> 2.24.1
>
next prev parent reply other threads:[~2019-12-27 6:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:19 [PATCH 0/5] qcom-cpr fixes for rjw bleeding-edge Niklas Cassel
2019-12-23 14:19 ` [PATCH 1/5] power: avs: qcom-cpr: fix invalid printk specifier in debug print Niklas Cassel
2019-12-27 6:45 ` Bjorn Andersson
2019-12-23 14:19 ` [PATCH 2/5] power: avs: qcom-cpr: fix unsigned expression compared with zero Niklas Cassel
2019-12-27 6:47 ` Bjorn Andersson
2019-12-23 14:19 ` [PATCH 3/5] power: avs: qcom-cpr: make sure that regmap is available Niklas Cassel
2019-12-27 6:51 ` Bjorn Andersson
2019-12-23 14:19 ` [PATCH 4/5] power: avs: qcom-cpr: remove set but unused variable Niklas Cassel
2019-12-27 6:52 ` Bjorn Andersson
2019-12-23 14:19 ` [PATCH 5/5] power: avs: qcom-cpr: make cpr_get_opp_hz_for_req() static Niklas Cassel
2019-12-27 6:56 ` Bjorn Andersson [this message]
2019-12-29 22:45 ` [PATCH 0/5] qcom-cpr fixes for rjw bleeding-edge Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227065643.GN1908628@ripper \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nks@flawful.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.