From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH 5/5] ippool: Fix strncpy -Wformat-truncation warning
Date: Fri, 27 Dec 2019 10:12:04 +0200 [thread overview]
Message-ID: <20191227081204.GF19235@localhost> (raw)
In-Reply-To: <20191227035639.303716-5-raj.khem@gmail.com>
On Thu, Dec 26, 2019 at 07:56:39PM -0800, Khem Raj wrote:
>...
> +--- a/cli/cli_readline.c
> ++++ b/cli/cli_readline.c
> +@@ -261,6 +261,11 @@ static void cli_rl_display_wrapped_text(
> + if (left_margin == 0) {
> + left_margin = 3;
> + }
> ++
> ++ if (left_margin >= strlen(text_buf)) {
> ++ left_margin = strlen(text_buf);
> ++ }
>...
This doesn't make sense, text_buf is an uninitialized variable.
cu
Adrian
next prev parent reply other threads:[~2019-12-27 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 3:56 [meta-multimedia][PATCH 1/5] mpd: Fix build with gcc10 Khem Raj
2019-12-27 3:56 ` [meta-oe][PATCH 2/5] wvstreams: " Khem Raj
2019-12-27 3:56 ` [meta-multimedia][PATCH 3/5] tvheadend: Fix format-truncation warnings Khem Raj
2019-12-27 3:56 ` [meta-oe][PATCH 4/5] open-vm-tools: Ignore -Warray-bounds Khem Raj
2019-12-27 3:56 ` [meta-networking][PATCH 5/5] ippool: Fix strncpy -Wformat-truncation warning Khem Raj
2019-12-27 5:26 ` Adrian Bunk
2019-12-27 8:12 ` Adrian Bunk [this message]
2019-12-27 8:48 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227081204.GF19235@localhost \
--to=bunk@stusta.de \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.