From: Guenter Roeck <linux@roeck-us.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Peter Chen <peter.chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: host: Disable port power only if previously enabled
Date: Sun, 29 Dec 2019 08:28:11 -0800 [thread overview]
Message-ID: <20191229162811.GA21566@roeck-us.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1912281431190.18379-100000@netrider.rowland.org>
On Sat, Dec 28, 2019 at 02:33:01PM -0500, Alan Stern wrote:
>
> Let's try a slightly different approach. What happens with this patch?
>
> Alan Stern
>
>
> Index: usb-devel/drivers/usb/core/hub.c
> ===================================================================
> --- usb-devel.orig/drivers/usb/core/hub.c
> +++ usb-devel/drivers/usb/core/hub.c
> @@ -1065,6 +1065,7 @@ static void hub_activate(struct usb_hub
> if (type == HUB_INIT) {
> delay = hub_power_on_good_delay(hub);
>
> + hub->power_bits[0] = ~0UL; /* All ports on */
> hub_power_on(hub, false);
> INIT_DELAYED_WORK(&hub->init_work, hub_init_func2);
> queue_delayed_work(system_power_efficient_wq,
>
That doesn't make a difference - the traceback is still seen with this patch
applied.
Guenter
next prev parent reply other threads:[~2019-12-29 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 15:57 [PATCH] usb: chipidea: host: Disable port power only if previously enabled Guenter Roeck
2019-12-26 19:46 ` Alan Stern
2019-12-27 1:45 ` Peter Chen
2019-12-27 14:47 ` Alan Stern
2019-12-27 16:55 ` Guenter Roeck
2019-12-28 19:33 ` Alan Stern
2019-12-29 16:28 ` Guenter Roeck [this message]
2019-12-29 16:40 ` Alan Stern
2019-12-30 0:57 ` Guenter Roeck
2020-01-01 22:09 ` Guenter Roeck
2020-01-02 2:30 ` Alan Stern
2019-12-27 1:45 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191229162811.GA21566@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=peter.chen@freescale.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.