From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Chris Mason <clm@fb.com>
Subject: Re: [PATCH] block: fix splitting segments
Date: Mon, 30 Dec 2019 09:25:37 +0800 [thread overview]
Message-ID: <20191230012537.GC21985@ming.t460p> (raw)
In-Reply-To: <b1969f9b-5b40-ed58-b020-ae0a4a328384@acm.org>
On Sun, Dec 29, 2019 at 05:15:49PM -0800, Bart Van Assche wrote:
> On 2019-12-29 08:14, Jens Axboe wrote:
> > On 12/28/19 7:32 PM, Ming Lei wrote:
> >> There are two issues in get_max_segment_size():
> >>
> >> 1) the default segment boudary mask is bypassed, and some devices still
> >> require segment to not cross the default 4G boundary
> >>
> >> 2) the segment start address isn't taken into account when checking
> >> segment boundary limit
> >>
> >> Fixes the two issues.
> >
> > Given the potential severity of the bug, I think it deserves a somewhat
> > richer explanation than just that. It should also go into stable. This
> > is what I queued up:
> >
> > https://git.kernel.dk/cgit/linux-block/commit/?h=block-5.5&id=add1fc07334260253dfa880d9c964edc8381deac
>
> Although this patch looks fine to me, seeing Jens' patch description
> makes me wonder whether the DMA segment boundary for the mpt3sas adapter
> should be made explicit, e.g. by setting the SCSI host .dma_boundary
> parameter in the mpt3sas driver? From the SCSI core:
>
> blk_queue_segment_boundary(q, shost->dma_boundary);
See scsi_host_alloc():
...
/*
* assume a 4GB boundary, if not set
*/
if (sht->dma_boundary)
shost->dma_boundary = sht->dma_boundary;
else
shost->dma_boundary = 0xffffffff;
Thanks,
Ming
next prev parent reply other threads:[~2019-12-30 1:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 2:32 [PATCH] block: fix splitting segments Ming Lei
2019-12-29 16:14 ` Jens Axboe
2019-12-30 1:15 ` Bart Van Assche
2019-12-30 1:25 ` Ming Lei [this message]
2020-01-07 12:47 ` Guenter Roeck
2020-01-07 15:23 ` Ming Lei
2020-01-07 18:11 ` Guenter Roeck
2020-01-07 22:30 ` Ming Lei
2020-01-07 22:32 ` Jens Axboe
2020-01-08 1:59 ` Ming Lei
2020-01-08 2:36 ` Jens Axboe
2020-01-07 23:06 ` Guenter Roeck
2020-01-08 14:02 ` Christoph Hellwig
2020-01-09 2:03 ` Ming Lei
2020-01-09 7:16 ` Christoph Hellwig
2020-01-09 15:18 ` Jens Axboe
2020-01-10 2:58 ` Ming Lei
2020-01-10 3:00 ` Ming Lei
2020-01-10 5:10 ` Guenter Roeck
2020-01-10 6:37 ` Ming Lei
2020-01-10 7:15 ` Ming Lei
2020-01-10 12:48 ` Guenter Roeck
2020-01-10 12:36 ` Guenter Roeck
2020-01-11 12:57 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230012537.GC21985@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=clm@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.