From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Add omap3-echo Date: Mon, 30 Dec 2019 09:29:48 -0800 Message-ID: <20191230172948.GL35479@atomide.com> References: <20191224161005.28083-1-nerv@dawncrow.de> <20191224184503.GK35479@atomide.com> <60412339-53BF-4DC1-8AF6-4FB0E75D429C@goldelico.com> <53e6cbbd-1094-cba2-4942-981502a738d4@dawncrow.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <53e6cbbd-1094-cba2-4942-981502a738d4@dawncrow.de> Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?QW5kcsOp?= Hentschel Cc: "H. Nikolaus Schaller" , Adam Ford , linux@arm.linux.org.uk, robh+dt@kernel.org, mark.rutland@arm.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * André Hentschel [191227 14:29]: > Am 25.12.19 um 18:01 schrieb H. Nikolaus Schaller: > > I think the am3703 is a dm3730 (omap3630) where the SGX and the > > DSP have not passed production test and are "disabled" by eFuses. > > This is a common procedure in silicon production to increase yield. > > > > Therefore, there is a register which allows to dynamically determine > > what components (SGX and DSP) are available on a specific SoC chip. > > See "Table 1-6. Chip Identification" in the common > > "AM/DM37x Multimedia Device TRM". > > > > Such bits exists for omap34xx and for omap36xx (aka am37xx/dm37xx). > > > > That way there is no need to disable/enable sgx through device tree > > variations and introducing more complexity by introducing more and more > > DTS for variants (am3703.dtsi, am3715.dtsi, dm3720.dtsi, dm3730.dtsi?). > > > > BTW: what about a board that is/was produced in either am3703 or dm3730 > > variants? Can they still share an omap36xx.dtsi based DTB? > > > > So IMHO if there is an issue with sgx enabled on am3703 but no SGX > > hardware available on a specific SoC, the sysc setup should somehow read > > the bits and effectively disable all SGX related setup if it is not > > available on the SoC. If I remember correctly, some older hwmods did > > such things by checking SoC variant bits. > > I like the idea, but I'm not in the position to vote for it and I don't > understand the sysc code enough to implement that. We can easily do both. So no worries, I can easily add SoC capabilites support at some point. > Am 25.12.19 um 13:53 schrieb Adam Ford: > > On Wed, Dec 25, 2019 at 6:05 AM André Hentschel wrote: > >> And then include am3703.dtsi in omap36xx.dtsi before sgx support? > > I can see value in having a 3703 base and including that in the 36xx > > with SGX and DSP nodes, but why not jus make SGX disabled by default. > > Those who want/need it can enable it on a per-board basis. > >> Or would it be better to have sgx support in a separate dtsi? > > > > I am not sure how much DSP stuff is in there, but the DM3730 is the > > AM3703 + DSP and 3D. > > For clarification this reduced table should help: > DM3730 | DM3725 | AM3715 | AM3703 > DSP X | X | | > SGX X | | X | > > Where X is "supported" And let's also add minimal dm3725.dtsi, am3715.dtsi and am3703.dtsi to make things simple. The device tree is supposed to describe the hardware, and in most cases the SoC version is fixed and need no dynamic detection. André, can you please add those three dtsi files since you have at least one test case? :) Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45733C2D0C2 for ; Mon, 30 Dec 2019 17:30:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C23E206DB for ; Mon, 30 Dec 2019 17:30:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rj1kDaNg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C23E206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZSa4FjlQL54RVB5SDRc9HSiKKad4LEO9BQj4k2iGij4=; b=rj1kDaNgb/akUJ K3AGC0muk2HzOeZnVf5uJsIgOwbuB91f8ru+UvL9nsjqdNSIWqTfqoylrUvfou2lAO3srIJ7HPsum UxLqipsx7T08x3LvjEhYXYfh3JKDKpHPjD0VbaX0FkQr3u3JssHImpkgY9QhqgEaSlj3Vmzy4w+8t lFuLakdx+bUNsH07RUQgiQOf3GiVmkQMM3LtNPMwBBeqSU3y8a7cngDeb1VAhd3kCOQ2FaYEctuyU jGtkDL13n3xtwah+DWT+TfYCalRfUrEUH5YOr8NPjQT28IQZDWw2IJ7W1cHZl71wbPJ3gfx8ZKCO2 qlR+ZdL9DN+H19IRpGdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ilyri-0003hF-Tw; Mon, 30 Dec 2019 17:30:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ilyre-0003fq-Pd for linux-arm-kernel@lists.infradead.org; Mon, 30 Dec 2019 17:30:00 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 87C948027; Mon, 30 Dec 2019 17:30:31 +0000 (UTC) Date: Mon, 30 Dec 2019 09:29:48 -0800 From: Tony Lindgren To: =?utf-8?B?QW5kcsOp?= Hentschel Subject: Re: [PATCH] ARM: dts: Add omap3-echo Message-ID: <20191230172948.GL35479@atomide.com> References: <20191224161005.28083-1-nerv@dawncrow.de> <20191224184503.GK35479@atomide.com> <60412339-53BF-4DC1-8AF6-4FB0E75D429C@goldelico.com> <53e6cbbd-1094-cba2-4942-981502a738d4@dawncrow.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53e6cbbd-1094-cba2-4942-981502a738d4@dawncrow.de> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191230_092958_874348_B699EE98 X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, "H. Nikolaus Schaller" , linux-kernel@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, linux-omap@vger.kernel.org, Adam Ford , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org KiBBbmRyw6kgSGVudHNjaGVsIDxuZXJ2QGRhd25jcm93LmRlPiBbMTkxMjI3IDE0OjI5XToKPiBB bSAyNS4xMi4xOSB1bSAxODowMSBzY2hyaWViIEguIE5pa29sYXVzIFNjaGFsbGVyOgo+ID4gSSB0 aGluayB0aGUgYW0zNzAzIGlzIGEgZG0zNzMwIChvbWFwMzYzMCkgd2hlcmUgdGhlIFNHWCBhbmQg dGhlCj4gPiBEU1AgaGF2ZSBub3QgcGFzc2VkIHByb2R1Y3Rpb24gdGVzdCBhbmQgYXJlICJkaXNh YmxlZCIgYnkgZUZ1c2VzLgo+ID4gVGhpcyBpcyBhIGNvbW1vbiBwcm9jZWR1cmUgaW4gc2lsaWNv biBwcm9kdWN0aW9uIHRvIGluY3JlYXNlIHlpZWxkLgo+ID4gCj4gPiBUaGVyZWZvcmUsIHRoZXJl IGlzIGEgcmVnaXN0ZXIgd2hpY2ggYWxsb3dzIHRvIGR5bmFtaWNhbGx5IGRldGVybWluZQo+ID4g d2hhdCBjb21wb25lbnRzIChTR1ggYW5kIERTUCkgYXJlIGF2YWlsYWJsZSBvbiBhIHNwZWNpZmlj IFNvQyBjaGlwLgo+ID4gU2VlICJUYWJsZSAxLTYuIENoaXAgSWRlbnRpZmljYXRpb24iIGluIHRo ZSBjb21tb24KPiA+ICJBTS9ETTM3eCBNdWx0aW1lZGlhIERldmljZSBUUk0iLgo+ID4gCj4gPiBT dWNoIGJpdHMgZXhpc3RzIGZvciBvbWFwMzR4eCBhbmQgZm9yIG9tYXAzNnh4IChha2EgYW0zN3h4 L2RtMzd4eCkuCj4gPiAKPiA+IFRoYXQgd2F5IHRoZXJlIGlzIG5vIG5lZWQgdG8gZGlzYWJsZS9l bmFibGUgc2d4IHRocm91Z2ggZGV2aWNlIHRyZWUKPiA+IHZhcmlhdGlvbnMgYW5kIGludHJvZHVj aW5nIG1vcmUgY29tcGxleGl0eSBieSBpbnRyb2R1Y2luZyBtb3JlIGFuZCBtb3JlCj4gPiBEVFMg Zm9yIHZhcmlhbnRzIChhbTM3MDMuZHRzaSwgYW0zNzE1LmR0c2ksIGRtMzcyMC5kdHNpLCBkbTM3 MzAuZHRzaT8pLgo+ID4gCj4gPiBCVFc6IHdoYXQgYWJvdXQgYSBib2FyZCB0aGF0IGlzL3dhcyBw cm9kdWNlZCBpbiBlaXRoZXIgYW0zNzAzIG9yIGRtMzczMAo+ID4gdmFyaWFudHM/IENhbiB0aGV5 IHN0aWxsIHNoYXJlIGFuIG9tYXAzNnh4LmR0c2kgYmFzZWQgRFRCPwo+ID4gCj4gPiBTbyBJTUhP IGlmIHRoZXJlIGlzIGFuIGlzc3VlIHdpdGggc2d4IGVuYWJsZWQgb24gYW0zNzAzIGJ1dCBubyBT R1gKPiA+IGhhcmR3YXJlIGF2YWlsYWJsZSBvbiBhIHNwZWNpZmljIFNvQywgdGhlIHN5c2Mgc2V0 dXAgc2hvdWxkIHNvbWVob3cgcmVhZAo+ID4gdGhlIGJpdHMgYW5kIGVmZmVjdGl2ZWx5IGRpc2Fi bGUgYWxsIFNHWCByZWxhdGVkIHNldHVwIGlmIGl0IGlzIG5vdAo+ID4gYXZhaWxhYmxlIG9uIHRo ZSBTb0MuIElmIEkgcmVtZW1iZXIgY29ycmVjdGx5LCBzb21lIG9sZGVyIGh3bW9kcyBkaWQKPiA+ IHN1Y2ggdGhpbmdzIGJ5IGNoZWNraW5nIFNvQyB2YXJpYW50IGJpdHMuCj4gCj4gSSBsaWtlIHRo ZSBpZGVhLCBidXQgSSdtIG5vdCBpbiB0aGUgcG9zaXRpb24gdG8gdm90ZSBmb3IgaXQgYW5kIEkg ZG9uJ3QKPiB1bmRlcnN0YW5kIHRoZSBzeXNjIGNvZGUgZW5vdWdoIHRvIGltcGxlbWVudCB0aGF0 LgoKV2UgY2FuIGVhc2lseSBkbyBib3RoLiBTbyBubyB3b3JyaWVzLCBJIGNhbiBlYXNpbHkgYWRk IFNvQyBjYXBhYmlsaXRlcwpzdXBwb3J0IGF0IHNvbWUgcG9pbnQuCgo+IEFtIDI1LjEyLjE5IHVt IDEzOjUzIHNjaHJpZWIgQWRhbSBGb3JkOgo+ID4gT24gV2VkLCBEZWMgMjUsIDIwMTkgYXQgNjow NSBBTSBBbmRyw6kgSGVudHNjaGVsIDxuZXJ2QGRhd25jcm93LmRlPiB3cm90ZToKPiA+PiBBbmQg dGhlbiBpbmNsdWRlIGFtMzcwMy5kdHNpIGluIG9tYXAzNnh4LmR0c2kgYmVmb3JlIHNneCBzdXBw b3J0Pwo+ID4gSSBjYW4gc2VlIHZhbHVlIGluIGhhdmluZyBhIDM3MDMgYmFzZSBhbmQgaW5jbHVk aW5nIHRoYXQgaW4gdGhlIDM2eHgKPiA+IHdpdGggU0dYIGFuZCBEU1Agbm9kZXMsIGJ1dCB3aHkg bm90IGp1cyBtYWtlIFNHWCBkaXNhYmxlZCBieSBkZWZhdWx0Lgo+ID4gVGhvc2Ugd2hvIHdhbnQv bmVlZCBpdCBjYW4gZW5hYmxlIGl0IG9uIGEgcGVyLWJvYXJkIGJhc2lzLgo+ID4+IE9yIHdvdWxk IGl0IGJlIGJldHRlciB0byBoYXZlIHNneCBzdXBwb3J0IGluIGEgc2VwYXJhdGUgZHRzaT8KPiA+ IAo+ID4gSSBhbSBub3Qgc3VyZSBob3cgbXVjaCBEU1Agc3R1ZmYgaXMgaW4gdGhlcmUsIGJ1dCB0 aGUgRE0zNzMwIGlzIHRoZQo+ID4gQU0zNzAzICsgRFNQIGFuZCAzRC4KPiAKPiBGb3IgY2xhcmlm aWNhdGlvbiB0aGlzIHJlZHVjZWQgdGFibGUgc2hvdWxkIGhlbHA6Cj4gICAgICBETTM3MzAgfCBE TTM3MjUgfCBBTTM3MTUgfCBBTTM3MDMKPiBEU1AgICAgWCAgICB8ICAgWCAgICB8ICAgICAgICB8 ICAgIAo+IFNHWCAgICBYICAgIHwgICAgICAgIHwgICBYICAgIHwgICAgCj4gCj4gV2hlcmUgWCBp cyAic3VwcG9ydGVkIgoKQW5kIGxldCdzIGFsc28gYWRkIG1pbmltYWwgZG0zNzI1LmR0c2ksIGFt MzcxNS5kdHNpIGFuZCBhbTM3MDMuZHRzaQp0byBtYWtlIHRoaW5ncyBzaW1wbGUuIFRoZSBkZXZp Y2UgdHJlZSBpcyBzdXBwb3NlZCB0byBkZXNjcmliZSB0aGUKaGFyZHdhcmUsIGFuZCBpbiBtb3N0 IGNhc2VzIHRoZSBTb0MgdmVyc2lvbiBpcyBmaXhlZCBhbmQgbmVlZCBubwpkeW5hbWljIGRldGVj dGlvbi4KCkFuZHLDqSwgY2FuIHlvdSBwbGVhc2UgYWRkIHRob3NlIHRocmVlIGR0c2kgZmlsZXMg c2luY2UgeW91IGhhdmUgYXQKbGVhc3Qgb25lIHRlc3QgY2FzZT8gOikKClJlZ2FyZHMsCgpUb255 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==