From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 245E7C2D0C3 for ; Mon, 30 Dec 2019 20:37:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAE0320718 for ; Mon, 30 Dec 2019 20:37:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Awv+gNoH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="G6sDaIa4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAE0320718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=92p7hrPvx5bDHn8bfPVSVf5nx3Niu/7vpg4gGmJQJos=; b=Awv+gNoHM8QtB+ SJVnuCvVXDrR/hi4xruLD4niI8RFX9Whnwg8DAcZuYMgLcS6ObLgJBX+Vb+jW6ewjcZcuakqf3DRt fCvg4kwX7vh6IjZwDUV7nyUFeDZyTJ8cqihYXKnRfYGQCMQ+lvydw8V0/co+zu2d+8ORrcX2tk4XP RtevaAornvkVWAAm7/QNj7kKEL1MLwC1HU748icXmCvgA9HkriTMoDFnNGOda2pD4f/j9nLwLmfzn bmuo9C7Z9l9a19oKWIWJ7VoffiAzG5yz3ZMDz2IUh8dHKCdlWTY1P9G8gVG8bii7+98YSsvJjKeID BP3aTCrleUiy9KsdbYig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1im1ma-0006CT-FD; Mon, 30 Dec 2019 20:36:56 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1im1mP-00063l-H9; Mon, 30 Dec 2019 20:36:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SXdGQUakfHybtX0jGG9d+Xw/HkMyol+MPHYTh6dQ3U4=; b=G6sDaIa4Z25UB8aomFAcrsYCxZ sHFxTi0i4H9s4qWhRn4C48sxjLww49Qqy7d0sMS3bqs9wzaNysXFjyhJJ1HsaMmC5d2mVBuQrMqCY XMAh9tp2x8TJRQRtngzHnGf9Eu8UdH6/Xkq5/TXmMV21bzOFORXZO94hq7H1fSecWwj4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1im1lw-0006Vp-L5; Mon, 30 Dec 2019 21:36:16 +0100 Date: Mon, 30 Dec 2019 21:36:16 +0100 From: Andrew Lunn To: Florian Fainelli Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks Message-ID: <20191230203616.GA24733@lunn.ch> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191230_123645_571622_BDCBB57C X-CRM114-Status: UNSURE ( 8.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Jakub Kicinski , Alexander Lobakin , Yoshiki Komachi , linux-kernel@vger.kernel.org, Eric Dumazet , Stanislav Fomichev , Matteo Croce , Edward Cree , Jakub Sitnicki , Daniel Borkmann , Paolo Abeni , Vivien Didelot , Hauke Mehrtens , Sean Wang , Jiri Pirko , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Paul Blakey , Stephen Hemminger , "David S. Miller" , Taehee Yoo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote: > On 12/30/19 6:30 AM, Alexander Lobakin wrote: > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process > > such frames. > > > > Signed-off-by: Alexander Lobakin > > This is a good example and we should probably build a tagger abstraction > that is much simpler to fill in callbacks for (although indirect > function calls may end-up killing performance with retpoline and > friends), but let's consider this idea. Hi Florian We really do need some numbers here. Does GRO really help? On an ARM or MIPS platform, i don't think retpoline is an issue? But x86 is, and we do have a few x86 boards with switches. Maybe we can do some macro magic instead of function pointers, if we can keep it all within one object file? Andrew _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83751C2D0CE for ; Mon, 30 Dec 2019 20:36:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D95920718 for ; Mon, 30 Dec 2019 20:36:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h6NDg6iU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="G6sDaIa4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D95920718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DJQXYpMdj4Yf58tVmNLQCscLmIZ+f+8M473iItq1Wgc=; b=h6NDg6iUEqsbdA tdJyCEHVXJ0oysihjrsYvBzKRJKeW5MQnJmo1AYmv72GlzGs9auzX3hYLAe2rSvKPimRNH6SNZ14N sVT+GmdRzwmkm9Avqre5UmL4Z9AIStANtVoPYFDN1dHAn5v6xmfMWYR8iVaskvHKY7k4xM+4tFjtw DDmPDDtzknFMMYy7LRIwmK8qGjVpxhFsmgi+SJ/BVBdS7W43EgdxZcbMNCYRc+xXSUqjon+ZFvI8X 5m4JNe3iji/lkC2GiZqKL96RiJYjq7uIXIOClmRo1GcznEL5gi8y2rmPFuVFJTlZHoDCoZUBxgUNT frZrrbrorjINkMeBjTsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1im1mS-000649-NG; Mon, 30 Dec 2019 20:36:48 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1im1mP-00063l-H9; Mon, 30 Dec 2019 20:36:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SXdGQUakfHybtX0jGG9d+Xw/HkMyol+MPHYTh6dQ3U4=; b=G6sDaIa4Z25UB8aomFAcrsYCxZ sHFxTi0i4H9s4qWhRn4C48sxjLww49Qqy7d0sMS3bqs9wzaNysXFjyhJJ1HsaMmC5d2mVBuQrMqCY XMAh9tp2x8TJRQRtngzHnGf9Eu8UdH6/Xkq5/TXmMV21bzOFORXZO94hq7H1fSecWwj4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1im1lw-0006Vp-L5; Mon, 30 Dec 2019 21:36:16 +0100 Date: Mon, 30 Dec 2019 21:36:16 +0100 From: Andrew Lunn To: Florian Fainelli Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks Message-ID: <20191230203616.GA24733@lunn.ch> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191230_123645_571622_BDCBB57C X-CRM114-Status: UNSURE ( 8.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Jakub Kicinski , Alexander Lobakin , Yoshiki Komachi , linux-kernel@vger.kernel.org, Eric Dumazet , Stanislav Fomichev , Matteo Croce , Edward Cree , Jakub Sitnicki , Daniel Borkmann , Paolo Abeni , Vivien Didelot , Hauke Mehrtens , Sean Wang , Jiri Pirko , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Paul Blakey , Stephen Hemminger , "David S. Miller" , Taehee Yoo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote: > On 12/30/19 6:30 AM, Alexander Lobakin wrote: > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process > > such frames. > > > > Signed-off-by: Alexander Lobakin > > This is a good example and we should probably build a tagger abstraction > that is much simpler to fill in callbacks for (although indirect > function calls may end-up killing performance with retpoline and > friends), but let's consider this idea. Hi Florian We really do need some numbers here. Does GRO really help? On an ARM or MIPS platform, i don't think retpoline is an issue? But x86 is, and we do have a few x86 boards with switches. Maybe we can do some macro magic instead of function pointers, if we can keep it all within one object file? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07AAC2D0C3 for ; Mon, 30 Dec 2019 20:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DB2820718 for ; Mon, 30 Dec 2019 20:36:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="G6sDaIa4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727757AbfL3Ugp (ORCPT ); Mon, 30 Dec 2019 15:36:45 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43844 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbfL3Ugp (ORCPT ); Mon, 30 Dec 2019 15:36:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SXdGQUakfHybtX0jGG9d+Xw/HkMyol+MPHYTh6dQ3U4=; b=G6sDaIa4Z25UB8aomFAcrsYCxZ sHFxTi0i4H9s4qWhRn4C48sxjLww49Qqy7d0sMS3bqs9wzaNysXFjyhJJ1HsaMmC5d2mVBuQrMqCY XMAh9tp2x8TJRQRtngzHnGf9Eu8UdH6/Xkq5/TXmMV21bzOFORXZO94hq7H1fSecWwj4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1im1lw-0006Vp-L5; Mon, 30 Dec 2019 21:36:16 +0100 Date: Mon, 30 Dec 2019 21:36:16 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Alexander Lobakin , "David S. Miller" , Edward Cree , Vivien Didelot , Hauke Mehrtens , Sean Wang , Matthias Brugger , Jiri Pirko , Eric Dumazet , Paolo Abeni , Jakub Kicinski , Taehee Yoo , Stephen Hemminger , Stanislav Fomichev , Daniel Borkmann , Song Liu , Matteo Croce , Jakub Sitnicki , Paul Blakey , Yoshiki Komachi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks Message-ID: <20191230203616.GA24733@lunn.ch> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 30, 2019 at 10:20:50AM -0800, Florian Fainelli wrote: > On 12/30/19 6:30 AM, Alexander Lobakin wrote: > > Add GRO callbacks to the AR9331 tagger so GRO layer can now process > > such frames. > > > > Signed-off-by: Alexander Lobakin > > This is a good example and we should probably build a tagger abstraction > that is much simpler to fill in callbacks for (although indirect > function calls may end-up killing performance with retpoline and > friends), but let's consider this idea. Hi Florian We really do need some numbers here. Does GRO really help? On an ARM or MIPS platform, i don't think retpoline is an issue? But x86 is, and we do have a few x86 boards with switches. Maybe we can do some macro magic instead of function pointers, if we can keep it all within one object file? Andrew