All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
	Pallantla Poornima <pallantlax.poornima@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/mempool: fix false positive test result
Date: Wed, 06 Nov 2019 11:44:03 +0100	[thread overview]
Message-ID: <2019215.qk59VCdi0P@xps> (raw)
In-Reply-To: <5949ceea-52d2-d32a-f944-a5c2c633239b@solarflare.com>

04/11/2019 13:42, Andrew Rybchenko:
> On 11/4/19 1:06 PM, Olivier Matz wrote:
> > The ret variable, initialized to -1, is changed to 0 during the test,
> > making the test successful in some cases where it should return a
> > failure.
> >
> > Fix this by always using the GOTO_ERR() macro that sets the ret
> > variable before doing the goto.
> >
> > Fixes: 923ceaeac140 ("test/mempool: add unit test cases")
> > Cc: Pallantla Poornima <pallantlax.poornima@intel.com>
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks



      reply	other threads:[~2019-11-06 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 10:06 [dpdk-dev] [PATCH] test/mempool: fix false positive test result Olivier Matz
2019-11-04 12:42 ` Andrew Rybchenko
2019-11-06 10:44   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2019215.qk59VCdi0P@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=pallantlax.poornima@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.