From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 10 Mar 2015 13:33:23 +0100 Subject: [PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering In-Reply-To: <20150310120750.GE28806@sirena.org.uk> References: <1429128.MSqYm0qZ9p@phil> <9261130.uPvufuEFrr@phil> <20150310120750.GE28806@sirena.org.uk> Message-ID: <2019237.rjYDPBpg0A@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, 10. M?rz 2015, 12:07:50 schrieb Mark Brown: > On Tue, Mar 10, 2015 at 12:22:06AM +0100, Heiko Stuebner wrote: > > When {devm_}regulator_get returns -EPROBE_DEFER the driver in question > > will > > try probing again at a later time. So don't spam the log with failure > > messages as this is an expected result of probe ordering. > > > > - dev_err(dev, "Failed to get supply '%s': %d\n", > > - consumers[i].supply, ret); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, "Failed to get supply '%s': %d\n", > > + consumers[i].supply, ret); > > No, this is not good - you get a nice quiet boot even if the regulator > does not appear which means people have no idea why the driver isn't > loading. That's not a good user experience, silent error handling is > the main problem I see people running into trying to get their systems > up and running these days. > > Really deferred probe is just fundamentally noisy since it's > intentionally tolerating errors like this and of course a lot of the > noise comes from the deferral messages the core prints. ok, I'll drop this one then From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering Date: Tue, 10 Mar 2015 13:33:23 +0100 Message-ID: <2019237.rjYDPBpg0A@phil> References: <1429128.MSqYm0qZ9p@phil> <9261130.uPvufuEFrr@phil> <20150310120750.GE28806@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150310120750.GE28806@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Brown Cc: Fabio Estevam , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Kumar Gala , dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , dri-devel@lists.freedesktop.org, Yakir Yang , Andy Yan , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org QW0gRGllbnN0YWcsIDEwLiBNw6RyeiAyMDE1LCAxMjowNzo1MCBzY2hyaWViIE1hcmsgQnJvd246 Cj4gT24gVHVlLCBNYXIgMTAsIDIwMTUgYXQgMTI6MjI6MDZBTSArMDEwMCwgSGVpa28gU3R1ZWJu ZXIgd3JvdGU6Cj4gPiBXaGVuIHtkZXZtX31yZWd1bGF0b3JfZ2V0IHJldHVybnMgLUVQUk9CRV9E RUZFUiB0aGUgZHJpdmVyIGluIHF1ZXN0aW9uCj4gPiB3aWxsCj4gPiB0cnkgcHJvYmluZyBhZ2Fp biBhdCBhIGxhdGVyIHRpbWUuIFNvIGRvbid0IHNwYW0gdGhlIGxvZyB3aXRoIGZhaWx1cmUKPiA+ IG1lc3NhZ2VzIGFzIHRoaXMgaXMgYW4gZXhwZWN0ZWQgcmVzdWx0IG9mIHByb2JlIG9yZGVyaW5n Lgo+ID4gCj4gPiAtCQkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0IHN1cHBseSAnJXMnOiAl ZFxuIiwKPiA+IC0JCQkJY29uc3VtZXJzW2ldLnN1cHBseSwgcmV0KTsKPiA+ICsJCQlpZiAocmV0 ICE9IC1FUFJPQkVfREVGRVIpCj4gPiArCQkJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGdldCBz dXBwbHkgJyVzJzogJWRcbiIsCj4gPiArCQkJCQljb25zdW1lcnNbaV0uc3VwcGx5LCByZXQpOwo+ IAo+IE5vLCB0aGlzIGlzIG5vdCBnb29kIC0geW91IGdldCBhIG5pY2UgcXVpZXQgYm9vdCBldmVu IGlmIHRoZSByZWd1bGF0b3IKPiBkb2VzIG5vdCBhcHBlYXIgd2hpY2ggbWVhbnMgcGVvcGxlIGhh dmUgbm8gaWRlYSB3aHkgdGhlIGRyaXZlciBpc24ndAo+IGxvYWRpbmcuICBUaGF0J3Mgbm90IGEg Z29vZCB1c2VyIGV4cGVyaWVuY2UsIHNpbGVudCBlcnJvciBoYW5kbGluZyBpcwo+IHRoZSBtYWlu IHByb2JsZW0gSSBzZWUgcGVvcGxlIHJ1bm5pbmcgaW50byB0cnlpbmcgdG8gZ2V0IHRoZWlyIHN5 c3RlbXMKPiB1cCBhbmQgcnVubmluZyB0aGVzZSBkYXlzLgo+IAo+IFJlYWxseSBkZWZlcnJlZCBw cm9iZSBpcyBqdXN0IGZ1bmRhbWVudGFsbHkgbm9pc3kgc2luY2UgaXQncwo+IGludGVudGlvbmFs bHkgdG9sZXJhdGluZyBlcnJvcnMgbGlrZSB0aGlzIGFuZCBvZiBjb3Vyc2UgYSBsb3Qgb2YgdGhl Cj4gbm9pc2UgY29tZXMgZnJvbSB0aGUgZGVmZXJyYWwgbWVzc2FnZXMgdGhlIGNvcmUgcHJpbnRz LgoKb2ssIEknbGwgZHJvcCB0aGlzIG9uZSB0aGVuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753003AbbCJMdc (ORCPT ); Tue, 10 Mar 2015 08:33:32 -0400 Received: from gloria.sntech.de ([95.129.55.99]:39753 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbbCJMda convert rfc822-to-8bit (ORCPT ); Tue, 10 Mar 2015 08:33:30 -0400 From: Heiko Stuebner To: Mark Brown Cc: Philipp Zabel , David Airlie , djkurtz@chromium.org, Yakir Yang , Fabio Estevam , dianders@chromium.org, Andy Yan , Mark Yao , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] regulator: don't emit errors in {devm_}regulator_bulk_get when defering Date: Tue, 10 Mar 2015 13:33:23 +0100 Message-ID: <2019237.rjYDPBpg0A@phil> User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20150310120750.GE28806@sirena.org.uk> References: <1429128.MSqYm0qZ9p@phil> <9261130.uPvufuEFrr@phil> <20150310120750.GE28806@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 10. März 2015, 12:07:50 schrieb Mark Brown: > On Tue, Mar 10, 2015 at 12:22:06AM +0100, Heiko Stuebner wrote: > > When {devm_}regulator_get returns -EPROBE_DEFER the driver in question > > will > > try probing again at a later time. So don't spam the log with failure > > messages as this is an expected result of probe ordering. > > > > - dev_err(dev, "Failed to get supply '%s': %d\n", > > - consumers[i].supply, ret); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, "Failed to get supply '%s': %d\n", > > + consumers[i].supply, ret); > > No, this is not good - you get a nice quiet boot even if the regulator > does not appear which means people have no idea why the driver isn't > loading. That's not a good user experience, silent error handling is > the main problem I see people running into trying to get their systems > up and running these days. > > Really deferred probe is just fundamentally noisy since it's > intentionally tolerating errors like this and of course a lot of the > noise comes from the deferral messages the core prints. ok, I'll drop this one then