From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
zhouyangchao <zhouyates@gmail.com>,
dev@dpdk.org
Subject: Re: [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash
Date: Fri, 09 Sep 2016 14:40:27 +0200 [thread overview]
Message-ID: <2019611.627KgLZ47A@xps13> (raw)
In-Reply-To: <05b14d74-b168-69b2-b107-124ee951dc27@intel.com>
2016-09-08 18:15, Ferruh Yigit:
> On 9/8/2016 5:44 PM, Stephen Hemminger wrote:
>
> ...
>
> > But then again the whole KNI driver fails completely when
> > running kernel style check.
> >
>
> Yes, it generates lots of warnings.
> I can fix them (excluding ethtool/*), that wouldn't take much time but
> how syntax only patches welcomed? Another concern is it trashes git blame.
You ask a question and give the answer ;)
I think it depends just on the balance of the pros/cons - to be evaluated.
next prev parent reply other threads:[~2016-09-09 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 2:46 [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash zhouyangchao
2016-09-08 16:44 ` Stephen Hemminger
2016-09-08 17:15 ` Ferruh Yigit
2016-09-09 12:40 ` Thomas Monjalon [this message]
2016-09-09 14:33 ` Mcnamara, John
2016-09-10 7:57 ` Thomas Monjalon
2016-09-08 17:07 ` Ferruh Yigit
2016-09-11 9:59 ` zhouyangchao
2016-09-13 13:13 ` Ferruh Yigit
2016-09-21 16:41 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-09-09 2:42 zhouyangchao
2016-09-08 16:47 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2019611.627KgLZ47A@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.