From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akhila YS <akhilayalmati@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: nxp,pca9564: convert to DT schema
Date: Thu, 9 Apr 2026 23:24:03 +0200 [thread overview]
Message-ID: <201979e6-43cc-4b99-8c5d-a956c4b09182@kernel.org> (raw)
In-Reply-To: <968dafc5-ba00-459e-b31a-b46d1f0de347@gmail.com>
On 09/04/2026 18:21, Akhila YS wrote:
>>>> +required:
>>>> + - compatible
>>>> + - reg
>>>> +
>>>> +additionalProperties: false
>>> And if you tested any DTS with this, you would see this cannot work.
>>> Look at other bindings - you miss ref to i2c-controller and
>>> unevaluatedProps. But the problem is that you are doing something which
>>> would never work, so I have doubts that you know what you are doing. One
>>> thing is to make a mistake, other thing is to post something can never
>>> work thus putting quite noticeable requirements on review.
>>
>> You are right, i missed referencing the common i2c controller schema and
>> did not handle unevaluated properties correctly,which makes binding invalid.
>
>
> There is no file named i2c-controller.yaml to take ref to this yaml. I
And `git grep` hallucinated?
> tried testing the yaml file with the dts in my local machine and its
> working as expected.
Hm, please share the DTS which worked. Are you sure that you are testing
I2C bus?
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-09 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:23 [PATCH] dt-bindings: i2c: nxp,pca9564: convert to DT schema Akhila YS
2026-04-09 8:26 ` Krzysztof Kozlowski
2026-04-09 15:02 ` Akhila YS
2026-04-09 16:21 ` Akhila YS
2026-04-09 21:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201979e6-43cc-4b99-8c5d-a956c4b09182@kernel.org \
--to=krzk@kernel.org \
--cc=akhilayalmati@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.