From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1689C2D0DD for ; Thu, 2 Jan 2020 08:47:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C255520866 for ; Thu, 2 Jan 2020 08:47:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="or7YBQdO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BCROBod9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C255520866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g3kAxntBvW42XIuHADiQVpib05wYlfiigkN5L2YdF+Y=; b=or7YBQdOgiOGlL wQ6CQ4naoIXOHjDeGJ5d6j/gI4Zkymo/8E3lY+c66BLay6BuSVjEpQsWBS21WNG1vksYlF6zXmDFd zxdlse19WMs3eyBC4F+JHat9TlyLKusDLOAjCWP99V2HpSAsTXA1lv/q39yhl3N87s2Hlc+ebfnQg Vb8Q+j1Nrp1R3l3jMfJ0gYImGXq6feIveEDi8wLS5jXUIjXYgJu4AFqt6/I902WzYxbn5JzchT+RB Oy3JgnYewlEowJcqtKhFkUp/j0CdEAL+P+UbUcVVE0P90aPO3X6ksAnA10STVNRkXuWWJ9niw+Lct vFh+0/ef0OBAr6sMSbUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imw81-00060a-RT; Thu, 02 Jan 2020 08:46:49 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imw7s-0005rY-Uf for linux-mediatek@lists.infradead.org; Thu, 02 Jan 2020 08:46:43 +0000 Received: by mail-wr1-x443.google.com with SMTP id g17so38484869wro.2 for ; Thu, 02 Jan 2020 00:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=BCROBod9j1yy6ajGa+uGcRO+X7a2oqm4ydiMzZwtcBr9thqmJoeDeB8vBmZ8hG0bas pRPAAfyxHm4lV8LwRhEx8jE7sUssEq5x7jyXSEWyaeVjbx6ftoR15mx1tVsz9zBJPr7c XKAtOPTAmr9rL8LaoS6MAbOmkxPCkurDhm33TvQuGx+C4zXTRjiHvzEgka/uTyIuQRQZ 4okHxCZsuUbIzRcY+45HcNOTYwAZ9GKO2r45tzSpjwejmSI5KqXeACQ7w61v6Pvkr5HN sAcbzQvhK41LfV8r0fmaOsCu/wE88cGOus0huQH7AwGLIQ5s63Vl1ClDEY5SRBvILAPv CzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=swHhttF9BMTmjkGnfFr6luOAnjOJvgHBg6LenMfYx603r0X8FDezwZhnTqKsN3N1CH cZ1IRl7Rj/zDvHOr5pnuCWFS4MObp1p8aMTlcK9XE5flBESRxfGza1gEeUGQm5qSzg+x z6OqyksZwMDiP/lCiBt1P1+UmMbXT9g6X+dULNJH3fHb8j98VYj3/pqZrTuX9ZMwrCgu /TKYvDdGDR8CGMzklqSzR9S79pNBAhM9NouTpG6Y4KoPgvzM55AwPnBydwceNPWpQ49L Pg1R4SKwknSfqJj42e8kwnKH+uT2lfhGnNai/9/EM+13P7iRHYGsQgBGgubrsyi8rpxK WpNg== X-Gm-Message-State: APjAAAUtyXSenlh24o+H+IYQL2rC8QdhZCLO9wFALrPrg6JveCy3BW88 Qbdjk0pY8PVHiHtlwGYlIF+udw== X-Google-Smtp-Source: APXvYqwSDKoiB5ra6drQsoyYVfGcpU9ytlL7NbMzlMJbbOVavFr5G0msLQo7wTmzibB98v+znbhMpQ== X-Received: by 2002:a5d:68c5:: with SMTP id p5mr83053200wrw.193.1577954798497; Thu, 02 Jan 2020 00:46:38 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id g2sm54686011wrw.76.2020.01.02.00.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 00:46:37 -0800 (PST) Date: Thu, 2 Jan 2020 08:46:50 +0000 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v6] mfd: mt6360: add pmic mt6360 driver Message-ID: <20200102084650.GA22390@dell> References: <20191225014148.19082-1-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191225014148.19082-1-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200102_004641_184567_F3ECE309 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org, cy_huang@richtek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNSBEZWMgMjAxOSwgR2VuZSBDaGVuIHdyb3RlOgoKPiBGcm9tOiBHZW5lIENoZW4g PGdlbmVfY2hlbkByaWNodGVrLmNvbT4KPiAKPiBBZGQgbWZkIGRyaXZlciBmb3IgbXQ2MzYwIHBt aWMgY2hpcCBpbmNsdWRlCj4gQmF0dGVyeSBDaGFyZ2VyL1VTQl9QRC9GbGFzaCBMRUQvUkdCIExF RC9MRE8vQnVjawo+IAo+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0 ZWsuY29tCj4gLS0tCj4gIGRyaXZlcnMvbWZkL0tjb25maWcgICAgICAgICAgICAgICAgfCAgMTIg Kwo+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgICAxICsKPiAgZHJpdmVy cy9tZmQvbXQ2MzYwLWNvcmUuYyAgICAgICAgICB8IDQyNiArKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oIHwgMjE3ICsrKysr KysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9tdDYzNjAuaCAgICAgICAgIHwgIDMyICsr Kwo+ICA1IGZpbGVzIGNoYW5nZWQsIDY4OCBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNs dWRlL2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNs dWRlL2xpbnV4L21mZC9tdDYzNjAuaAo+IAo+IGNoYW5nZWxvZ3MgYmV0d2VlbiB2MSAmIHYyCj4g LSBpbmNsdWRlIG1pc3NpbmcgaGVhZGVyIGZpbGUKPiAKPiBjaGFuZ2Vsb2dzIGJldHdlZW4gdjIg JiB2Mwo+IC0gYWRkIGNoYW5nZWxvZ3MKPiAKPiBjaGFuZ2Vsb2dzIGJldHdlZW4gdjMgJiB2NAo+ IC0gZml4IEtjb25maWcgZGVzY3JpcHRpb24KPiAtIHJlcGxhY2UgbXQ2MzYwX3BtdV9pbmZvIHdp dGggbXQ2MzYwX3BtdV9kYXRhCj4gLSByZXBsYWNlIHByb2JlIHdpdGggcHJvYmVfbmV3Cj4gLSBy ZW1vdmUgdW5uZWNlc3NhcnkgaXJxX2NoaXAgdmFyaWFibGUKPiAtIHJlbW92ZSBhbm5vdGF0aW9u Cj4gLSByZXBsYWNlIE1UNjM2MF9NRkRfQ0VMTCB3aXRoIE9GX01GRF9DRUxMCj4gCj4gY2hhbmdl bG9ncyBiZXR3ZWVuIHY0ICYgdjUKPiAtIHJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJzZSBkdCBmdW5j dGlvbgo+IC0gdXNlIGRldm1faTJjX25ld19kdW1teV9kZXZpY2UKPiAtIGFkZCBiYXNlLWNvbW1p dCBtZXNzYWdlCj4gCj4gY2hhbmdlbG9ncyBiZXR3ZWVuIHY1ICYgdjYKPiAtIHJldmlldyByZXR1 cm4gdmFsdWUKPiAtIHJlbW92ZSBpMmMgaWRfdGFibGUKPiAtIHVzZSBHUEwgbGljZW5zZSB2Mgo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmlnIGIvZHJpdmVycy9tZmQvS2NvbmZp Zwo+IGluZGV4IDQyMDkwMDg1MjE2Ni4uZTZkZjkxZDU1NDA1IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvbWZkL0tjb25maWcKPiArKysgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gQEAgLTg1Niw2ICs4 NTYsMTggQEAgY29uZmlnIE1GRF9NQVg4OTk4Cj4gIAkgIGFkZGl0aW9uYWwgZHJpdmVycyBtdXN0 IGJlIGVuYWJsZWQgaW4gb3JkZXIgdG8gdXNlIHRoZSBmdW5jdGlvbmFsaXR5Cj4gIAkgIG9mIHRo ZSBkZXZpY2UuCj4gIAo+ICtjb25maWcgTUZEX01UNjM2MAo+ICsJdHJpc3RhdGUgIk1lZGlhdGVr IE1UNjM2MCBTdWJQTUlDIgo+ICsJc2VsZWN0IE1GRF9DT1JFCj4gKwlzZWxlY3QgUkVHTUFQX0ky Qwo+ICsJc2VsZWN0IFJFR01BUF9JUlEKPiArCWRlcGVuZHMgb24gSTJDCj4gKwloZWxwCj4gKwkg IFNheSBZIGhlcmUgdG8gZW5hYmxlIE1UNjM2MCBQTVUvUE1JQy9MRE8gZnVuY3Rpb25hbCBzdXBw b3J0Lgo+ICsJICBQTVUgcGFydCBpbmNsdWRlcyBDaGFyZ2VyLCBGbGFzaGxpZ2h0LCBSR0IgTEVE Cj4gKwkgIFBNSUMgcGFydCBpbmNsdWRlcyAyLWNoYW5uZWwgQlVDS3MgYW5kIDItY2hhbm5lbCBM RE9zCj4gKwkgIExETyBwYXJ0IGluY2x1ZGVzIDQtY2hhbm5lbCBMRE9zCj4gKwo+ICBjb25maWcg TUZEX01UNjM5Nwo+ICAJdHJpc3RhdGUgIk1lZGlhVGVrIE1UNjM5NyBQTUlDIFN1cHBvcnQiCj4g IAlzZWxlY3QgTUZEX0NPUkUKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvTWFrZWZpbGUgYi9k cml2ZXJzL21mZC9NYWtlZmlsZQo+IGluZGV4IGFlZDk5ZjA4NzM5Zi4uZjVmODBkNzVlZTUzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9tZmQvTWFr ZWZpbGUKPiBAQCAtMjM3LDYgKzIzNyw3IEBAIG9iai0kKENPTkZJR19JTlRFTF9TT0NfUE1JQykJ Kz0gaW50ZWwtc29jLXBtaWMubwo+ICBvYmotJChDT05GSUdfSU5URUxfU09DX1BNSUNfQlhUV0Mp CSs9IGludGVsX3NvY19wbWljX2J4dHdjLm8KPiAgb2JqLSQoQ09ORklHX0lOVEVMX1NPQ19QTUlD X0NIVFdDKQkrPSBpbnRlbF9zb2NfcG1pY19jaHR3Yy5vCj4gIG9iai0kKENPTkZJR19JTlRFTF9T T0NfUE1JQ19DSFREQ19USSkJKz0gaW50ZWxfc29jX3BtaWNfY2h0ZGNfdGkubwo+ICtvYmotJChD T05GSUdfTUZEX01UNjM2MCkJKz0gbXQ2MzYwLWNvcmUubwo+ICBtdDYzOTctb2Jqcwk6PSBtdDYz OTctY29yZS5vIG10NjM5Ny1pcnEubwo+ICBvYmotJChDT05GSUdfTUZEX01UNjM5NykJKz0gbXQ2 Mzk3Lm8KPiAgb2JqLSQoQ09ORklHX0lOVEVMX1NPQ19QTUlDX01SRkxEKQkrPSBpbnRlbF9zb2Nf cG1pY19tcmZsZC5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL210NjM2MC1jb3JlLmMgYi9k cml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmY2ZDQzYjZkYWQ0ZQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJz L21mZC9tdDYzNjAtY29yZS5jCj4gQEAgLTAsMCArMSw0MjYgQEAKPiArLy8gU1BEWC1MaWNlbnNl LUlkZW50aWZpZXI6IEdQTC0yLjAKPiArLyoKPiArICogQ29weXJpZ2h0IChjKSAyMDE5IE1lZGlh VGVrIEluYy4KCk5vIGF1dGhvcj8KCj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2kyYy5o Pgo+ICsjaW5jbHVkZSA8bGludXgvaW5pdC5oPgo+ICsjaW5jbHVkZSA8bGludXgva2VybmVsLmg+ Cj4gKyNpbmNsdWRlIDxsaW51eC9tZmQvY29yZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxl Lmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9vZl9pcnEuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mX3Bs YXRmb3JtLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+Cj4gKwo+ICsjaW5jbHVkZSA8 bGludXgvbWZkL210NjM2MC5oPgo+ICsjaW5jbHVkZSA8bGludXgvbWZkL210NjM2MC1wcml2YXRl Lmg+CgpbLi4uXQoKPiArI2RlZmluZSBNVDYzNjBfUkVHTUFQX0lSUV9SRUcoX2lycV9ldnQpCQlc Cj4gKwlSRUdNQVBfSVJRX1JFRyhfaXJxX2V2dCwgKF9pcnFfZXZ0KSAvIDgsIEJJVCgoX2lycV9l dnQpICUgOCkpCgpObyBuZWVkIHRvIHJvbGwgeW91ciBvd24gbWFjcm9zIGZvciB0aGlzLiAgSSB0 aGluawpSRUdNQVBfSVJRX1JFR19MSU5FKCkgaXMgd2hhdCB5b3UncmUgbG9va2luZyBmb3IuCgo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9pcnEgbXQ2MzYwX3BtdV9pcnFzW10gPSAgewoK CVJFR01BUF9JUlFfUkVHX0xJTkUoTVQ2MzYwX0NIR19UUkVHX0VWVCwgOCksCgouLi4gZXRjLgoK PiArCU1UNjM2MF9SRUdNQVBfSVJRX1JFRyhNVDYzNjBfQ0hHX1RSRUdfRVZUKSwKPiArCU1UNjM2 MF9SRUdNQVBfSVJRX1JFRyhNVDYzNjBfQ0hHX0FJQ1JfRVZUKSwKClsuLi5dCgo+ICsJTVQ2MzYw X1JFR01BUF9JUlFfUkVHKE1UNjM2MF9MRE83X1BHQl9FVlQpLAo+ICt9OwoKWy4uLl0KCj4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWZkL210NjM2MC1wcml2YXRlLmggYi9pbmNsdWRlL2xp bnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmQ1NDI2NTJmNGRlMAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRl L2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCgpBcyB0aGVyZSBhcmUgb25seSBhcHByb3ByaWF0 ZWx5IG5hbWVzcGFjZWQgbWFjcm9zIGluIGhlcmUsIEkgd291bGQKbW92ZSB0aGVtIHRvIHRoZSBu b3JtYWwgaGVhZGVyIGZpbGUgYW5kIGRpc3Bvc2Ugb2YgdGhpcyBvbmUuCgo+IEBAIC0wLDAgKzEs MjE3IEBACj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wICovCj4gKy8qCj4g KyAqIENvcHlyaWdodCAoYykgMjAxOSBNZWRpYVRlayBJbmMuCj4gKyAqLwo+ICsKPiArI2lmbmRl ZiBfX01UNjM2MF9QUklWQVRFX0hfXwo+ICsjZGVmaW5lIF9fTVQ2MzYwX1BSSVZBVEVfSF9fCj4g Kwo+ICsvKiBQTVUgcmVnaXN0ZXIgZGVmaW5pbml0aW9uICovCj4gKyNkZWZpbmUgTVQ2MzYwX1BN VV9ERVZfSU5GTwkJCSgweDAwKQo+ICsjZGVmaW5lIE1UNjM2MF9QTVVfQ09SRV9DVFJMMQkJCSgw eDAxKQoKWy4uLl0KCj4gKyNkZWZpbmUgTVQ2MzYwX1BNVV9MRE9fTUFTSzIJCQkoMHhGRikKPiAr I2RlZmluZSBNVDYzNjBfUE1VX01BWFJFRwkJCShNVDYzNjBfUE1VX0xET19NQVNLMikKPiArCj4g Ky8qIE1UNjM2MF9QTVVfSVJRX1NFVCAqLwo+ICsjZGVmaW5lIE1UNjM2MF9QTVVfSVJRX1JFR05V TQkoTVQ2MzYwX1BNVV9MRE9fSVJRMiAtIE1UNjM2MF9QTVVfQ0hHX0lSUTEgKyAxKQo+ICsjZGVm aW5lIE1UNjM2MF9JUlFfUkVUUklHCUJJVCgyKQo+ICsKPiArI2RlZmluZSBDSElQX1ZFTl9NQVNL CQkJCSgweEYwKQo+ICsjZGVmaW5lIENISVBfVkVOX01UNjM2MAkJCQkoMHg1MCkKPiArI2RlZmlu ZSBDSElQX1JFVl9NQVNLCQkJCSgweDBGKQo+ICsKPiArI2VuZGlmIC8qIF9fTVQ2MzYwX1BSSVZB VEVfSF9fICovCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNo bmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNv Q3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGlu ZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8055C2D0DD for ; Thu, 2 Jan 2020 08:46:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AB4F20866 for ; Thu, 2 Jan 2020 08:46:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NOxT+oal"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BCROBod9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AB4F20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QPSjCv0UhT1+ZmDA6pxQ8zOcOFIYJ1/G5dwm2jIpkBw=; b=NOxT+oalXjOZkb 36JOd7FLG/pC7JnpkomRBjNK4wYRhlcbTRJRLLJR2JoRbJenRGSgjjaClfILRiAayThDFlnhHDfB/ uXI0q/v0AoDaugeUPIATiyKj4lq7HNS9y1kIfk4A7oJaTQ9nkyTajz4xZvZN2m0S0SMe67U8omlE/ S8tTz/fwMFQ/iCrTBrDqHsvZVIFkKn3jMLwmdtOTihhpdecpX6H2UKMxPn7qUkxP8YI0Zaw16/zxZ PBYZmY46NdCznJNEUCH58sNx9jiOkXyyPuiSZKevs/Bfgdv0pvZvVHXlAhaymp8latFnBCaO2sfKy 1qPSB1bq5XigvGfS76+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1imw7w-0005so-QR; Thu, 02 Jan 2020 08:46:44 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1imw7s-0005rX-Up for linux-arm-kernel@lists.infradead.org; Thu, 02 Jan 2020 08:46:43 +0000 Received: by mail-wr1-x443.google.com with SMTP id j42so38461771wrj.12 for ; Thu, 02 Jan 2020 00:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=BCROBod9j1yy6ajGa+uGcRO+X7a2oqm4ydiMzZwtcBr9thqmJoeDeB8vBmZ8hG0bas pRPAAfyxHm4lV8LwRhEx8jE7sUssEq5x7jyXSEWyaeVjbx6ftoR15mx1tVsz9zBJPr7c XKAtOPTAmr9rL8LaoS6MAbOmkxPCkurDhm33TvQuGx+C4zXTRjiHvzEgka/uTyIuQRQZ 4okHxCZsuUbIzRcY+45HcNOTYwAZ9GKO2r45tzSpjwejmSI5KqXeACQ7w61v6Pvkr5HN sAcbzQvhK41LfV8r0fmaOsCu/wE88cGOus0huQH7AwGLIQ5s63Vl1ClDEY5SRBvILAPv CzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=hPP5pCwLMMJFtyArrO8AjUWjqkGhQtladLF4/d7uWqKAfDxFdcGQyQnOmbptcrUGOD hC49thUswjnOb3Cdy+qxeZDEuCS5+UPztVemel8bsl5LTNxeKPx7IVCuMHCRjpm8D43K kkxP0tKVPnqnB15dLOhLLVsDNX1+zBMcfQW8cKMkf1POmGgweZsduzMJGhAIcwnMYkiA o9FUSJb/RRphdHQf/hPXCToYSmDfW0YAsrQ4kf7mBuUHC5QE5CALy8LgISf15uNy2N+a SdgFTh9DsxI+HvlUZJTozkhc2QhyjB5p65de86mPvh4gQDwv5uNJl7rNi5b7F478x7nY xrBw== X-Gm-Message-State: APjAAAVO6SVkIs55S1Fn2F51ijwcOLv6gtWRmSQShn3DrDfMs3V/IKGg gMkIdqO9E0P2m0MZdsmiB+eAKuBmtG4= X-Google-Smtp-Source: APXvYqwSDKoiB5ra6drQsoyYVfGcpU9ytlL7NbMzlMJbbOVavFr5G0msLQo7wTmzibB98v+znbhMpQ== X-Received: by 2002:a5d:68c5:: with SMTP id p5mr83053200wrw.193.1577954798497; Thu, 02 Jan 2020 00:46:38 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id g2sm54686011wrw.76.2020.01.02.00.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 00:46:37 -0800 (PST) Date: Thu, 2 Jan 2020 08:46:50 +0000 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v6] mfd: mt6360: add pmic mt6360 driver Message-ID: <20200102084650.GA22390@dell> References: <20191225014148.19082-1-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191225014148.19082-1-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200102_004641_184391_9C1BA056 X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org, cy_huang@richtek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, Wilma.Wu@mediatek.com, linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyNSBEZWMgMjAxOSwgR2VuZSBDaGVuIHdyb3RlOgoKPiBGcm9tOiBHZW5lIENoZW4g PGdlbmVfY2hlbkByaWNodGVrLmNvbT4KPiAKPiBBZGQgbWZkIGRyaXZlciBmb3IgbXQ2MzYwIHBt aWMgY2hpcCBpbmNsdWRlCj4gQmF0dGVyeSBDaGFyZ2VyL1VTQl9QRC9GbGFzaCBMRUQvUkdCIExF RC9MRE8vQnVjawo+IAo+IFNpZ25lZC1vZmYtYnk6IEdlbmUgQ2hlbiA8Z2VuZV9jaGVuQHJpY2h0 ZWsuY29tCj4gLS0tCj4gIGRyaXZlcnMvbWZkL0tjb25maWcgICAgICAgICAgICAgICAgfCAgMTIg Kwo+ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgICAgICAgICAgIHwgICAxICsKPiAgZHJpdmVy cy9tZmQvbXQ2MzYwLWNvcmUuYyAgICAgICAgICB8IDQyNiArKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oIHwgMjE3ICsrKysr KysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4L21mZC9tdDYzNjAuaCAgICAgICAgIHwgIDMyICsr Kwo+ICA1IGZpbGVzIGNoYW5nZWQsIDY4OCBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNs dWRlL2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNs dWRlL2xpbnV4L21mZC9tdDYzNjAuaAo+IAo+IGNoYW5nZWxvZ3MgYmV0d2VlbiB2MSAmIHYyCj4g LSBpbmNsdWRlIG1pc3NpbmcgaGVhZGVyIGZpbGUKPiAKPiBjaGFuZ2Vsb2dzIGJldHdlZW4gdjIg JiB2Mwo+IC0gYWRkIGNoYW5nZWxvZ3MKPiAKPiBjaGFuZ2Vsb2dzIGJldHdlZW4gdjMgJiB2NAo+ IC0gZml4IEtjb25maWcgZGVzY3JpcHRpb24KPiAtIHJlcGxhY2UgbXQ2MzYwX3BtdV9pbmZvIHdp dGggbXQ2MzYwX3BtdV9kYXRhCj4gLSByZXBsYWNlIHByb2JlIHdpdGggcHJvYmVfbmV3Cj4gLSBy ZW1vdmUgdW5uZWNlc3NhcnkgaXJxX2NoaXAgdmFyaWFibGUKPiAtIHJlbW92ZSBhbm5vdGF0aW9u Cj4gLSByZXBsYWNlIE1UNjM2MF9NRkRfQ0VMTCB3aXRoIE9GX01GRF9DRUxMCj4gCj4gY2hhbmdl bG9ncyBiZXR3ZWVuIHY0ICYgdjUKPiAtIHJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJzZSBkdCBmdW5j dGlvbgo+IC0gdXNlIGRldm1faTJjX25ld19kdW1teV9kZXZpY2UKPiAtIGFkZCBiYXNlLWNvbW1p dCBtZXNzYWdlCj4gCj4gY2hhbmdlbG9ncyBiZXR3ZWVuIHY1ICYgdjYKPiAtIHJldmlldyByZXR1 cm4gdmFsdWUKPiAtIHJlbW92ZSBpMmMgaWRfdGFibGUKPiAtIHVzZSBHUEwgbGljZW5zZSB2Mgo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC9LY29uZmlnIGIvZHJpdmVycy9tZmQvS2NvbmZp Zwo+IGluZGV4IDQyMDkwMDg1MjE2Ni4uZTZkZjkxZDU1NDA1IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvbWZkL0tjb25maWcKPiArKysgYi9kcml2ZXJzL21mZC9LY29uZmlnCj4gQEAgLTg1Niw2ICs4 NTYsMTggQEAgY29uZmlnIE1GRF9NQVg4OTk4Cj4gIAkgIGFkZGl0aW9uYWwgZHJpdmVycyBtdXN0 IGJlIGVuYWJsZWQgaW4gb3JkZXIgdG8gdXNlIHRoZSBmdW5jdGlvbmFsaXR5Cj4gIAkgIG9mIHRo ZSBkZXZpY2UuCj4gIAo+ICtjb25maWcgTUZEX01UNjM2MAo+ICsJdHJpc3RhdGUgIk1lZGlhdGVr IE1UNjM2MCBTdWJQTUlDIgo+ICsJc2VsZWN0IE1GRF9DT1JFCj4gKwlzZWxlY3QgUkVHTUFQX0ky Qwo+ICsJc2VsZWN0IFJFR01BUF9JUlEKPiArCWRlcGVuZHMgb24gSTJDCj4gKwloZWxwCj4gKwkg IFNheSBZIGhlcmUgdG8gZW5hYmxlIE1UNjM2MCBQTVUvUE1JQy9MRE8gZnVuY3Rpb25hbCBzdXBw b3J0Lgo+ICsJICBQTVUgcGFydCBpbmNsdWRlcyBDaGFyZ2VyLCBGbGFzaGxpZ2h0LCBSR0IgTEVE Cj4gKwkgIFBNSUMgcGFydCBpbmNsdWRlcyAyLWNoYW5uZWwgQlVDS3MgYW5kIDItY2hhbm5lbCBM RE9zCj4gKwkgIExETyBwYXJ0IGluY2x1ZGVzIDQtY2hhbm5lbCBMRE9zCj4gKwo+ICBjb25maWcg TUZEX01UNjM5Nwo+ICAJdHJpc3RhdGUgIk1lZGlhVGVrIE1UNjM5NyBQTUlDIFN1cHBvcnQiCj4g IAlzZWxlY3QgTUZEX0NPUkUKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvTWFrZWZpbGUgYi9k cml2ZXJzL21mZC9NYWtlZmlsZQo+IGluZGV4IGFlZDk5ZjA4NzM5Zi4uZjVmODBkNzVlZTUzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9tZmQvTWFr ZWZpbGUKPiBAQCAtMjM3LDYgKzIzNyw3IEBAIG9iai0kKENPTkZJR19JTlRFTF9TT0NfUE1JQykJ Kz0gaW50ZWwtc29jLXBtaWMubwo+ICBvYmotJChDT05GSUdfSU5URUxfU09DX1BNSUNfQlhUV0Mp CSs9IGludGVsX3NvY19wbWljX2J4dHdjLm8KPiAgb2JqLSQoQ09ORklHX0lOVEVMX1NPQ19QTUlD X0NIVFdDKQkrPSBpbnRlbF9zb2NfcG1pY19jaHR3Yy5vCj4gIG9iai0kKENPTkZJR19JTlRFTF9T T0NfUE1JQ19DSFREQ19USSkJKz0gaW50ZWxfc29jX3BtaWNfY2h0ZGNfdGkubwo+ICtvYmotJChD T05GSUdfTUZEX01UNjM2MCkJKz0gbXQ2MzYwLWNvcmUubwo+ICBtdDYzOTctb2Jqcwk6PSBtdDYz OTctY29yZS5vIG10NjM5Ny1pcnEubwo+ICBvYmotJChDT05GSUdfTUZEX01UNjM5NykJKz0gbXQ2 Mzk3Lm8KPiAgb2JqLSQoQ09ORklHX0lOVEVMX1NPQ19QTUlDX01SRkxEKQkrPSBpbnRlbF9zb2Nf cG1pY19tcmZsZC5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL210NjM2MC1jb3JlLmMgYi9k cml2ZXJzL21mZC9tdDYzNjAtY29yZS5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmY2ZDQzYjZkYWQ0ZQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJz L21mZC9tdDYzNjAtY29yZS5jCj4gQEAgLTAsMCArMSw0MjYgQEAKPiArLy8gU1BEWC1MaWNlbnNl LUlkZW50aWZpZXI6IEdQTC0yLjAKPiArLyoKPiArICogQ29weXJpZ2h0IChjKSAyMDE5IE1lZGlh VGVrIEluYy4KCk5vIGF1dGhvcj8KCj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2kyYy5o Pgo+ICsjaW5jbHVkZSA8bGludXgvaW5pdC5oPgo+ICsjaW5jbHVkZSA8bGludXgva2VybmVsLmg+ Cj4gKyNpbmNsdWRlIDxsaW51eC9tZmQvY29yZS5oPgo+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxl Lmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9vZl9pcnEuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mX3Bs YXRmb3JtLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+Cj4gKwo+ICsjaW5jbHVkZSA8 bGludXgvbWZkL210NjM2MC5oPgo+ICsjaW5jbHVkZSA8bGludXgvbWZkL210NjM2MC1wcml2YXRl Lmg+CgpbLi4uXQoKPiArI2RlZmluZSBNVDYzNjBfUkVHTUFQX0lSUV9SRUcoX2lycV9ldnQpCQlc Cj4gKwlSRUdNQVBfSVJRX1JFRyhfaXJxX2V2dCwgKF9pcnFfZXZ0KSAvIDgsIEJJVCgoX2lycV9l dnQpICUgOCkpCgpObyBuZWVkIHRvIHJvbGwgeW91ciBvd24gbWFjcm9zIGZvciB0aGlzLiAgSSB0 aGluawpSRUdNQVBfSVJRX1JFR19MSU5FKCkgaXMgd2hhdCB5b3UncmUgbG9va2luZyBmb3IuCgo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9pcnEgbXQ2MzYwX3BtdV9pcnFzW10gPSAgewoK CVJFR01BUF9JUlFfUkVHX0xJTkUoTVQ2MzYwX0NIR19UUkVHX0VWVCwgOCksCgouLi4gZXRjLgoK PiArCU1UNjM2MF9SRUdNQVBfSVJRX1JFRyhNVDYzNjBfQ0hHX1RSRUdfRVZUKSwKPiArCU1UNjM2 MF9SRUdNQVBfSVJRX1JFRyhNVDYzNjBfQ0hHX0FJQ1JfRVZUKSwKClsuLi5dCgo+ICsJTVQ2MzYw X1JFR01BUF9JUlFfUkVHKE1UNjM2MF9MRE83X1BHQl9FVlQpLAo+ICt9OwoKWy4uLl0KCj4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWZkL210NjM2MC1wcml2YXRlLmggYi9pbmNsdWRlL2xp bnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmQ1NDI2NTJmNGRlMAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRl L2xpbnV4L21mZC9tdDYzNjAtcHJpdmF0ZS5oCgpBcyB0aGVyZSBhcmUgb25seSBhcHByb3ByaWF0 ZWx5IG5hbWVzcGFjZWQgbWFjcm9zIGluIGhlcmUsIEkgd291bGQKbW92ZSB0aGVtIHRvIHRoZSBu b3JtYWwgaGVhZGVyIGZpbGUgYW5kIGRpc3Bvc2Ugb2YgdGhpcyBvbmUuCgo+IEBAIC0wLDAgKzEs MjE3IEBACj4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wICovCj4gKy8qCj4g KyAqIENvcHlyaWdodCAoYykgMjAxOSBNZWRpYVRlayBJbmMuCj4gKyAqLwo+ICsKPiArI2lmbmRl ZiBfX01UNjM2MF9QUklWQVRFX0hfXwo+ICsjZGVmaW5lIF9fTVQ2MzYwX1BSSVZBVEVfSF9fCj4g Kwo+ICsvKiBQTVUgcmVnaXN0ZXIgZGVmaW5pbml0aW9uICovCj4gKyNkZWZpbmUgTVQ2MzYwX1BN VV9ERVZfSU5GTwkJCSgweDAwKQo+ICsjZGVmaW5lIE1UNjM2MF9QTVVfQ09SRV9DVFJMMQkJCSgw eDAxKQoKWy4uLl0KCj4gKyNkZWZpbmUgTVQ2MzYwX1BNVV9MRE9fTUFTSzIJCQkoMHhGRikKPiAr I2RlZmluZSBNVDYzNjBfUE1VX01BWFJFRwkJCShNVDYzNjBfUE1VX0xET19NQVNLMikKPiArCj4g Ky8qIE1UNjM2MF9QTVVfSVJRX1NFVCAqLwo+ICsjZGVmaW5lIE1UNjM2MF9QTVVfSVJRX1JFR05V TQkoTVQ2MzYwX1BNVV9MRE9fSVJRMiAtIE1UNjM2MF9QTVVfQ0hHX0lSUTEgKyAxKQo+ICsjZGVm aW5lIE1UNjM2MF9JUlFfUkVUUklHCUJJVCgyKQo+ICsKPiArI2RlZmluZSBDSElQX1ZFTl9NQVNL CQkJCSgweEYwKQo+ICsjZGVmaW5lIENISVBfVkVOX01UNjM2MAkJCQkoMHg1MCkKPiArI2RlZmlu ZSBDSElQX1JFVl9NQVNLCQkJCSgweDBGKQo+ICsKPiArI2VuZGlmIC8qIF9fTVQ2MzYwX1BSSVZB VEVfSF9fICovCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNo bmljYWwgTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNv Q3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC9AC2D0DD for ; Thu, 2 Jan 2020 08:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF27020866 for ; Thu, 2 Jan 2020 08:46:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BCROBod9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbgABIql (ORCPT ); Thu, 2 Jan 2020 03:46:41 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46750 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727756AbgABIqk (ORCPT ); Thu, 2 Jan 2020 03:46:40 -0500 Received: by mail-wr1-f66.google.com with SMTP id z7so38428706wrl.13 for ; Thu, 02 Jan 2020 00:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=BCROBod9j1yy6ajGa+uGcRO+X7a2oqm4ydiMzZwtcBr9thqmJoeDeB8vBmZ8hG0bas pRPAAfyxHm4lV8LwRhEx8jE7sUssEq5x7jyXSEWyaeVjbx6ftoR15mx1tVsz9zBJPr7c XKAtOPTAmr9rL8LaoS6MAbOmkxPCkurDhm33TvQuGx+C4zXTRjiHvzEgka/uTyIuQRQZ 4okHxCZsuUbIzRcY+45HcNOTYwAZ9GKO2r45tzSpjwejmSI5KqXeACQ7w61v6Pvkr5HN sAcbzQvhK41LfV8r0fmaOsCu/wE88cGOus0huQH7AwGLIQ5s63Vl1ClDEY5SRBvILAPv CzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=J4BV4xVxmbRJ/r05rBs0QYCjejbH9ewz1c2yLbanQBw=; b=b/2uJVVszw6Kq0TAeRgOmP0pidpgRsTXcwSAPbyaL5KxTthHXck9WFUJr2aqPGglNV bvEp38Jcw0ybk1E1TwaKb47YpbLmn8V0WwKh6FJjhf59ThAUVz9Y6hgmqhC4I8EGaEJ1 gqsFNKacUPJlJbhAnCtZyDVWeMu16CpSoKOJX86uq0y4P5hbB/iSXeMlI2UyLXrfAx55 NnqZShW3+guloinqzu6uViEW3f/AbRKnMep5bbPBKgWh0oZmtnhuGEfmMppET8G139+M sg4IWq2igyHR1n4JGNZEV8h/Xk/Ft+Cz5GwHbAZNjSuxuip+Ph0VhNRb/peWNALeOv+Z Pgwg== X-Gm-Message-State: APjAAAW/9FcGWn4fro1ISi02MPd+yKhaqMBB1JZs3kReTPn7nGG/ubC/ /UApEmxInwSDBEBC76YI3huLGw== X-Google-Smtp-Source: APXvYqwSDKoiB5ra6drQsoyYVfGcpU9ytlL7NbMzlMJbbOVavFr5G0msLQo7wTmzibB98v+znbhMpQ== X-Received: by 2002:a5d:68c5:: with SMTP id p5mr83053200wrw.193.1577954798497; Thu, 02 Jan 2020 00:46:38 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id g2sm54686011wrw.76.2020.01.02.00.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 00:46:37 -0800 (PST) Date: Thu, 2 Jan 2020 08:46:50 +0000 From: Lee Jones To: Gene Chen Cc: matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com Subject: Re: [PATCH v6] mfd: mt6360: add pmic mt6360 driver Message-ID: <20200102084650.GA22390@dell> References: <20191225014148.19082-1-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191225014148.19082-1-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Dec 2019, Gene Chen wrote: > From: Gene Chen > > Add mfd driver for mt6360 pmic chip include > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck > > Signed-off-by: Gene Chen --- > drivers/mfd/Kconfig | 12 + > drivers/mfd/Makefile | 1 + > drivers/mfd/mt6360-core.c | 426 +++++++++++++++++++++++++++++ > include/linux/mfd/mt6360-private.h | 217 +++++++++++++++ > include/linux/mfd/mt6360.h | 32 +++ > 5 files changed, 688 insertions(+) > create mode 100644 drivers/mfd/mt6360-core.c > create mode 100644 include/linux/mfd/mt6360-private.h > create mode 100644 include/linux/mfd/mt6360.h > > changelogs between v1 & v2 > - include missing header file > > changelogs between v2 & v3 > - add changelogs > > changelogs between v3 & v4 > - fix Kconfig description > - replace mt6360_pmu_info with mt6360_pmu_data > - replace probe with probe_new > - remove unnecessary irq_chip variable > - remove annotation > - replace MT6360_MFD_CELL with OF_MFD_CELL > > changelogs between v4 & v5 > - remove unnecessary parse dt function > - use devm_i2c_new_dummy_device > - add base-commit message > > changelogs between v5 & v6 > - review return value > - remove i2c id_table > - use GPL license v2 > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 420900852166..e6df91d55405 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -856,6 +856,18 @@ config MFD_MAX8998 > additional drivers must be enabled in order to use the functionality > of the device. > > +config MFD_MT6360 > + tristate "Mediatek MT6360 SubPMIC" > + select MFD_CORE > + select REGMAP_I2C > + select REGMAP_IRQ > + depends on I2C > + help > + Say Y here to enable MT6360 PMU/PMIC/LDO functional support. > + PMU part includes Charger, Flashlight, RGB LED > + PMIC part includes 2-channel BUCKs and 2-channel LDOs > + LDO part includes 4-channel LDOs > + > config MFD_MT6397 > tristate "MediaTek MT6397 PMIC Support" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index aed99f08739f..f5f80d75ee53 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -237,6 +237,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o > obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) += intel_soc_pmic_chtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) += intel_soc_pmic_chtdc_ti.o > +obj-$(CONFIG_MFD_MT6360) += mt6360-core.o > mt6397-objs := mt6397-core.o mt6397-irq.o > obj-$(CONFIG_MFD_MT6397) += mt6397.o > obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) += intel_soc_pmic_mrfld.o > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c > new file mode 100644 > index 000000000000..f6d43b6dad4e > --- /dev/null > +++ b/drivers/mfd/mt6360-core.c > @@ -0,0 +1,426 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019 MediaTek Inc. No author? > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include [...] > +#define MT6360_REGMAP_IRQ_REG(_irq_evt) \ > + REGMAP_IRQ_REG(_irq_evt, (_irq_evt) / 8, BIT((_irq_evt) % 8)) No need to roll your own macros for this. I think REGMAP_IRQ_REG_LINE() is what you're looking for. > +static const struct regmap_irq mt6360_pmu_irqs[] = { REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8), ... etc. > + MT6360_REGMAP_IRQ_REG(MT6360_CHG_TREG_EVT), > + MT6360_REGMAP_IRQ_REG(MT6360_CHG_AICR_EVT), [...] > + MT6360_REGMAP_IRQ_REG(MT6360_LDO7_PGB_EVT), > +}; [...] > diff --git a/include/linux/mfd/mt6360-private.h b/include/linux/mfd/mt6360-private.h > new file mode 100644 > index 000000000000..d542652f4de0 > --- /dev/null > +++ b/include/linux/mfd/mt6360-private.h As there are only appropriately namespaced macros in here, I would move them to the normal header file and dispose of this one. > @@ -0,0 +1,217 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2019 MediaTek Inc. > + */ > + > +#ifndef __MT6360_PRIVATE_H__ > +#define __MT6360_PRIVATE_H__ > + > +/* PMU register defininition */ > +#define MT6360_PMU_DEV_INFO (0x00) > +#define MT6360_PMU_CORE_CTRL1 (0x01) [...] > +#define MT6360_PMU_LDO_MASK2 (0xFF) > +#define MT6360_PMU_MAXREG (MT6360_PMU_LDO_MASK2) > + > +/* MT6360_PMU_IRQ_SET */ > +#define MT6360_PMU_IRQ_REGNUM (MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1) > +#define MT6360_IRQ_RETRIG BIT(2) > + > +#define CHIP_VEN_MASK (0xF0) > +#define CHIP_VEN_MT6360 (0x50) > +#define CHIP_REV_MASK (0x0F) > + > +#endif /* __MT6360_PRIVATE_H__ */ -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog