From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libnss: fix build failure due to HW PPC Crypto bug
Date: Thu, 2 Jan 2020 10:06:23 +0100 [thread overview]
Message-ID: <20200102100623.6ab6714b@windsurf> (raw)
In-Reply-To: <20200101165811.45110-1-giulio.benetti@benettiengineering.com>
Hello Giulio,
Thanks for the patch. One comment below.
On Wed, 1 Jan 2020 17:58:11 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> ifeq ($(BR2_aarch64_be),y)
> LIBNSS_ARCH = aarch64
> +else ifeq ($(BR2_powerpc),y)
> +LIBNSS_ARCH = ppc
> +else ifeq ($(BR2_powerpc64),y)
> +LIBNSS_ARCH = ppc64
> +else ifeq ($(BR2_powerpc64le),y)
> +LIBNSS_ARCH = ppc64le
> else
> LIBNSS_ARCH = $(ARCH)
> endif
Shouldn't we globally review the values that libnss wants for the
OS_TEST variable (which we set to $(LIBNSS_ARCH)) and see if other
architectures need similar tweaks ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-01-02 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 16:54 [Buildroot] [PATCH] package/libnss: fix build failure due to HW PPC Crypto bug Giulio Benetti
2019-12-27 17:05 ` Giulio Benetti
2019-12-31 17:07 ` Thomas Petazzoni
2019-12-31 21:24 ` Giulio Benetti
2019-12-31 22:49 ` Vincent Fazio
2019-12-31 23:31 ` Vincent Fazio
2019-12-31 23:44 ` Giulio Benetti
2020-01-01 8:47 ` Yann E. MORIN
2020-01-01 15:32 ` Thomas Petazzoni
2020-01-01 16:51 ` Giulio Benetti
2020-01-01 16:58 ` [Buildroot] [PATCH v2] " Giulio Benetti
2020-01-01 18:41 ` Yann E. MORIN
2020-01-02 9:06 ` Thomas Petazzoni [this message]
2020-01-02 17:19 ` Giulio Benetti
2020-01-02 22:07 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102100623.6ab6714b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.