From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFDCC2D0DC for ; Thu, 2 Jan 2020 21:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2828E217F4 for ; Thu, 2 Jan 2020 21:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577998883; bh=OEjdh4GxFJXSSDdvy3z1OTTwU0+yCPN2JFYuGdPQqIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VaLZAamPnao3B6SKjFzpQ4FQyR6ovWXoPuFmFGXPQVl/e00ZAFoFmg+YCprMePyCV IF1XPSYW4u+gnKDmbfyb1vXF4y3g/XOl1NC8iLt9aDv2qjECg+g6Be+qLABlrLkRqQ zDIbFEZwFsQZQhLmroV1gsn6yZBIl5Jbjlm4DoQ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725827AbgABVBW (ORCPT ); Thu, 2 Jan 2020 16:01:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:49544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbgABVBW (ORCPT ); Thu, 2 Jan 2020 16:01:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9854A21655; Thu, 2 Jan 2020 21:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577998882; bh=OEjdh4GxFJXSSDdvy3z1OTTwU0+yCPN2JFYuGdPQqIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Iqbl5upYX5JvnCIrULmFs5PvaefK1GBk7E11qY3GIBIp4/2yX/Urwg1jDw85yGMGY fmoHzh4SCdNDKY3+TbNN6ff7FOfH4zmGiuA3rKeOkh7E0ybLQkYGNgWFlgP5OfFJH7 7vxd8M7Ecu/w/Hj7A5lFs823bfRTQkWagXfBljpg= Date: Thu, 2 Jan 2020 22:01:19 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Cc: stable , Stephen Boyd Subject: Re: Clock related crashes in v5.4.y-queue Message-ID: <20200102210119.GA250861@kroah.com> References: <029dab5a-22f5-c4e9-0797-54cdba0f3539@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <029dab5a-22f5-c4e9-0797-54cdba0f3539@roeck-us.net> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 01, 2020 at 06:44:08PM -0800, Guenter Roeck wrote: > Hi, > > I see a number of crashes in the latest v5.4.y-queue; please see below > for details. The problem bisects to commit 54a311c5d3988d ("clk: Fix memory > leak in clk_unregister()"). > > The context suggests recovery from a failed driver probe, and it appears > that the memory is released twice. Interestingly, I don't see the problem > in mainline. > > I would suggest to drop that patch from the stable queue. That does not look right, as you point out, so I will go drop it now. The logic of the clk structure lifetimes seems crazy, messing with krefs and just "knowing" the lifecycle of the other structures seems like a problem just waiting to happen... thanks, greg k-h