From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
fugang.duan@nxp.com, Chris Healy <Chris.Healy@zii.aero>
Subject: Re: [PATCH net] net: freescale: fec: Fix ethtool -d runtime PM
Date: Fri, 3 Jan 2020 02:01:34 +0100 [thread overview]
Message-ID: <20200103010134.GC27690@lunn.ch> (raw)
In-Reply-To: <8658c955-eaac-f6d9-5fbe-b8542e26d141@gmail.com>
> This fix will do, but you should consider implementing
> ethtool_ops::begin and ethtool_ops::end to make sure this condition is
> resolved for all ethtool operations.
>
> For instance the following looks possibly problematic too:
> fec_enet_set_coalesce -> fec_enet_itr_coal_set
Hi Florian
I did a quick test of all the ethtool operations which the driver
supports, including setting coalescing. I did not exhaustively try all
possible coalescing settings, but the ones i did try did not provoke a
data abort.
Still, it would make sense to implement begin and end, but only for
net-next.
Andrew
next prev parent reply other threads:[~2020-01-03 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:33 [PATCH net] net: freescale: fec: Fix ethtool -d runtime PM Andrew Lunn
2020-01-03 0:38 ` David Miller
2020-01-03 0:51 ` Florian Fainelli
2020-01-03 1:01 ` Andrew Lunn [this message]
2020-01-03 2:02 ` [EXT] " Andy Duan
2020-01-03 2:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103010134.GC27690@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Healy@zii.aero \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.