From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 5/5] i2c: Enable compile testing for some of drivers Date: Fri, 3 Jan 2020 14:42:31 +0100 Message-ID: <20200103134231.GA2095@pi3> References: <20191230172751.17985-1-krzk@kernel.org> <20191230172751.17985-5-krzk@kernel.org> <20191231090146.GA6872@pi3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: Linux ARM , Wolfram Sang , Linus Walleij , Linux Kernel Mailing List , Vladimir Zapolskiy , Max Staudt , Elie Morisse , Jarkko Nikula , Linux I2C , Sylvain Lemieux , Juergen Fitschen , Jean Delvare List-Id: linux-i2c@vger.kernel.org On Tue, Dec 31, 2019 at 10:20:01AM +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Dec 31, 2019 at 10:01 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 30, 2019 at 08:11:03PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 30, 2019 at 6:28 PM Krzysztof Kozlowski wrote: > > > > Some of the I2C bus drivers can be compile tested to increase build > > > > coverage. This requires also: > > > > 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C > > > > controllers, > > > > 2. Adding 'if' conditional to 'default y' so they will not get enabled > > > > by default on all other architectures, > > > > 3. Limiting few compile test options to supported architectures (which > > > > provide the readsX()/writesX() primitives). > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > @@ -611,8 +612,8 @@ config I2C_EMEV2 > > > > > > > > config I2C_EXYNOS5 > > > > tristate "Exynos5 high-speed I2C driver" > > > > - depends on ARCH_EXYNOS && OF > > > > - default y > > > > + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST > > > > > > This means it is only useful on DT-based Exynos platforms, but compiles > > > everywhere? > > > > Yes. The driver will proble only from DT. > > > > > > > > Do you still have support for non-DT Exynos platforms? > > > ARCH_EXYNOS depends on ARCH_MULTI_V7? > > > > No, only DT. I think dependency here is a left over from board times and > > optional OF. Actually many drivers depend on OF and some OF-like ARCH so > > it could be removed. > > > > Since driver uses OF, it's rather the choice whether to explicitly > > mention OF. > > So the !OF case is only for compile-testing. Then it can be simplified to: > > depends on ARCH_EXYNOS || COMPILE_TEST > Many other drivers do exactly the same: depend on ARCH_xxx (which is already OF only) and on OF. Since OF now has all (or almost all) stubs for !OF case, such "depends on OF" is purely from logical point of view: the driver will not bind without OF. It will not be useful. I do not have strong opinion about this but is there a point to change only this one, while in all other places drivers depend on OF? It will just bring inconsistency. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D97C2D0C2 for ; Fri, 3 Jan 2020 13:42:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35EE7215A4 for ; Fri, 3 Jan 2020 13:42:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gK8dl24T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35EE7215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CnAPqYtPjmvR7U/3G9SnRxj2+v2pQT8D78SKnzswHwA=; b=gK8dl24TKq8SaT +flW7P0t70od2JajYceSzPNguHbfbMfbn+NoFrmzhk0P+URKgc7cLO9PTIA32GIegXTbN7vtSjZGt O0hRw00yYnzZgXhSAFoI22zpMTZ1iyxQ0g6SMGZGlE+l8iMt2WVFJusb6jWZwQ2+WmsPbJxgL61BW QinAuuRDI7vyJBNN/eAziAUBC+kr29PtfxmNRgdEzCW3jgIAq3bvfaQ0pYO1yquNCMj/osgDRCOps RMlOSultx6G3wIabDb0ZQmVqmtIBrO2QzWZahzfUDabFiYufcQIg/6SXBf/BL56hXUAhgX6n/nooN sxlkQuukOmi10pu3O8ow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inNDs-0007we-BF; Fri, 03 Jan 2020 13:42:40 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inNDo-0007wD-Mn for linux-arm-kernel@lists.infradead.org; Fri, 03 Jan 2020 13:42:38 +0000 Received: by mail-ed1-f66.google.com with SMTP id r21so41623129edq.0 for ; Fri, 03 Jan 2020 05:42:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6IGH/4NsfGNqzq/az3laNR9DmJ2S/QIcfX6JBOSE7W8=; b=sbbIS4K/EdN3IeHKjxYkarEHUhS3tBjG9KjAcGcmAKQd5v0V3j0XEcnypIT14tTutr H9eACgR1Yf9BsWL7E/3WrIrC/1PGnseAqtEuKUaruISre69w669/d7/+EtrBw08OutwT T6BqXYqGPtg+KuklyiabRdonlCOZUNhocDOF5lYpe3E1Umkq7JFGR1NbLdLeOw9PtBS4 zgGh3uHpTXCyNUF+mWZO7SzJOseP9ZYFmZ9nz1WVN+eTjUzrtZClvs5dp+T0AGeLGSFV 1ZmQ7Un/TjJlfRy8p+JZqfTQaRpOel0opkqiUAY72FYl0PjrlfYjJsOMWBYVz3jxF+zt PcCg== X-Gm-Message-State: APjAAAXcIO4k7fjTAFHY4A6HY58PT0tntzUcMJLQPN5xL9SNmmWHoj4o jbPprG+RdvZ2oTh+Y4yyEPA= X-Google-Smtp-Source: APXvYqz+iEmGUlqJ2ytifXahiNdcRR8fxZzTr5tUaDMie/rQytsdQJEzwg2+nqd+R4ZjXvdf3v9MvA== X-Received: by 2002:a17:907:20a8:: with SMTP id pw8mr92654258ejb.248.1578058954664; Fri, 03 Jan 2020 05:42:34 -0800 (PST) Received: from pi3 ([194.230.155.149]) by smtp.googlemail.com with ESMTPSA id r20sm7751571eju.60.2020.01.03.05.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 05:42:33 -0800 (PST) Date: Fri, 3 Jan 2020 14:42:31 +0100 From: Krzysztof Kozlowski To: Geert Uytterhoeven Subject: Re: [PATCH 5/5] i2c: Enable compile testing for some of drivers Message-ID: <20200103134231.GA2095@pi3> References: <20191230172751.17985-1-krzk@kernel.org> <20191230172751.17985-5-krzk@kernel.org> <20191231090146.GA6872@pi3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_054236_745829_8AF1CD02 X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Wolfram Sang , Linus Walleij , Linux Kernel Mailing List , Vladimir Zapolskiy , Max Staudt , Elie Morisse , Jarkko Nikula , Linux I2C , Sylvain Lemieux , Juergen Fitschen , Jean Delvare Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 31, 2019 at 10:20:01AM +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Dec 31, 2019 at 10:01 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 30, 2019 at 08:11:03PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 30, 2019 at 6:28 PM Krzysztof Kozlowski wrote: > > > > Some of the I2C bus drivers can be compile tested to increase build > > > > coverage. This requires also: > > > > 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C > > > > controllers, > > > > 2. Adding 'if' conditional to 'default y' so they will not get enabled > > > > by default on all other architectures, > > > > 3. Limiting few compile test options to supported architectures (which > > > > provide the readsX()/writesX() primitives). > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > @@ -611,8 +612,8 @@ config I2C_EMEV2 > > > > > > > > config I2C_EXYNOS5 > > > > tristate "Exynos5 high-speed I2C driver" > > > > - depends on ARCH_EXYNOS && OF > > > > - default y > > > > + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST > > > > > > This means it is only useful on DT-based Exynos platforms, but compiles > > > everywhere? > > > > Yes. The driver will proble only from DT. > > > > > > > > Do you still have support for non-DT Exynos platforms? > > > ARCH_EXYNOS depends on ARCH_MULTI_V7? > > > > No, only DT. I think dependency here is a left over from board times and > > optional OF. Actually many drivers depend on OF and some OF-like ARCH so > > it could be removed. > > > > Since driver uses OF, it's rather the choice whether to explicitly > > mention OF. > > So the !OF case is only for compile-testing. Then it can be simplified to: > > depends on ARCH_EXYNOS || COMPILE_TEST > Many other drivers do exactly the same: depend on ARCH_xxx (which is already OF only) and on OF. Since OF now has all (or almost all) stubs for !OF case, such "depends on OF" is purely from logical point of view: the driver will not bind without OF. It will not be useful. I do not have strong opinion about this but is there a point to change only this one, while in all other places drivers depend on OF? It will just bring inconsistency. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF1BC2D0C2 for ; Fri, 3 Jan 2020 13:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55611215A4 for ; Fri, 3 Jan 2020 13:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578058958; bh=Re1udvoDYqpTNDw/7+6UZbyqLf58lYZ4L55nzA9tidA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ls5V69gARmspdJjkwp6saRsQMLWwIUBdRK3qgBgrW2BnMTjAKMwx4ZhWJcpCwehtV 9iCoU6wuwAMdSyyTI8UyMJwQ2loP6XUUisouJD4wFj4NDWQUPA2HV/CtN71icqY45u JOkWLY/GP+1MWvsRr5FjLHoEjQceR8fQQJz+dYJ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbgACNmh (ORCPT ); Fri, 3 Jan 2020 08:42:37 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:36148 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727494AbgACNmg (ORCPT ); Fri, 3 Jan 2020 08:42:36 -0500 Received: by mail-ed1-f66.google.com with SMTP id j17so41641105edp.3; Fri, 03 Jan 2020 05:42:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6IGH/4NsfGNqzq/az3laNR9DmJ2S/QIcfX6JBOSE7W8=; b=R6MWRbCtnIQcJa/204qS2yEk0UjPAOf2cCK9ilnC/qhxzubcJLDfdxmA9r7+rdEeks qsrqpNK7hd8ZyIBU//rfQvXxoteXIr6P175ioFOVLiAuo8QvSWNdAF60YdJVXWOF258O 8AYjZjestLZOvvhU7A1ow2wgYWtw58lkGnlT+s3BBS5zMC8w4scptBVzxz9q0Gi49yho txpruZCzSGEuefoE05nsvFYGCtWntE0bvs11Wa0ZaoG06PLo9DYkrbrgAeRVtkCzOQc5 xs2FrJksOiypizxP8xl/PFUyo2wa14ntE4m2so+hxbE8e9mLes4w6D2yHnc91Ef/GYHD 2gCQ== X-Gm-Message-State: APjAAAU/oi57eBybgmWTW9Z0KM1AZIa6V3AXdLmMibSw95O1tXpAueS8 +0mbivTtRc69F6CFHSJQKcw= X-Google-Smtp-Source: APXvYqz+iEmGUlqJ2ytifXahiNdcRR8fxZzTr5tUaDMie/rQytsdQJEzwg2+nqd+R4ZjXvdf3v9MvA== X-Received: by 2002:a17:907:20a8:: with SMTP id pw8mr92654258ejb.248.1578058954664; Fri, 03 Jan 2020 05:42:34 -0800 (PST) Received: from pi3 ([194.230.155.149]) by smtp.googlemail.com with ESMTPSA id r20sm7751571eju.60.2020.01.03.05.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 05:42:33 -0800 (PST) Date: Fri, 3 Jan 2020 14:42:31 +0100 From: Krzysztof Kozlowski To: Geert Uytterhoeven Cc: Vladimir Zapolskiy , Sylvain Lemieux , Linus Walleij , Wolfram Sang , Jean Delvare , Jarkko Nikula , Max Staudt , Juergen Fitschen , Elie Morisse , Linux I2C , Linux Kernel Mailing List , Linux ARM Subject: Re: [PATCH 5/5] i2c: Enable compile testing for some of drivers Message-ID: <20200103134231.GA2095@pi3> References: <20191230172751.17985-1-krzk@kernel.org> <20191230172751.17985-5-krzk@kernel.org> <20191231090146.GA6872@pi3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 31, 2019 at 10:20:01AM +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Tue, Dec 31, 2019 at 10:01 AM Krzysztof Kozlowski wrote: > > On Mon, Dec 30, 2019 at 08:11:03PM +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 30, 2019 at 6:28 PM Krzysztof Kozlowski wrote: > > > > Some of the I2C bus drivers can be compile tested to increase build > > > > coverage. This requires also: > > > > 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C > > > > controllers, > > > > 2. Adding 'if' conditional to 'default y' so they will not get enabled > > > > by default on all other architectures, > > > > 3. Limiting few compile test options to supported architectures (which > > > > provide the readsX()/writesX() primitives). > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > @@ -611,8 +612,8 @@ config I2C_EMEV2 > > > > > > > > config I2C_EXYNOS5 > > > > tristate "Exynos5 high-speed I2C driver" > > > > - depends on ARCH_EXYNOS && OF > > > > - default y > > > > + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST > > > > > > This means it is only useful on DT-based Exynos platforms, but compiles > > > everywhere? > > > > Yes. The driver will proble only from DT. > > > > > > > > Do you still have support for non-DT Exynos platforms? > > > ARCH_EXYNOS depends on ARCH_MULTI_V7? > > > > No, only DT. I think dependency here is a left over from board times and > > optional OF. Actually many drivers depend on OF and some OF-like ARCH so > > it could be removed. > > > > Since driver uses OF, it's rather the choice whether to explicitly > > mention OF. > > So the !OF case is only for compile-testing. Then it can be simplified to: > > depends on ARCH_EXYNOS || COMPILE_TEST > Many other drivers do exactly the same: depend on ARCH_xxx (which is already OF only) and on OF. Since OF now has all (or almost all) stubs for !OF case, such "depends on OF" is purely from logical point of view: the driver will not bind without OF. It will not be useful. I do not have strong opinion about this but is there a point to change only this one, while in all other places drivers depend on OF? It will just bring inconsistency. Best regards, Krzysztof