From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Danit Goldberg <danitg@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH rdma-next] RDMA/cm: Use RCU synchronization mechanism to protect cm_id_private xa_load()
Date: Fri, 3 Jan 2020 16:36:59 -0400 [thread overview]
Message-ID: <20200103203659.GA29125@ziepe.ca> (raw)
In-Reply-To: <20191219134750.413429-1-leon@kernel.org>
On Thu, Dec 19, 2019 at 03:47:50PM +0200, Leon Romanovsky wrote:
> From: Danit Goldberg <danitg@mellanox.com>
>
> The RCU mechanism is optimized for read-mostly scenarios and therefore
> more suitable to protect the cm_id_private to decrease "cm.lock"
> congestion.
>
> This patch replaces the existing spinlock locking mechanism
> and kfree with RCU mechanism in places where spinlock(cm.lock)
> protected cm_id_priv xa_load.
>
> In addition, deletes cm_get_id function and use cm_acquire_id directly
> with the correct locking. The patch also removes an open coded version
> of cm_get_id, and replaces it with a call to cm_acquire_id.
>
> Signed-off-by: Danit Goldberg <danitg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/cm.c | 43 +++++++++++-------------------------
> 1 file changed, 13 insertions(+), 30 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-01-03 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 13:47 [PATCH rdma-next] RDMA/cm: Use RCU synchronization mechanism to protect cm_id_private xa_load() Leon Romanovsky
2020-01-03 20:36 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103203659.GA29125@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.