From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE3BC2D0C2 for ; Fri, 3 Jan 2020 20:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F54221835 for ; Fri, 3 Jan 2020 20:39:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="mdaLcrzE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727894AbgACUjp (ORCPT ); Fri, 3 Jan 2020 15:39:45 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:38032 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727400AbgACUjo (ORCPT ); Fri, 3 Jan 2020 15:39:44 -0500 Received: by mail-qt1-f195.google.com with SMTP id n15so37763283qtp.5 for ; Fri, 03 Jan 2020 12:39:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6uwto7vrkUQtrWJSFJTS/1IavIxmcHeTYe+CAUsTCK8=; b=mdaLcrzEKpM/uHGLst7j4AH8BnoPGBsJsMkhSaK2JE/d0CrmnhGLEACNNHDcm9oe11 nGCxR/SkcDbdgaeSuMtucHatxi1DJRGGu7eBwKc+D/PpxvVG3BTBMtn0EHS6FLgSz+Fq wvSFHeplsm3gGW6CImSpO5vvpNIAQ5amusyEtp5hxX4R/6i9lDlZQxlN7u2HPLU+N7WG i1MZ5UEiP2coNgiohexxWLN1xCaaFZNMiTqqahcuqZw6EOpP2zM/TdmKvi7D8JL9GUNn S4Wg2ql8HAg3r27AMCkw7VmrOsqwTTp5wBsGbJ+g88+ikmmfwBJAhYmzU4oXWDdnZpJ5 JBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6uwto7vrkUQtrWJSFJTS/1IavIxmcHeTYe+CAUsTCK8=; b=Az/y2/E6dr93ODYnt5G/4VWL6X9MQsv8ysXweFxpz6IlSnsBcMir1UaQAFwhJfZ05x OuL1T92AEBij79muNSYh/zuBfwkgcHAFYgQG+20PCJrQnJ97PuIGoRGOdX4ZsNPlDCXh RLkDT1CuAL69A9VX9MMPs059G+RTEXJQlPA7OO+Kthd/w5nlrh+qCkdB57XPNncqlh4H 8PfTe+Z/JQpe81HRjlUzmSFfaPv3rCQopFUJWeoj8CPy3G8ERfi36fsWL8CGsq05vVGd l4ru1PJcI2gGn6Etb5gEnFCBcC9BezrZFUTWpxmI/dx6Yz6Oi6AjiscTCNfZHECG7fSS A+Cw== X-Gm-Message-State: APjAAAUKj6pciX5FdCGiNWqqYHUsocE2b3abPpjqEg6p1TEMWnjNM0ow QfbvMYqlnQ1AyLJrDcrKmSz5BcEdAhk= X-Google-Smtp-Source: APXvYqxmCn3DQIutZS61HOJcMmhKtrKjPZbHXqWUw14kj8WHHE43Pditftaui85GB9XN7iMwNrH1GA== X-Received: by 2002:ac8:4257:: with SMTP id r23mr64691006qtm.126.1578083983573; Fri, 03 Jan 2020 12:39:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id u4sm16809273qkh.59.2020.01.03.12.39.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Jan 2020 12:39:43 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1inTjS-00016f-LW; Fri, 03 Jan 2020 16:39:42 -0400 Date: Fri, 3 Jan 2020 16:39:42 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Eugene Crosser , RDMA mailing list , Jack Wang , Leon Romanovsky Subject: Re: [PATCH rdma-next] RDMA/mlx4: Redo TX checksum offload in line with docs Message-ID: <20200103203942.GA4218@ziepe.ca> References: <20191219134847.413582-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219134847.413582-1-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Dec 19, 2019 at 03:48:47PM +0200, Leon Romanovsky wrote: > From: Eugene Crosser > > Ingress checksum offload was not working for IPv6 frames because the > conditional expression that checks validation status passed from the > hardware was not matching the algorithm described in the documentation. > > This patch defines L4_CSUM flag (which falls inside the badfcs_enc > field in the existing definition of the CQE layout) and replaces the > conditional expression with the one defined in the "ConnectX(r) > Family Programmer's Manual" document. > > Signed-off-by: Eugene Crosser > Reviewed-by: Jack Wang > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx4/cq.c | 18 +++++++----------- > include/linux/mlx4/cq.h | 5 +++++ > 2 files changed, 12 insertions(+), 11 deletions(-) Applied to for-next, thanks Jason