From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-doc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR
Date: Fri, 3 Jan 2020 21:51:36 +0100 [thread overview]
Message-ID: <20200103205136.GT1397@lunn.ch> (raw)
In-Reply-To: <E1inTn1-0001TI-4W@rmk-PC.armlinux.org.uk>
> + /*
> + * Rewrite 10GBASE-KR to 10GBASE-R for compatibility with existing DT.
> + * Existing usage of 10GBASE-KR is not correct; no backplane
> + * negotiation is done, and this driver does not actually support
> + * 10GBASE-KR.
> + */
> + if (phy_mode == PHY_INTERFACE_MODE_10GKR)
> + phy_mode = PHY_INTERFACE_MODE_10GBASER;
> +
Thanks
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-01-03 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 20:42 [PATCH net-next v2 0/2] Fix 10G PHY interface types Russell King - ARM Linux admin
2020-01-03 20:43 ` [PATCH net-next v2 1/2] net: phy: add PHY_INTERFACE_MODE_10GBASER Russell King
2020-01-03 20:43 ` [PATCH net-next v2 2/2] net: switch to using PHY_INTERFACE_MODE_10GBASER rather than 10GKR Russell King
2020-01-03 20:51 ` Andrew Lunn [this message]
2020-01-05 23:11 ` [PATCH net-next v2 0/2] Fix 10G PHY interface types David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103205136.GT1397@lunn.ch \
--to=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.