From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4BBC2D0C2 for ; Fri, 3 Jan 2020 21:00:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8512C215A4 for ; Fri, 3 Jan 2020 21:00:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8512C215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AD99891B4; Fri, 3 Jan 2020 21:00:27 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86F95891B4 for ; Fri, 3 Jan 2020 21:00:25 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2020 13:00:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,392,1571727600"; d="scan'208";a="421540577" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.165.21.211]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2020 13:00:23 -0800 Date: Fri, 3 Jan 2020 13:01:27 -0800 From: Manasi Navare To: Lee Shawn C Message-ID: <20200103210127.GA2608@intel.com> References: <20200103150737.17934-1-shawn.c.lee@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200103150737.17934-1-shawn.c.lee@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix incorrect test parameter for DP link layer compliance X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Cooper Chiou Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jan 03, 2020 at 11:07:37PM +0800, Lee Shawn C wrote: > Run intel_dp_compliance would failed at video pattern related > test case sometimes. DP test applet read incorrect test type > from kernel to cause this symptom. Add a "\n" (newline) in > seq_printf() then DP test applet will get proper parameters. > > Cc: Manasi Navare > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Ville Syrjala > Cc: Cooper Chiou > Signed-off-by: Lee Shawn C Manasi > > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c > index 0ac98e39eb75..74180158a909 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -3167,7 +3167,7 @@ static int i915_displayport_test_data_show(struct seq_file *m, void *data) > intel_dp = enc_to_intel_dp(&encoder->base); > if (intel_dp->compliance.test_type == > DP_TEST_LINK_EDID_READ) > - seq_printf(m, "%lx", > + seq_printf(m, "%lx\n", > intel_dp->compliance.test_data.edid); > else if (intel_dp->compliance.test_type == > DP_TEST_LINK_VIDEO_PATTERN) { > @@ -3209,7 +3209,7 @@ static int i915_displayport_test_type_show(struct seq_file *m, void *data) > > if (encoder && connector->status == connector_status_connected) { > intel_dp = enc_to_intel_dp(&encoder->base); > - seq_printf(m, "%02lx", intel_dp->compliance.test_type); > + seq_printf(m, "%02lx\n", intel_dp->compliance.test_type); > } else > seq_puts(m, "0"); > } > -- > 2.17.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx