From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D8DC00523 for ; Fri, 3 Jan 2020 22:27:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 648A0227BF for ; Fri, 3 Jan 2020 22:27:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rfuohgLA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 648A0227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5z5C+fs/xayn30HDoQNvxGZoJcb7FZa+nxg4HHjFZHg=; b=rfuohgLAGOLsGZ HcB3DrKlKW1eIo4nMKSbzkX0uCWk7QdqiFSC16BHF5mUpjkdx/+tBSSs3kOwuG3d0AB/Yr0B+LWAz AZ+QK6snpniUMdfDNTrVLxegnT1kOxU11Nc6IJ74zZCg1P2ZX6lsGyJTWVdPWrSXTD5tGUdWsSS49 bzetjVK7IYrZ0XRSIchcAUO9dCaBK9S2NvY4znFkHBSBtMjdGRFfArorw+NJpi7JJg3myzFGRdCki v0uIkyVS65/6PYqkQKNajnyiHaAKmcxvYR8jRHw4CiNs19JPztLs/vTH7lsttADH8PuWP7JEwiDpP VvnewE+6m01rHlMgnljQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inVPH-0000j5-0o; Fri, 03 Jan 2020 22:26:59 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inVP7-0000Zh-Vf for linux-mediatek@lists.infradead.org; Fri, 03 Jan 2020 22:26:52 +0000 Received: by mail-io1-f68.google.com with SMTP id i11so42868426ioi.12 for ; Fri, 03 Jan 2020 14:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH8EiEpsw3qEqxTu/vy8rZgCVIsth2Q4jMx+TyJClBo=; b=IpOHYw7FiNvfVGauO/pkLVvkFjk0IMThtOZOLKr7t4TAUFoyIDT2c/8K92IErgUrCp BK68SdjxSUl2FAffyzhzWK6u0mth0HJTPvnRUzq9Be4nPDzUNaaFkMCYpULwIl8pzgcg AJBAbMgnvHrmblVcUhVP1zochcSwmEImBSYuu81Ze+sr5SGHIwQ8ZpD97zKAbt7a4bp7 nEKVoYT90fkH4KmSmy4e6iE2E6xu3YYgdCbKga07De/kfA5B2bX6cQOWLeqjt0cvYcum lttaIPy21fxLfLEuQt8w/8HA8P3nSjJWdOb6sWnnVSb7lP+3E1o6ePVN4O2FUdyhYpQe kNEA== X-Gm-Message-State: APjAAAU2O3wpIVoGZKnXnfp02R9EHm6gyc4OddMoAioGl57Vw9y/5II6 PhU2/L6HnQGxDV0aYtb3NcbJxR8= X-Google-Smtp-Source: APXvYqz6dRzbEtHoZcDit5W7yp649b+rYmmON49ayGnKppqJ/SDu2B2WMVdFkTCZcaHYBhZUeFXhCw== X-Received: by 2002:a5d:949a:: with SMTP id v26mr62903639ioj.13.1578090408921; Fri, 03 Jan 2020 14:26:48 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id i136sm19169595ild.23.2020.01.03.14.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 14:26:46 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 15:26:45 -0700 Date: Fri, 3 Jan 2020 15:26:45 -0700 From: Rob Herring To: Yongqiang Niu Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Message-ID: <20200103222645.GA24430@bogus> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_142650_017876_3645613C X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Daniel Vetter , CK Hu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size Typo. And write complete sentences. > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma s/_/-/ Valid values? Max value? > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; A new property doesn't really warrant a whole new example. > \ No newline at end of file ^^^ > -- > 1.8.1.1.dirty _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7211C00523 for ; Fri, 3 Jan 2020 22:27:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A707227BF for ; Fri, 3 Jan 2020 22:27:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q/JKJ/g7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A707227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bdTUeLGN208c9hftBUuGNURNdx4TTqiBhP4n2U1H1bk=; b=q/JKJ/g7WZbQPL uaVEXzcpVtWid0rXmZ8VPjM1yWXwd/whyO/YIyhIUgKSRLqxFjLlcea6eKQdesHbV3hAr5PjLVuri uKuNtVwx4/mqjR6aRXCiebJYNaHm00xYLg/u7rZGgiyC3zSPttpS2WRMqUS1zP/O5kfPAx+gWINq8 9qqFQyM7HAXqn2bgyoy/UN+JNuRmAaS90DL76F7ug2XUoyNmbd24kc8E3DGNtvvKt4ZLKjUP04Hhr 2gR7Gp1QaxznvQfoePEiHelT1xcYw4+3cph4kXUg3Zevh3+rS0AGfc1rJaaUMkYz/ezM13LRetCco WEoPpCgQWrckB82ZRgdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inVPB-0000al-Cf; Fri, 03 Jan 2020 22:26:53 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inVP8-0000Zc-1B for linux-arm-kernel@lists.infradead.org; Fri, 03 Jan 2020 22:26:52 +0000 Received: by mail-io1-f66.google.com with SMTP id v18so42938780iol.2 for ; Fri, 03 Jan 2020 14:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH8EiEpsw3qEqxTu/vy8rZgCVIsth2Q4jMx+TyJClBo=; b=E8ExBTlSA0ov52m6Dh0LKPCYejGzgcVf5vsZOQYW3z3f4gPzbHL+OIppo6udgVlIqQ emN1gsukbWOr/hhfDxhCmNfVGht84Bnv+PEGLwhmn7r2kPURJ/QfS0Gqtzne9aUs3oJG qzRObU1OqfS8S9tixjitPHH87QoeGffVoo/MsmHlDepIoBUKZC1zbx9eftZssbQyxzuR FUqmU3rwIlNYIunqR9G5CwYZWESPBeB4023xvL3CJnNxM2tiGcuOXG9izZzXQWsaMx5x QcgZ2Dahp6NGnKOHxXJGClhk1WucJ7hvZMUWddHi/zQO29LhlsNyBzlJlkkFuihjR20h 7g2Q== X-Gm-Message-State: APjAAAVeA9EV7X9hY9M1XjgsBEDoRiJF2eXRKVLZ8tnSDNwXUvjRkwME afyWSAyCx8fblCmbjeRgWk8WUDU= X-Google-Smtp-Source: APXvYqymczDEXPY4K9UvZt74KNY35ZeQ4fNZUlDEqZolgLCg5VhYzOJcDUrnDVDLrrB6LUH5wyp5Sw== X-Received: by 2002:a05:6638:102:: with SMTP id x2mr69969480jao.71.1578090408330; Fri, 03 Jan 2020 14:26:48 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id k78sm21274963ila.80.2020.01.03.14.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 14:26:46 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 15:26:45 -0700 Date: Fri, 3 Jan 2020 15:26:45 -0700 From: Rob Herring To: Yongqiang Niu Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Message-ID: <20200103222645.GA24430@bogus> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_142650_069058_609CEC4A X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger , linux-mediatek@lists.infradead.org, Daniel Vetter , CK Hu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size Typo. And write complete sentences. > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma s/_/-/ Valid values? Max value? > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; A new property doesn't really warrant a whole new example. > \ No newline at end of file ^^^ > -- > 1.8.1.1.dirty _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B704C00523 for ; Fri, 3 Jan 2020 22:27:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EEB122B48 for ; Fri, 3 Jan 2020 22:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578090440; bh=HiU//N94Vl6wij2RpULeJtTyqG9XDs5TxrzybVZG+ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SCiHhKCNW6Qd7CtowxB+HqJlDTf3xqMuISgB4FDbJ3uMHXj7l+2EIwUdfu3mf3c1c sWldfKWl16NOxGgCCxmPVEQLMSWw4JVVfp2DBgjKL4FtR7pFlTFlgpmUvHEpy3E8Ba TyEY/ObsXVzwk5OUB9MyjtMLa5x/dBAES2kvy5h4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728711AbgACW1T (ORCPT ); Fri, 3 Jan 2020 17:27:19 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:46101 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgACW1T (ORCPT ); Fri, 3 Jan 2020 17:27:19 -0500 Received: by mail-io1-f67.google.com with SMTP id t26so42913935ioi.13 for ; Fri, 03 Jan 2020 14:27:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH8EiEpsw3qEqxTu/vy8rZgCVIsth2Q4jMx+TyJClBo=; b=eK1ZyIZwV0lY5kef8ejZ/VXstTxHvleTv1YGdy0uIAJwilS2q3/YImBMrYhrAcEjXG vmma8vQeDq0Enz/HZTBPMJK8aa4GrE6oc0nfGUpd+ymTZEHac92xxnzVD33tXWWlg1AN CQVJvcghcALuN0DZOA2xD2DdBL+92UT9N0jcBrvPomvdB47HWOeJmq9N7FyLoBa83aiA qBbKZ+Gd6jqlFKXImCRZu83uMhzAwfQLNWU+454aIzuKaDEVGjKokcin1B5Mc9bGUOYI h+b4C7kQpwPDeeyOTv+4JNleEWWnkyNugUvGgNwQJmjw2cpc9ieoGwPsi5IswyfgueBV 3MVA== X-Gm-Message-State: APjAAAWzyF+iIf4ByveEw7ymEOrY96NaZtQUKPI7fMTN3viezSSari2h qFauunubXPbYdMXoq0slEYNs8L4= X-Google-Smtp-Source: APXvYqwwgMeo5rAE+B/G0ne3oHTH9BkG7/ymmKSxbH5BgYp1x2W2jyQV70AosZ1cAXmOcYhQpsPdPQ== X-Received: by 2002:a5e:920a:: with SMTP id y10mr61887348iop.292.1578090437067; Fri, 03 Jan 2020 14:27:17 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id c3sm15152437ioc.63.2020.01.03.14.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 14:26:46 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 15:26:45 -0700 Date: Fri, 3 Jan 2020 15:26:45 -0700 From: Rob Herring To: Yongqiang Niu Cc: CK Hu , Philipp Zabel , Matthias Brugger , David Airlie , Daniel Vetter , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Message-ID: <20200103222645.GA24430@bogus> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size Typo. And write complete sentences. > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma s/_/-/ Valid values? Max value? > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; A new property doesn't really warrant a whole new example. > \ No newline at end of file ^^^ > -- > 1.8.1.1.dirty From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E4BC32767 for ; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA901227BF for ; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA901227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D14C6E351; Fri, 3 Jan 2020 22:26:51 +0000 (UTC) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id E12B26E351 for ; Fri, 3 Jan 2020 22:26:49 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id v15so37882632iln.0 for ; Fri, 03 Jan 2020 14:26:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nH8EiEpsw3qEqxTu/vy8rZgCVIsth2Q4jMx+TyJClBo=; b=MWGnbr+VjFv89vpt+K5ANG2xtIGXZ3K+HqnmgTpBdZ6OJnBn+cANHB73VxPkra/PQn RdQUZFYu+3jCyunSkXnmKFFP9BOYo/tbTOBVLitX5Z61GOZx3hyvMjs/1r2EcuJT2RXP X1EL8KjV+Ok+qQmn3Na4gZ98MGmM/QXFDXn6fgDimxk2cUbnqJKBoyJn2twvHtGQMmJ5 iJb605inqy0+fx+oGtr8xMOjR7hSQMiX5uFjm2YLGB+d6npkRjW0p+qmhXr8tERt4vnK cKo3udKusXqXuBeuaecklWeqqVdKcW3tZZKhWJwZsa4m+mVZGqM8VgF/MhKIj07236Da E1Zg== X-Gm-Message-State: APjAAAVWAg9jkEjw64FcGl+ZLfj+2r2EzR1aKMt2oADJxf11GS/IxeSE 6U7nBnQ0KzPhp3pwlziVjVOjobo= X-Google-Smtp-Source: APXvYqxBfAAk5uAmiwUNjbckpuM/KXaRt5y89pyW2xNiKPgbbjdPUtpqseD1K2dL6DAaydm/AdN/VQ== X-Received: by 2002:a92:4016:: with SMTP id n22mr75427638ila.13.1578090407818; Fri, 03 Jan 2020 14:26:47 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id o12sm15093651ioh.42.2020.01.03.14.26.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 14:26:46 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 15:26:45 -0700 Date: Fri, 3 Jan 2020 15:26:45 -0700 From: Rob Herring To: Yongqiang Niu Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Message-ID: <20200103222645.GA24430@bogus> References: <1578021148-32413-1-git-send-email-yongqiang.niu@mediatek.com> <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote: > Update device tree binding documention for rdma_fifo_size Typo. And write complete sentences. > > Signed-off-by: Yongqiang Niu > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > index 681502e..34bef44 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > @@ -70,6 +70,10 @@ Required properties (DMA function blocks): > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > for details. > > +Required properties (DMA function blocks): > +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this > + property to the corresponding rdma s/_/-/ Valid values? Max value? > + > Examples: > > mmsys: clock-controller@14000000 { > @@ -211,3 +215,12 @@ od@14023000 { > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DISP_OD>; > }; > + > +rdma1: rdma@1400c000 { > + compatible = "mediatek,mt8183-disp-rdma"; > + reg = <0 0x1400c000 0 0x1000>; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA1>; > + mediatek,rdma_fifo_size = <2048>; > +}; A new property doesn't really warrant a whole new example. > \ No newline at end of file ^^^ > -- > 1.8.1.1.dirty _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel