From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B2AC00523 for ; Sat, 4 Jan 2020 00:32:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6033421835 for ; Sat, 4 Jan 2020 00:32:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o4+PC4KX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6033421835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a6PCc26CDNc2hI5ivQJ5tE7XUyrNkQ4XVh4TI5TIIGc=; b=o4+PC4KXtZC/nY R0YgGvWhBJcFNIt9FgCrgQcwU3HOFvLbAqsqQ/1tTvikiiSXL3E7VD7lR1rH9QaMLuxsjoOaoR/kc 3qc3H+tsgSzLNl49yeqXoxcQOahiKq3DA9F4cM28Isp6w6E52RX7CFd8GsIkretl+261BLaJvwOCo Ih83MvmjdAXuUZ908tB8Ntd95/pJ+u1n5ZhrmMzOclXXzGaoXavFnko02z1doQYqKDarFlSpKMz2t joiCl84bNNXJDQzUmne8m+fPRv/HQFj3Xz+7aI41olp0qy+WY5pLAZsCvBUQByB27L1epQv6sg9mR QytcHr4YwnzGQ0FLZ6Og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inXMX-0002dt-RJ; Sat, 04 Jan 2020 00:32:17 +0000 Received: from mail-il1-f195.google.com ([209.85.166.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inXMU-0002dH-V3 for linux-amlogic@lists.infradead.org; Sat, 04 Jan 2020 00:32:16 +0000 Received: by mail-il1-f195.google.com with SMTP id g12so38040548ild.2 for ; Fri, 03 Jan 2020 16:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OkEhI0mGAaFruOBaLTQQRQIQxA1NVDP05WMjkcVPHmI=; b=m4WXNFKp+MCtcXFqNqk2qsczmSz/ObMC2jRyjVwidOXIgnGAwk4pfja0NEZXmg5lfz X5B74iG6qJrJt5uxD0aB9IFF91EJOmEIoY1E4lKXJM0p5VXjo6hSxnvST1+2lTi6WHRL lidhxjTIel9zpyJAMJzuQrM1x6zikG7TGjzLYYhQqgYmlVshLaxhKQLS2eEbDTncvZgf r2N0hbQKtMMVAPOCbe0j/j37NiUGu43+2xDeUxktq6xiNWRRmMxOQS4PcwBwfn0ltdrF /4nFwh/Uv7F6NmsnEKSCWz2zboheOW7GXQsWkbi7dn1CYF5nhbFW0seEAdmAWas31477 itsw== X-Gm-Message-State: APjAAAXLUhdu9GpIbNyCFIjIaDMDjLfpCbh88v++0u7b0Zw1wr5g5KSN I3oVuu1QqowyD1kIBHIMvEp1+TE= X-Google-Smtp-Source: APXvYqz9zPF3qjXkzjIPO/hILm9HI5GEUadKISTarEgA2AGYyQRmyMlh76NSyoKC3HaG2ITz1CV52A== X-Received: by 2002:a92:3cd4:: with SMTP id j81mr81487949ilf.77.1578097932687; Fri, 03 Jan 2020 16:32:12 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id g23sm18674125ila.15.2020.01.03.16.32.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 16:32:12 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 17:32:10 -0700 Date: Fri, 3 Jan 2020 17:32:10 -0700 From: Rob Herring To: Hanjie Lin Subject: Re: [PATCH v3 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Message-ID: <20200104003210.GA29074@bogus> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_163215_000196_49FE4FF8 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , Jian Hu , Liang Yang , Qiufang Dai , Xingyu Chen , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Dec 27, 2019 at 02:36:42PM +0800, Hanjie Lin wrote: > The Amlogic A1 SoC Family embeds 1 USB Controllers: > - a DWC3 IP configured as Host for USB2 and USB3 > > A glue connects the controllers to the USB2 PHY of A1 SoC. > > Signed-off-by: Hanjie Lin > Signed-off-by: Yue Wang > --- > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 57 +++++++++++++++++++--- > 1 file changed, 51 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 4efb77b..6103cc2 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -9,6 +9,8 @@ title: Amlogic Meson G12A DWC3 USB SoC Controller Glue > > maintainers: > - Neil Armstrong > + - Hanjie Lin > + - Yue Wang > > description: | > The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 > @@ -22,10 +24,14 @@ description: | > The DWC3 Glue controls the PHY routing and power, an interrupt line is > connected to the Glue to serve as OTG ID change detection. > > + The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > + host-only mode. > + > properties: > compatible: > enum: > - amlogic,meson-g12a-usb-ctrl > + - amlogic,meson-a1-usb-ctrl > > ranges: true > > @@ -37,6 +43,11 @@ properties: > > clocks: > minItems: 1 > + maxItems: 4 > + > + clock-names: > + minItems: 1 > + maxItems: 4 > > resets: > minItems: 1 > @@ -47,17 +58,22 @@ properties: > interrupts: > maxItems: 1 > > + phys: > + minItems: 1 > + maxItems: 3 > + > phy-names: > items: > - const: usb2-phy0 # USB2 PHY0 if USBHOST_A port is used > - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used > - const: usb3-phy0 # USB3 PHY if USB3_0 is used > > - phys: > - minItems: 1 > - maxItems: 3 > - Why the unnecessary move? > - dr_mode: true > + dr_mode: > + description: usb mode for G12A > + enum: > + - host > + - peripheral > + - otg No, this is a common property that doesn't need to be redefined here. It was correct as-is. > > power-domains: > maxItems: 1 > @@ -80,9 +96,9 @@ required: > - resets > - reg > - interrupts > - - phy-names > - phys > - dr_mode > + - phy-names Again, unnecessary change. > > examples: > - | > @@ -124,4 +140,33 @@ examples: > snps,quirk-frame-length-adjustment; > }; > }; > + - | > + a1_usb: usb@ffe09000 { You are only adding a compatible. No need for a whole new example. > + status = "okay"; > + compatible = "amlogic,meson-a1-usb-ctrl"; > + reg = <0 0xffe09000 0x0 0xa0>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > > + clocks = <&clkc_periphs 36>, > + <&clkc_periphs 85>, > + <&clkc_periphs 2>, > + <&clkc_periphs 3>; > + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", > + "xtal_usb_ctrl"; > + > + resets = <&reset 36>; > + > + phys = <&usb2_phy1>; > + phy-names = "usb2-phy1"; > + > + a1_dwc3: usb@ff400000 { > + compatible = "snps,dwc3"; > + reg = <0xff400000 0x100000>; > + interrupts = <0 90 4>; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + }; > + }; > -- > 2.7.4 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F944C32767 for ; Sat, 4 Jan 2020 00:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26F5A21835 for ; Sat, 4 Jan 2020 00:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578098117; bh=M7aIwZfl2ohAAgMncAbyydKZCVSAvhAVlGopIdlIMfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wtwJm2r2Yimoya/q4EKFwBkFclPo8K3TACASpp16V5HhHTToCUzCG7woYkaCAToYC o2twyWgcNow/mAa1A/r5vqwMIgeZttCpLs+x79MBfwRDPsWETc4z5vaen7HltGPuYc vDICOE/xKrAKyZKs3CQWcGOIupJ6nnE0UjssISaI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbgADAfQ (ORCPT ); Fri, 3 Jan 2020 19:35:16 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:40151 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgADAfQ (ORCPT ); Fri, 3 Jan 2020 19:35:16 -0500 Received: by mail-io1-f66.google.com with SMTP id x1so43108810iop.7 for ; Fri, 03 Jan 2020 16:35:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OkEhI0mGAaFruOBaLTQQRQIQxA1NVDP05WMjkcVPHmI=; b=DDM4Kssg75PvYrLfBWHaq/LJUQZNV5oh+VoG5TYZmIj0H6G0lz5g+N7Lw4ZhICDG8s mIMOagYxDPhLGnwYc+egjroBAvy/dE6ORk5PZ7yiSA1qmspTY7nfEoN/Z1GJoEkTJLJ/ TWQ98YuwDDO4CBujdvjSAIC8pdHlEoVkpKpzVf69t3K5Jd2drMyz2WE9hR+q1W+ALfi1 RtFxcltPnvTRdS3pry4A/PVFS5UMZHZ8gCRss3PzzKUeUIhix8Fy2Wh8ngD3ts4+t7sI B7XZC4t0h8VOAkcngrd/PsOgKq+Q1ehmBmU/2hYeO1F5lN0eCPpE7rohj03yZKoGk/Rt SVvg== X-Gm-Message-State: APjAAAURUxnwl7Ot7lL6XD75HnLWRwFK5WWb5YRRb8s58SZrMDOgyVOs PkG98n3iO6CaqKorUxrp+MIFSgo= X-Google-Smtp-Source: APXvYqzAn1A70ghWKDChfVFcS4y/CMv1WJ8MTqAlSkZ75J4ubvMeh0kkbLwKFDof6TA6ol4qNZh8cw== X-Received: by 2002:a6b:3a8a:: with SMTP id h132mr59344208ioa.207.1578098114900; Fri, 03 Jan 2020 16:35:14 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id q11sm12438972ioi.25.2020.01.03.16.35.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 16:35:14 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 17:32:10 -0700 Date: Fri, 3 Jan 2020 17:32:10 -0700 From: Rob Herring To: Hanjie Lin Cc: Jerome Brunet , Neil Armstrong , Greg Kroah-Hartman , Kevin Hilman , Yue Wang , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Carlo Caione , Michael Turquette , Stephen Boyd , Martin Blumenstingl , Liang Yang , Jianxin Pan , Qiufang Dai , Jian Hu , Victor Wan , Xingyu Chen Subject: Re: [PATCH v3 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Message-ID: <20200104003210.GA29074@bogus> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Dec 27, 2019 at 02:36:42PM +0800, Hanjie Lin wrote: > The Amlogic A1 SoC Family embeds 1 USB Controllers: > - a DWC3 IP configured as Host for USB2 and USB3 > > A glue connects the controllers to the USB2 PHY of A1 SoC. > > Signed-off-by: Hanjie Lin > Signed-off-by: Yue Wang > --- > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 57 +++++++++++++++++++--- > 1 file changed, 51 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 4efb77b..6103cc2 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -9,6 +9,8 @@ title: Amlogic Meson G12A DWC3 USB SoC Controller Glue > > maintainers: > - Neil Armstrong > + - Hanjie Lin > + - Yue Wang > > description: | > The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 > @@ -22,10 +24,14 @@ description: | > The DWC3 Glue controls the PHY routing and power, an interrupt line is > connected to the Glue to serve as OTG ID change detection. > > + The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > + host-only mode. > + > properties: > compatible: > enum: > - amlogic,meson-g12a-usb-ctrl > + - amlogic,meson-a1-usb-ctrl > > ranges: true > > @@ -37,6 +43,11 @@ properties: > > clocks: > minItems: 1 > + maxItems: 4 > + > + clock-names: > + minItems: 1 > + maxItems: 4 > > resets: > minItems: 1 > @@ -47,17 +58,22 @@ properties: > interrupts: > maxItems: 1 > > + phys: > + minItems: 1 > + maxItems: 3 > + > phy-names: > items: > - const: usb2-phy0 # USB2 PHY0 if USBHOST_A port is used > - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used > - const: usb3-phy0 # USB3 PHY if USB3_0 is used > > - phys: > - minItems: 1 > - maxItems: 3 > - Why the unnecessary move? > - dr_mode: true > + dr_mode: > + description: usb mode for G12A > + enum: > + - host > + - peripheral > + - otg No, this is a common property that doesn't need to be redefined here. It was correct as-is. > > power-domains: > maxItems: 1 > @@ -80,9 +96,9 @@ required: > - resets > - reg > - interrupts > - - phy-names > - phys > - dr_mode > + - phy-names Again, unnecessary change. > > examples: > - | > @@ -124,4 +140,33 @@ examples: > snps,quirk-frame-length-adjustment; > }; > }; > + - | > + a1_usb: usb@ffe09000 { You are only adding a compatible. No need for a whole new example. > + status = "okay"; > + compatible = "amlogic,meson-a1-usb-ctrl"; > + reg = <0 0xffe09000 0x0 0xa0>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > > + clocks = <&clkc_periphs 36>, > + <&clkc_periphs 85>, > + <&clkc_periphs 2>, > + <&clkc_periphs 3>; > + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", > + "xtal_usb_ctrl"; > + > + resets = <&reset 36>; > + > + phys = <&usb2_phy1>; > + phy-names = "usb2-phy1"; > + > + a1_dwc3: usb@ff400000 { > + compatible = "snps,dwc3"; > + reg = <0xff400000 0x100000>; > + interrupts = <0 90 4>; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + }; > + }; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E492CC00523 for ; Sat, 4 Jan 2020 00:32:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC81C21835 for ; Sat, 4 Jan 2020 00:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yw3tiMGS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC81C21835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xm5SnY2KOUEPHTzCFOhBxi5Yv3P9v+MtD+gVA/ZcSRI=; b=Yw3tiMGS9JTkC3 etbSrTHdZnce2oBdz8cY+J0JwW5ws6yzGrbmvz8Y5PfP+mCmn5VSO+2Bp6APhLchH244xrx7CHElK AqfgrgGyukXSY9335ESVYhFshz/Dn88WwpUiX+7XoDWgZSNdl7l8q1ekFLPWsJQ4HwJmXewtQVzrW +L3FcSrnvrfickOz2C0hirxz03tGyzWVB97L1Rh33WzskVvJjz78003ZRnfQk0+ppmFs38pTcOA7n GTS9CDuhBjeZ1jNMoMFJwy0TGGFe1DopFq6AJ8DeX/0cxji5GilsljRptlUKMVeTkh1R/d2eklhIq 9k1QURxFjDE1Pl9LOKgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inXMZ-0002ek-1k; Sat, 04 Jan 2020 00:32:19 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inXMV-0002dI-8y for linux-arm-kernel@lists.infradead.org; Sat, 04 Jan 2020 00:32:16 +0000 Received: by mail-io1-f66.google.com with SMTP id n21so41545853ioo.10 for ; Fri, 03 Jan 2020 16:32:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OkEhI0mGAaFruOBaLTQQRQIQxA1NVDP05WMjkcVPHmI=; b=te6NWr/Yj+3V/fCEba7VhsiB3stVo96tZL16xoTlXOz6YxwTM0ISNsXGeSVOaOTs5R 5KYJDdmZsBHduyou2DwzAvvaX1FSJegEPDXUsmymgglrIx/f/gTp9a5KEcYPOh8dAlgg YwcFFl63oonMqSh0+mu2CdozYQX5AMMQyWmfaMG19OtYvRuWodAJ+2Cy46vnnRtFGGrq jPShpqByz5WRy9GZLhZ0R6nvXR3THluS4RD13TMDzogEcgjTklMwJtWcmBI+Qpn84pCc 8UaT4qaoiBG7QYyzqubjpS7cQGB13ENIE4IW869Z0tgm0i0mn/JNkn8rZ2s/ES85dt72 KFyw== X-Gm-Message-State: APjAAAUgcIwEwcXTddDVnSmXFfJn/onQ0D6dJo4Hhg4xzTkIbMCG1/Tq FEJLEsihFSdEW/tY9W6b5O0X/ck= X-Google-Smtp-Source: APXvYqzYeyB3X8uVjKFCrH+gS/sElKPvP39zwEYCuh4/dnMlQgXcTPNttuFBn+3aPg+4Ly3mj6thCw== X-Received: by 2002:a5d:9d4a:: with SMTP id k10mr62552449iok.134.1578097932963; Fri, 03 Jan 2020 16:32:12 -0800 (PST) Received: from rob-hp-laptop ([64.188.179.251]) by smtp.gmail.com with ESMTPSA id l17sm19532216ilc.49.2020.01.03.16.32.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 16:32:12 -0800 (PST) Received: from rob (uid 1000) (envelope-from rob@rob-hp-laptop) id 2219a5 by rob-hp-laptop (DragonFly Mail Agent v0.11); Fri, 03 Jan 2020 17:32:10 -0700 Date: Fri, 3 Jan 2020 17:32:10 -0700 From: Rob Herring To: Hanjie Lin Subject: Re: [PATCH v3 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Message-ID: <20200104003210.GA29074@bogus> References: <1577428606-69855-1-git-send-email-hanjie.lin@amlogic.com> <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1577428606-69855-3-git-send-email-hanjie.lin@amlogic.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_163215_312540_0781C033 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Victor Wan , Jianxin Pan , Neil Armstrong , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , Jian Hu , Liang Yang , Qiufang Dai , Xingyu Chen , Kevin Hilman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 27, 2019 at 02:36:42PM +0800, Hanjie Lin wrote: > The Amlogic A1 SoC Family embeds 1 USB Controllers: > - a DWC3 IP configured as Host for USB2 and USB3 > > A glue connects the controllers to the USB2 PHY of A1 SoC. > > Signed-off-by: Hanjie Lin > Signed-off-by: Yue Wang > --- > .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 57 +++++++++++++++++++--- > 1 file changed, 51 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > index 4efb77b..6103cc2 100644 > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -9,6 +9,8 @@ title: Amlogic Meson G12A DWC3 USB SoC Controller Glue > > maintainers: > - Neil Armstrong > + - Hanjie Lin > + - Yue Wang > > description: | > The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 > @@ -22,10 +24,14 @@ description: | > The DWC3 Glue controls the PHY routing and power, an interrupt line is > connected to the Glue to serve as OTG ID change detection. > > + The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > + host-only mode. > + > properties: > compatible: > enum: > - amlogic,meson-g12a-usb-ctrl > + - amlogic,meson-a1-usb-ctrl > > ranges: true > > @@ -37,6 +43,11 @@ properties: > > clocks: > minItems: 1 > + maxItems: 4 > + > + clock-names: > + minItems: 1 > + maxItems: 4 > > resets: > minItems: 1 > @@ -47,17 +58,22 @@ properties: > interrupts: > maxItems: 1 > > + phys: > + minItems: 1 > + maxItems: 3 > + > phy-names: > items: > - const: usb2-phy0 # USB2 PHY0 if USBHOST_A port is used > - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used > - const: usb3-phy0 # USB3 PHY if USB3_0 is used > > - phys: > - minItems: 1 > - maxItems: 3 > - Why the unnecessary move? > - dr_mode: true > + dr_mode: > + description: usb mode for G12A > + enum: > + - host > + - peripheral > + - otg No, this is a common property that doesn't need to be redefined here. It was correct as-is. > > power-domains: > maxItems: 1 > @@ -80,9 +96,9 @@ required: > - resets > - reg > - interrupts > - - phy-names > - phys > - dr_mode > + - phy-names Again, unnecessary change. > > examples: > - | > @@ -124,4 +140,33 @@ examples: > snps,quirk-frame-length-adjustment; > }; > }; > + - | > + a1_usb: usb@ffe09000 { You are only adding a compatible. No need for a whole new example. > + status = "okay"; > + compatible = "amlogic,meson-a1-usb-ctrl"; > + reg = <0 0xffe09000 0x0 0xa0>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > > + clocks = <&clkc_periphs 36>, > + <&clkc_periphs 85>, > + <&clkc_periphs 2>, > + <&clkc_periphs 3>; > + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_phy", > + "xtal_usb_ctrl"; > + > + resets = <&reset 36>; > + > + phys = <&usb2_phy1>; > + phy-names = "usb2-phy1"; > + > + a1_dwc3: usb@ff400000 { > + compatible = "snps,dwc3"; > + reg = <0xff400000 0x100000>; > + interrupts = <0 90 4>; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + }; > + }; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel