From: Deepa Dinamani <deepa.kernel@gmail.com>
To: bhelgaas@google.com
Cc: mika.westerberg@linux.intel.com, alex.williamson@redhat.com,
logang@deltatee.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] pci: Warn if BME cannot be turned off during kexec
Date: Sat, 4 Jan 2020 14:50:52 -0800 [thread overview]
Message-ID: <20200104225052.27275-1-deepa.kernel@gmail.com> (raw)
BME not being off is a security risk, so for whatever
reason if we cannot disable it, print a warning.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---
drivers/pci/pci-driver.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 0454ca0e4e3f..6c866a81f46c 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -491,8 +491,12 @@ static void pci_device_shutdown(struct device *dev)
* If it is not a kexec reboot, firmware will hit the PCI
* devices with big hammer and stop their DMA any way.
*/
- if (kexec_in_progress && (pci_dev->current_state <= PCI_D3hot))
- pci_clear_master(pci_dev);
+ if (kexec_in_progress) {
+ if (likely(pci_dev->current_state <= PCI_D3hot))
+ pci_clear_master(pci_dev);
+ else
+ dev_warn(dev, "Unable to turn off BME during kexec");
+ }
}
#ifdef CONFIG_PM
--
2.17.1
next reply other threads:[~2020-01-04 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 22:50 Deepa Dinamani [this message]
2020-01-06 13:54 ` [PATCH] pci: Warn if BME cannot be turned off during kexec Bjorn Helgaas
2020-01-06 19:38 ` Deepa Dinamani
2020-01-08 17:44 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104225052.27275-1-deepa.kernel@gmail.com \
--to=deepa.kernel@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.