From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ Date: Sun, 5 Jan 2020 06:16:30 -0500 Message-ID: <20200105061532-mutt-send-email-mst@kernel.org> References: <20191223140322.20013-1-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Jason Wang Cc: Alistair Delva , Willem de Bruijn , Network Development , LKML , virtualization@lists.linux-foundation.org, "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBEZWMgMjQsIDIwMTkgYXQgMTA6NDk6MTNBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDE5LzEyLzI0IOS4iuWNiDQ6MjEsIEFsaXN0YWlyIERlbHZhIHdyb3RlOgo+ ID4gT24gTW9uLCBEZWMgMjMsIDIwMTkgYXQgMTI6MTIgUE0gV2lsbGVtIGRlIEJydWlqbgo+ID4g PHdpbGxlbWRlYnJ1aWpuLmtlcm5lbEBnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiBPbiBNb24sIERl YyAyMywgMjAxOSBhdCAyOjU2IFBNIFdpbGxlbSBkZSBCcnVpam4KPiA+ID4gPHdpbGxlbWRlYnJ1 aWpuLmtlcm5lbEBnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+IDAwZmZmZTBmZjAgRFI3OiAwMDAw MDAwMDAwMDAwNDAwCj4gPiA+ID4gPiA+IENhbGwgVHJhY2U6Cj4gPiA+ID4gPiA+ICAgPyBwcmVl bXB0X2NvdW50X2FkZCsweDU4LzB4YjAKPiA+ID4gPiA+ID4gICA/IF9yYXdfc3Bpbl9sb2NrX2ly cXNhdmUrMHgzNi8weDcwCj4gPiA+ID4gPiA+ICAgPyBfcmF3X3NwaW5fdW5sb2NrX2lycXJlc3Rv cmUrMHgxYS8weDQwCj4gPiA+ID4gPiA+ICAgPyBfX3dha2VfdXArMHg3MC8weDE5MAo+ID4gPiA+ ID4gPiAgIHZpcnRuZXRfc2V0X2ZlYXR1cmVzKzB4OTAvMHhmMCBbdmlydGlvX25ldF0KPiA+ID4g PiA+ID4gICBfX25ldGRldl91cGRhdGVfZmVhdHVyZXMrMHgyNzEvMHg5ODAKPiA+ID4gPiA+ID4g ICA/IG5sbXNnX25vdGlmeSsweDViLzB4YTAKPiA+ID4gPiA+ID4gICBkZXZfZGlzYWJsZV9scm8r MHgyYi8weDE5MAo+ID4gPiA+ID4gPiAgID8gaW5ldF9uZXRjb25mX25vdGlmeV9kZXZjb25mKzB4 ZTIvMHgxMjAKPiA+ID4gPiA+ID4gICBkZXZpbmV0X3N5c2N0bF9mb3J3YXJkKzB4MTc2LzB4MWUw Cj4gPiA+ID4gPiA+ICAgcHJvY19zeXNfY2FsbF9oYW5kbGVyKzB4MWYwLzB4MjUwCj4gPiA+ID4g PiA+ICAgcHJvY19zeXNfd3JpdGUrMHhmLzB4MjAKPiA+ID4gPiA+ID4gICBfX3Zmc193cml0ZSsw eDNlLzB4MTkwCj4gPiA+ID4gPiA+ICAgPyBfX3NiX3N0YXJ0X3dyaXRlKzB4NmQvMHhkMAo+ID4g PiA+ID4gPiAgIHZmc193cml0ZSsweGQzLzB4MTkwCj4gPiA+ID4gPiA+ICAga3N5c193cml0ZSsw eDY4LzB4ZDAKPiA+ID4gPiA+ID4gICBfX2lhMzJfc3lzX3dyaXRlKzB4MTQvMHgyMAo+ID4gPiA+ ID4gPiAgIGRvX2Zhc3Rfc3lzY2FsbF8zMisweDg2LzB4ZTAKPiA+ID4gPiA+ID4gICBlbnRyeV9T WVNFTlRFUl9jb21wYXQrMHg3Yy8weDhlCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBBIHNpbWls YXIgY3Jhc2ggd2lsbCBsaWtlbHkgdHJpZ2dlciB3aGVuIGVuYWJsaW5nIFhEUC4KPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+IFJlcG9ydGVkLWJ5OiBBbGlzdGFpciBEZWx2YSA8YWRlbHZhQGdvb2ds ZS5jb20+Cj4gPiA+ID4gPiA+IFJlcG9ydGVkLWJ5OiBXaWxsZW0gZGUgQnJ1aWpuIDx3aWxsZW1k ZWJydWlqbi5rZXJuZWxAZ21haWwuY29tPgo+ID4gPiA+ID4gPiBGaXhlczogM2Y5MzUyMmZmYWIy ICgidmlydGlvLW5ldDogc3dpdGNoIG9mZiBvZmZsb2FkcyBvbiBkZW1hbmQgaWYgcG9zc2libGUg b24gWERQIHNldCIpCj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1pY2hhZWwgUy4gVHNpcmtp biA8bXN0QHJlZGhhdC5jb20+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gTGlnaHRseSB0ZXN0ZWQuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBBbGlzdGFpciwgY291 bGQgeW91IHBsZWFzZSB0ZXN0IGFuZCBjb25maXJtIHRoYXQgdGhpcyByZXNvbHZlcyB0aGUKPiA+ ID4gPiA+ID4gY3Jhc2ggZm9yIHlvdT8KPiA+ID4gPiA+IFRoaXMgcGF0Y2ggZG9lc24ndCB3b3Jr LiBUaGUgcmVhc29uIGlzIHRoYXQgTkVUSUZfRl9MUk8gaXMgYWxzbyB0dXJuZWQKPiA+ID4gPiA+ IG9uIGJ5IFRTTzQvVFNPNiwgd2hpY2ggeW91ciBwYXRjaCBkaWRuJ3QgY2hlY2sgZm9yLiBTbyBp dCBlbmRzIHVwCj4gPiA+ID4gPiBnb2luZyB0aHJvdWdoIHRoZSBzYW1lIHBhdGggYW5kIGNyYXNo aW5nIGluIHRoZSBzYW1lIHdheS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gICAgICAgICAgaWYgKHZp cnRpb19oYXNfZmVhdHVyZSh2ZGV2LCBWSVJUSU9fTkVUX0ZfR1VFU1RfVFNPNCkgfHwKPiA+ID4g PiA+ICAgICAgICAgICAgICB2aXJ0aW9faGFzX2ZlYXR1cmUodmRldiwgVklSVElPX05FVF9GX0dV RVNUX1RTTzYpKQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICBkZXYtPmZlYXR1cmVzIHw9IE5F VElGX0ZfTFJPOwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJdCBzb3VuZHMgbGlrZSB0aGlzIHBhdGNo IGlzIGZpeGluZyBzb21ldGhpbmcgc2xpZ2h0bHkgZGlmZmVyZW50bHkgdG8KPiA+ID4gPiA+IG15 IHBhdGNoIGZpeGVkLiB2aXJ0bmV0X3NldF9mZWF0dXJlcygpIGRvZXNuJ3QgY2FyZSBhYm91dAo+ ID4gPiA+ID4gR1VFU1RfT0ZGTE9BRFMsIGl0IG9ubHkgdGVzdHMgYWdhaW5zdCBORVRJRl9GX0xS Ty4gRXZlbiBpZiAib2ZmbG9hZHMiCj4gPiA+ID4gPiBpcyB6ZXJvLCBpdCB3aWxsIGNhbGwgdmly dG5ldF9zZXRfZ3Vlc3Rfb2ZmbG9hZHMoKSwgd2hpY2ggdHJpZ2dlcnMgdGhlCj4gPiA+ID4gPiBj cmFzaC4KPiA+ID4gPiAKPiA+ID4gPiBJbnRlcmVzdGluZy4gSXQncyBzdXJwcmlzaW5nIHRoYXQg aXQgaXMgdHJ5aW5nIHRvIGNvbmZpZ3VyZSBhIGZsYWcKPiA+ID4gPiB0aGF0IGlzIG5vdCBjb25m aWd1cmFibGUsIGkuZS4sIGFic2VudCBmcm9tIGRldi0+aHdfZmVhdHVyZXMKPiA+ID4gPiBhZnRl ciBNaWNoYWVsJ3MgY2hhbmdlLgo+ID4gPiA+IAo+ID4gPiA+ID4gU28gZWl0aGVyIHdlIG5lZWQg dG8gZW5zdXJlIE5FVElGX0ZfTFJPIGlzIG5ldmVyIHNldCwgb3IKPiA+ID4gPiBMUk8gbWlnaHQg YmUgYXZhaWxhYmxlLCBqdXN0IG5vdCBjb25maWd1cmFibGUuIEluZGVlZCB0aGlzIHdhcyB3aGF0 IEkKPiA+ID4gPiBvYnNlcnZlZCBpbiB0aGUgcGFzdC4KPiA+ID4gZGV2X2Rpc2FibGVfbHJvIGV4 cGVjdHMgdGhhdCBORVRJRl9GX0xSTyBpcyBhbHdheXMgY29uZmlndXJhYmxlLiBXaGljaAo+ID4g PiBJIGd1ZXNzIGlzIGEgcmVhc29uYWJsZSBhc3N1bXB0aW9uLCBqdXN0IG5vdCBuZWNlc3Nhcmls eSB0aGUgY2FzZSBpbgo+ID4gPiB2aXJ0aW9fbmV0Lgo+ID4gPiAKPiA+ID4gU28gSSB0aGluayB3 ZSBuZWVkIGJvdGggcGF0Y2hlcy4gQ29ycmVjdGx5IG1hcmsgdGhlIGZlYXR1cmUgYXMgZml4ZWQK PiA+ID4gYnkgcmVtb3ZpbmcgZnJvbSBkZXYtPmh3X2ZlYXR1cmVzIGFuZCBhbHNvIGlnbm9yZSB0 aGUgcmVxdWVzdCBmcm9tCj4gPiA+IGRldl9kaXNhYmxlX2xybywgd2hpY2ggZG9lcyBub3QgY2hl Y2sgZm9yIHRoaXMuCj4gPiBTb21ldGhpbmcgbGlrZSB0aGlzIG1heWJlOgo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvdmlydGlvX25ldC5jIGIvZHJpdmVycy9uZXQvdmlydGlvX25l dC5jCj4gPiBpbmRleCA0ZDdkNTQzNGNjNWQuLjA1NTZmNDJiMGZiNSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ID4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25l dC5jCj4gPiBAQCAtMjU2MCw2ICsyNTYwLDkgQEAgc3RhdGljIGludCB2aXJ0bmV0X3NldF9mZWF0 dXJlcyhzdHJ1Y3QgbmV0X2RldmljZSAqZGV2LAo+ID4gICAgICAgICAgdTY0IG9mZmxvYWRzOwo+ ID4gICAgICAgICAgaW50IGVycjsKPiA+IAo+ID4gKyAgICAgICBpZiAoIXZpcnRpb19oYXNfZmVh dHVyZSh2aS0+dmRldiwgVklSVElPX05FVF9GX0NUUkxfR1VFU1RfT0ZGTE9BRFMpKQo+ID4gKyAg ICAgICAgICAgICAgIHJldHVybiAwOwo+ID4gKwo+ID4gICAgICAgICAgaWYgKChkZXYtPmZlYXR1 cmVzIF4gZmVhdHVyZXMpICYgTkVUSUZfRl9MUk8pIHsKPiA+ICAgICAgICAgICAgICAgICAgaWYg KHZpLT54ZHBfcXVldWVfcGFpcnMpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IC1FQlVTWTsKPiA+IEBAIC0yOTcxLDYgKzI5NzQsMTUgQEAgc3RhdGljIGludCB2aXJ0bmV0X3Zh bGlkYXRlKHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2KQo+ID4gICAgICAgICAgaWYgKCF2aXJ0 bmV0X3ZhbGlkYXRlX2ZlYXR1cmVzKHZkZXYpKQo+ID4gICAgICAgICAgICAgICAgICByZXR1cm4g LUVJTlZBTDsKPiA+IAo+ID4gKyAgICAgICAvKiBWSVJUSU9fTkVUX0ZfQ1RSTF9HVUVTVF9PRkZM T0FEUyBkb2VzIG5vdCB3b3JrIHdpdGhvdXQKPiA+ICsgICAgICAgICogVklSVElPX05FVF9GX0NU UkxfVlEuIEhvd2V2ZXIgdGhlIHZpcnRpbyBzcGVjIGRvZXMgbm90Cj4gPiArICAgICAgICAqIHNw ZWNpZnkgdGhhdCBWSVJUSU9fTkVUX0ZfQ1RSTF9HVUVTVF9PRkZMT0FEUyBkZXBlbmRzCj4gPiAr ICAgICAgICAqIG9uIFZJUlRJT19ORVRfRl9DVFJMX1ZRIHNvIGRldmljZXMgY2FuIHNldCB0aGUg bGF0ZXIgYnV0Cj4gPiArICAgICAgICAqIG5vdCB0aGUgZm9ybWVyLgo+ID4gKyAgICAgICAgKi8K PiA+ICsgICAgICAgaWYgKCF2aXJ0aW9faGFzX2ZlYXR1cmUodmRldiwgVklSVElPX05FVF9GX0NU UkxfVlEpKQo+ID4gKyAgICAgICAgICAgICAgIF9fdmlydGlvX2NsZWFyX2JpdCh2ZGV2LCBWSVJU SU9fTkVUX0ZfQ1RSTF9HVUVTVF9PRkZMT0FEUyk7Cj4gPiArCj4gPiAgICAgICAgICBpZiAodmly dGlvX2hhc19mZWF0dXJlKHZkZXYsIFZJUlRJT19ORVRfRl9NVFUpKSB7Cj4gPiAgICAgICAgICAg ICAgICAgIGludCBtdHUgPSB2aXJ0aW9fY3JlYWQxNih2ZGV2LAo+ID4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgb2Zmc2V0b2Yoc3RydWN0IHZpcnRpb19uZXRfY29u ZmlnLAo+ID4gCj4gCj4gV2UgY2hlY2sgZmVhdHVyZSBkZXBlbmRlbmN5IGFuZCBmYWlsIHRoZSBw cm9iZSBpbgo+IHZpcnRuZXRfdmFsaWRhdGVfZmVhdHVyZXMoKS4KPiAKPiBJcyBpdCBtb3JlIHN0 cmFpZ2h0Zm9yd2FyZCB0byBmYWlsIHRoZSBwcm9iZSB0aGVyZSB3aGVuIENUUkxfR1VFU1RfT0ZG TE9BRFMKPiB3YXMgc2V0IGJ1dCBDVFJMX1ZRIHdhc24ndD8KPiAKPiBUaGFua3MKCkV4cGFuZGlu ZyBvbiB3aGF0IHRoZSBjb21tZW50IGFib3ZlIHNheXMsIHdlIGNhbid0IGZhaWwgcHJvYmUKaW4g dGhpcyBjb25maWd1cmF0aW9uIHdpdGhvdXQgYnJlYWtpbmcgdGhlIGRyaXZlciBmb3IKc3BlYyBj b21wbGlhbnQgZGV2aWNlcy4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXph dGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRh dGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9698C33C8C for ; Sun, 5 Jan 2020 11:16:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA61E20866 for ; Sun, 5 Jan 2020 11:16:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WtHbvrcn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726212AbgAELQl (ORCPT ); Sun, 5 Jan 2020 06:16:41 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:49423 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725930AbgAELQl (ORCPT ); Sun, 5 Jan 2020 06:16:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578222999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GGlSSbeC4Kbhr61r3dRU9qa1eVoeraY/lQ162mo0Jg=; b=WtHbvrcnb7uj/nbsnYYHVHjmVdQ9yrNOKlV0Kq+ZP3LErUs8VCq1UHFdIiQetc5KKxHxgi jWDusYJ0aPYIxL8tsbZnmOwbi2QcMcQLy+6OeVfLRd8x8FLY3FPbxeD8m5DGjL0qghYxKa UUwyRYgGOifxfwJPRoJoeUAUBS0Ry80= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-CvbVxVnhOgqn9tn_TJcitg-1; Sun, 05 Jan 2020 06:16:37 -0500 X-MC-Unique: CvbVxVnhOgqn9tn_TJcitg-1 Received: by mail-qt1-f198.google.com with SMTP id c8so32472204qte.22 for ; Sun, 05 Jan 2020 03:16:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+GGlSSbeC4Kbhr61r3dRU9qa1eVoeraY/lQ162mo0Jg=; b=mHXfkG91ojmxuMFike/m8p2pKCsQRXFM5nDfQbWJNFq/rt1PW2MujGsx3GfI+1+LHo nSNeHHA/3s4AztG8FGjbzhY84oNisZ+qkKkhfhGCzyWvsAML1/kwmbF1jkNnpfwx11Ed +8VhUwsQmZaaX/JhthnDnP5qF87VwLvw7R4PghHgs8DrKkoC/7qVQsuD+GI/9iHodNge V1GjD2RwQZXYA1VJzYpiR3OM8S9GkgTkDg7eMrBKbp+baFoMKV9xkXIRA06/qw55bbnv m2X31v4M3ZYUhHHHHf63/vpV2yztDBe6KtC+dpqCaqDqe0jKr8AUo0WsDpcJy5BKJ9j6 wzpw== X-Gm-Message-State: APjAAAUGlEC1P8n/ndgQnuc/iEbqPLGDW/y6ZIjbRXYoZO8Ho9u0tzzV ZAkNtC0gX+4TLoLJ9AvXLlwFRR8OXGu+nJlUtpuBXfwlUQdZwlpqx+sj0+LRTdn5JOs68WWMhjY 2mDp9yl1tbtGGr1aM7AaFW2AR X-Received: by 2002:a37:68d5:: with SMTP id d204mr78760684qkc.171.1578222997285; Sun, 05 Jan 2020 03:16:37 -0800 (PST) X-Google-Smtp-Source: APXvYqzPMMvBqmBN4Gem7zky32ejHiDxpzbcW8rhw1eSZVpEgSTWT6x4f+E8PIcPfp2MrIjZ3t+TIA== X-Received: by 2002:a37:68d5:: with SMTP id d204mr78760671qkc.171.1578222996963; Sun, 05 Jan 2020 03:16:36 -0800 (PST) Received: from redhat.com (bzq-79-183-34-164.red.bezeqint.net. [79.183.34.164]) by smtp.gmail.com with ESMTPSA id t7sm19125131qkm.136.2020.01.05.03.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2020 03:16:36 -0800 (PST) Date: Sun, 5 Jan 2020 06:16:30 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Alistair Delva , Willem de Bruijn , LKML , "David S. Miller" , virtualization@lists.linux-foundation.org, Network Development Subject: Re: [PATCH net] virtio_net: CTRL_GUEST_OFFLOADS depends on CTRL_VQ Message-ID: <20200105061532-mutt-send-email-mst@kernel.org> References: <20191223140322.20013-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 24, 2019 at 10:49:13AM +0800, Jason Wang wrote: > > On 2019/12/24 上午4:21, Alistair Delva wrote: > > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > > wrote: > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > > wrote: > > > > 00fffe0ff0 DR7: 0000000000000400 > > > > > > Call Trace: > > > > > > ? preempt_count_add+0x58/0xb0 > > > > > > ? _raw_spin_lock_irqsave+0x36/0x70 > > > > > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > > > > > ? __wake_up+0x70/0x190 > > > > > > virtnet_set_features+0x90/0xf0 [virtio_net] > > > > > > __netdev_update_features+0x271/0x980 > > > > > > ? nlmsg_notify+0x5b/0xa0 > > > > > > dev_disable_lro+0x2b/0x190 > > > > > > ? inet_netconf_notify_devconf+0xe2/0x120 > > > > > > devinet_sysctl_forward+0x176/0x1e0 > > > > > > proc_sys_call_handler+0x1f0/0x250 > > > > > > proc_sys_write+0xf/0x20 > > > > > > __vfs_write+0x3e/0x190 > > > > > > ? __sb_start_write+0x6d/0xd0 > > > > > > vfs_write+0xd3/0x190 > > > > > > ksys_write+0x68/0xd0 > > > > > > __ia32_sys_write+0x14/0x20 > > > > > > do_fast_syscall_32+0x86/0xe0 > > > > > > entry_SYSENTER_compat+0x7c/0x8e > > > > > > > > > > > > A similar crash will likely trigger when enabling XDP. > > > > > > > > > > > > Reported-by: Alistair Delva > > > > > > Reported-by: Willem de Bruijn > > > > > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > --- > > > > > > > > > > > > Lightly tested. > > > > > > > > > > > > Alistair, could you please test and confirm that this resolves the > > > > > > crash for you? > > > > > This patch doesn't work. The reason is that NETIF_F_LRO is also turned > > > > > on by TSO4/TSO6, which your patch didn't check for. So it ends up > > > > > going through the same path and crashing in the same way. > > > > > > > > > > if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) || > > > > > virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6)) > > > > > dev->features |= NETIF_F_LRO; > > > > > > > > > > It sounds like this patch is fixing something slightly differently to > > > > > my patch fixed. virtnet_set_features() doesn't care about > > > > > GUEST_OFFLOADS, it only tests against NETIF_F_LRO. Even if "offloads" > > > > > is zero, it will call virtnet_set_guest_offloads(), which triggers the > > > > > crash. > > > > > > > > Interesting. It's surprising that it is trying to configure a flag > > > > that is not configurable, i.e., absent from dev->hw_features > > > > after Michael's change. > > > > > > > > > So either we need to ensure NETIF_F_LRO is never set, or > > > > LRO might be available, just not configurable. Indeed this was what I > > > > observed in the past. > > > dev_disable_lro expects that NETIF_F_LRO is always configurable. Which > > > I guess is a reasonable assumption, just not necessarily the case in > > > virtio_net. > > > > > > So I think we need both patches. Correctly mark the feature as fixed > > > by removing from dev->hw_features and also ignore the request from > > > dev_disable_lro, which does not check for this. > > Something like this maybe: > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 4d7d5434cc5d..0556f42b0fb5 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev, > > u64 offloads; > > int err; > > > > + if (!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > > + return 0; > > + > > if ((dev->features ^ features) & NETIF_F_LRO) { > > if (vi->xdp_queue_pairs) > > return -EBUSY; > > @@ -2971,6 +2974,15 @@ static int virtnet_validate(struct virtio_device *vdev) > > if (!virtnet_validate_features(vdev)) > > return -EINVAL; > > > > + /* VIRTIO_NET_F_CTRL_GUEST_OFFLOADS does not work without > > + * VIRTIO_NET_F_CTRL_VQ. However the virtio spec does not > > + * specify that VIRTIO_NET_F_CTRL_GUEST_OFFLOADS depends > > + * on VIRTIO_NET_F_CTRL_VQ so devices can set the later but > > + * not the former. > > + */ > > + if (!virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > > + __virtio_clear_bit(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS); > > + > > if (virtio_has_feature(vdev, VIRTIO_NET_F_MTU)) { > > int mtu = virtio_cread16(vdev, > > offsetof(struct virtio_net_config, > > > > We check feature dependency and fail the probe in > virtnet_validate_features(). > > Is it more straightforward to fail the probe there when CTRL_GUEST_OFFLOADS > was set but CTRL_VQ wasn't? > > Thanks Expanding on what the comment above says, we can't fail probe in this configuration without breaking the driver for spec compliant devices. -- MST