All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
	lkml <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
	sven@narfation.org, Johan Hedberg <johan.hedberg@gmail.com>,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	edumazet@google.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, jon.maloy@ericsson.com,
	ying.xue@windriver.com, kafai@fb.com, songliubraving@fb.com,
	yhs@fb.com, andriin@fb.com, netdev <netdev@vger.kernel.org>,
	BlueZ devel list <linux-bluetooth@vger.kernel.org>,
	tipc-discussion@lists.sourceforge.net,
	linux-hyperv@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 5/8] net: bluetooth: remove unneeded MODULE_VERSION() usage
Date: Sun, 5 Jan 2020 11:42:16 +0100	[thread overview]
Message-ID: <20200105104216.GA1679409@kroah.com> (raw)
In-Reply-To: <22BD3D36-DE54-4062-B3A1-15D9E0E256A8@holtmann.org>

On Sun, Jan 05, 2020 at 10:34:56AM +0100, Marcel Holtmann wrote:
> Hi Enrico,
> 
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> 
> I prefer to keep the MODULE_VERSION info since it provides this
> information via modinfo.

Sure, but it's really pointless :)

> Unless there is a kernel wide consent to remove MODULE_VERSION
> altogether, the Bluetooth subsystem is keeping it.

I've deleted them from lots of drivers/subsystems already as they do not
make any sense when you think about vendor kernels, stable kernels, and
upstream kernel versions.

thanks,

greg k-h

  reply	other threads:[~2020-01-05 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-04 19:51 [PATCH 1/8] net: 8021q: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2020-01-04 19:51 ` [PATCH 2/8] net: 8021q: use netdev_info()/netdev_warn() Enrico Weigelt, metux IT consult
2020-01-04 20:06   ` Florian Fainelli
2020-01-04 19:51 ` [PATCH 3/8] net: batman-adv: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2020-01-04 19:59   ` Sven Eckelmann
2020-01-04 19:51 ` [PATCH 4/8] net: ipv4: use netdev_info()/netdev_warn() Enrico Weigelt, metux IT consult
2020-01-04 19:55   ` Sven Eckelmann
2020-01-04 19:56   ` Fabio Estevam
2020-01-04 19:51 ` [PATCH 5/8] net: bluetooth: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2020-01-05  9:34   ` Marcel Holtmann
2020-01-05 10:42     ` Greg KH [this message]
2020-01-04 19:51 ` [PATCH 6/8] net: bridge: " Enrico Weigelt, metux IT consult
2020-01-04 19:51 ` [PATCH 7/8] net: vmw_vsock: " Enrico Weigelt, metux IT consult
2020-01-04 19:51 ` [PATCH 8/8] net: tipc: " Enrico Weigelt, metux IT consult
2020-01-05  2:40 ` [PATCH 1/8] net: 8021q: " kbuild test robot
2020-01-05  2:40   ` kbuild test robot
2020-01-05  5:56 ` kbuild test robot
2020-01-05  5:56   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200105104216.GA1679409@kroah.com \
    --to=greg@kroah.com \
    --cc=a@unstable.cc \
    --cc=andriin@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=info@metux.net \
    --cc=johan.hedberg@gmail.com \
    --cc=jon.maloy@ericsson.com \
    --cc=kafai@fb.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=songliubraving@fb.com \
    --cc=sven@narfation.org \
    --cc=sw@simonwunderlich.de \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=yhs@fb.com \
    --cc=ying.xue@windriver.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.