From: Stephen Boyd <sboyd@kernel.org>
To: Georgi Djakov <georgi.djakov@linaro.org>,
bjorn.andersson@linaro.org, robdclark@gmail.com
Cc: mturquette@baylibre.com, agross@kernel.org, tdas@codeaurora.org,
anischal@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
georgi.djakov@linaro.org
Subject: Re: [PATCH] clk: qcom: gcc-sdm845: Add missing flag to votable GDSCs
Date: Sun, 05 Jan 2020 12:02:24 -0800 [thread overview]
Message-ID: <20200105200225.9872C20715@mail.kernel.org> (raw)
In-Reply-To: <20191126153437.11808-1-georgi.djakov@linaro.org>
Quoting Georgi Djakov (2019-11-26 07:34:37)
> On sdm845 devices, during boot we see the following warnings (unless we
> have added 'pd_ignore_unused' to the kernel command line):
> hlos1_vote_mmnoc_mmu_tbu_sf_gdsc status stuck at 'on'
> hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc status stuck at 'on'
> hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc status stuck at 'on'
> hlos1_vote_aggre_noc_mmu_tbu2_gdsc status stuck at 'on'
> hlos1_vote_aggre_noc_mmu_tbu1_gdsc status stuck at 'on'
> hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc status stuck at 'on'
> hlos1_vote_aggre_noc_mmu_audio_tbu_gdsc status stuck at 'on'
>
> As the name of these GDSCs suggests, they are "votable" and in downstream
> DT, they all have the property "qcom,no-status-check-on-disable", which
> means that we should not poll the status bit when we disable them.
>
> Luckily the VOTABLE flag already exists and it does exactly what we need,
> so let's make use of it to make the warnings disappear.
>
> Fixes: 06391eddb60a ("clk: qcom: Add Global Clock controller (GCC) driver for SDM845")
> Reported-by: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2020-01-05 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:34 [PATCH] clk: qcom: gcc-sdm845: Add missing flag to votable GDSCs Georgi Djakov
2019-11-26 18:11 ` Rob Clark
2019-12-13 2:59 ` Stephen Boyd
2020-01-05 20:02 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105200225.9872C20715@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=anischal@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robdclark@gmail.com \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.