From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED Date: Sun, 5 Jan 2020 12:37:04 -0800 Message-ID: <20200105203704.GD5885@atomide.com> References: <20191221005711.47314-1-tony@atomide.com> <20191221164141.GI35479@atomide.com> <20200104050950.GA11429@chinchilla> <20200104055011.GA5885@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20200104055011.GA5885@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen , Laurent Pinchart , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, "H . Nikolaus Schaller" , Merlijn Wajer , Matthijs van Duin List-Id: linux-omap@vger.kernel.org Hi, * Tony Lindgren [200104 05:51]: > > Just changing the alingment fixes the issue. Looks like the minimum > alignment we currently allow is 128, I think 512 was the minimum > that worked for me, so maybe the right fix would be to just change > the minimum to 512 with no specific need to use 4096 for now. So Matthijs and I chatted about this a bit on irc, and here's what we concluded so far: 1. We have at least three different alignment needs for tiler - Linux use of tiler aligned to 128 bytes - SGX use of tiler aligned to 4096 bytes (or 512 bytes?) - Fast userspace mapping aligned to 4096 bytes 2. The alignment need may need to be configured by the tiler consumer in #1 above 3. The alignment need for SGX seems to be based on SGX MMU page size 4. The issue I'm seeing with stellarium on droid4 may be a stride issue as about one out of 3 or 4 frames is OK and aligning to 512 also fixes the issue maybe because it happens to make multiple frames align to 4096 So let's wait on this patch until we have more info and know how the different alignments should be handled. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970F2C32771 for ; Mon, 6 Jan 2020 08:10:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7820F20848 for ; Mon, 6 Jan 2020 08:10:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7820F20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A87689DFF; Mon, 6 Jan 2020 08:09:59 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A56C89FE6 for ; Sun, 5 Jan 2020 20:37:08 +0000 (UTC) Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0479E80E2; Sun, 5 Jan 2020 20:37:48 +0000 (UTC) Date: Sun, 5 Jan 2020 12:37:04 -0800 From: Tony Lindgren To: Tomi Valkeinen , Laurent Pinchart , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, "H . Nikolaus Schaller" , Merlijn Wajer , Matthijs van Duin Subject: Re: [PATCH] drm/omap: gem: Fix tearing with BO_TILED Message-ID: <20200105203704.GD5885@atomide.com> References: <20191221005711.47314-1-tony@atomide.com> <20191221164141.GI35479@atomide.com> <20200104050950.GA11429@chinchilla> <20200104055011.GA5885@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200104055011.GA5885@atomide.com> X-Mailman-Approved-At: Mon, 06 Jan 2020 08:09:58 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, * Tony Lindgren [200104 05:51]: > > Just changing the alingment fixes the issue. Looks like the minimum > alignment we currently allow is 128, I think 512 was the minimum > that worked for me, so maybe the right fix would be to just change > the minimum to 512 with no specific need to use 4096 for now. So Matthijs and I chatted about this a bit on irc, and here's what we concluded so far: 1. We have at least three different alignment needs for tiler - Linux use of tiler aligned to 128 bytes - SGX use of tiler aligned to 4096 bytes (or 512 bytes?) - Fast userspace mapping aligned to 4096 bytes 2. The alignment need may need to be configured by the tiler consumer in #1 above 3. The alignment need for SGX seems to be based on SGX MMU page size 4. The issue I'm seeing with stellarium on droid4 may be a stride issue as about one out of 3 or 4 frames is OK and aligning to 512 also fixes the issue maybe because it happens to make multiple frames align to 4096 So let's wait on this patch until we have more info and know how the different alignments should be handled. Regards, Tony _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel