All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Mikko Perttunen <cyndis@kapsi.fi>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 6/9] i2c: tegra: Use relaxed versions of readl/writel
Date: Mon,  6 Jan 2020 04:04:20 +0300	[thread overview]
Message-ID: <20200106010423.5890-7-digetx@gmail.com> (raw)
In-Reply-To: <20200106010423.5890-1-digetx@gmail.com>

There is nothing to synchronize in regards to memory accesses for PIO
transfers and for DMA transfers the DMA API takes care of the syncing.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/i2c/busses/i2c-tegra.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e0eb8f5dcd6b..1a390e1bff72 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -284,12 +284,12 @@ struct tegra_i2c_dev {
 static void dvc_writel(struct tegra_i2c_dev *i2c_dev, u32 val,
 		       unsigned long reg)
 {
-	writel(val, i2c_dev->base + reg);
+	writel_relaxed(val, i2c_dev->base + reg);
 }
 
 static u32 dvc_readl(struct tegra_i2c_dev *i2c_dev, unsigned long reg)
 {
-	return readl(i2c_dev->base + reg);
+	return readl_relaxed(i2c_dev->base + reg);
 }
 
 /*
@@ -307,16 +307,16 @@ static unsigned long tegra_i2c_reg_addr(struct tegra_i2c_dev *i2c_dev,
 static void i2c_writel(struct tegra_i2c_dev *i2c_dev, u32 val,
 		       unsigned long reg)
 {
-	writel(val, i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
+	writel_relaxed(val, i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
 
 	/* Read back register to make sure that register writes completed */
 	if (reg != I2C_TX_FIFO)
-		readl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
+		readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
 }
 
 static u32 i2c_readl(struct tegra_i2c_dev *i2c_dev, unsigned long reg)
 {
-	return readl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
+	return readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg));
 }
 
 static void i2c_writesl(struct tegra_i2c_dev *i2c_dev, void *data,
@@ -689,12 +689,13 @@ static int tegra_i2c_wait_for_config_load(struct tegra_i2c_dev *i2c_dev)
 		i2c_writel(i2c_dev, I2C_MSTR_CONFIG_LOAD, I2C_CONFIG_LOAD);
 
 		if (i2c_dev->is_curr_atomic_xfer)
-			err = readl_poll_timeout_atomic(addr, val, val == 0,
-							1000,
-							I2C_CONFIG_LOAD_TIMEOUT);
+			err = readl_relaxed_poll_timeout_atomic(
+						addr, val, val == 0, 1000,
+						I2C_CONFIG_LOAD_TIMEOUT);
 		else
-			err = readl_poll_timeout(addr, val, val == 0, 1000,
-						 I2C_CONFIG_LOAD_TIMEOUT);
+			err = readl_relaxed_poll_timeout(
+						addr, val, val == 0, 1000,
+						I2C_CONFIG_LOAD_TIMEOUT);
 
 		if (err) {
 			dev_warn(i2c_dev->dev,
-- 
2.24.0

  parent reply	other threads:[~2020-01-06  1:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06  1:04 [PATCH v3 0/9] NVIDIA Tegra I2C driver fixes and improvements Dmitry Osipenko
2020-01-06  1:04 ` [PATCH v3 1/9] i2c: tegra: Fix suspending in active runtime PM state Dmitry Osipenko
2020-01-07 12:38   ` Thierry Reding
2020-01-07 12:38     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 2/9] i2c: tegra: Properly disable runtime PM on driver's probe error Dmitry Osipenko
2020-01-07 12:38   ` Thierry Reding
2020-01-07 12:38     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 3/9] i2c: tegra: Prevent interrupt triggering after transfer timeout Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 4/9] i2c: tegra: Support atomic transfers Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 5/9] i2c: tegra: Rename I2C_PIO_MODE_MAX_LEN to I2C_PIO_MODE_PREFERRED_LEN Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` Dmitry Osipenko [this message]
2020-01-07 12:39   ` [PATCH v3 6/9] i2c: tegra: Use relaxed versions of readl/writel Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 7/9] clk: tegra: Fix double-free in tegra_clk_init() Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 8/9] i2c: tegra: Always terminate DMA transfer Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-06  1:04 ` [PATCH v3 9/9] i2c: tegra: Check DMA completion status in addition to left time Dmitry Osipenko
2020-01-07 12:39   ` Thierry Reding
2020-01-07 12:39     ` Thierry Reding
2020-01-07 12:38 ` [PATCH v3 0/9] NVIDIA Tegra I2C driver fixes and improvements Thierry Reding
2020-01-07 16:39   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106010423.5890-7-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cyndis@kapsi.fi \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.