From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v5 4/6] lib: rsa: generate additional parameters for public key
Date: Mon, 6 Jan 2020 10:32:20 +0900 [thread overview]
Message-ID: <20200106013219.GA10835@linaro.org> (raw)
In-Reply-To: <CAPnjgZ2zewJei58_wdY3TtT0pUxe3JBaWfpdWGEMYBbc_MeH5Q@mail.gmail.com>
Simon,
On Fri, Dec 27, 2019 at 07:26:40PM -0700, Simon Glass wrote:
> On Tue, 17 Dec 2019 at 01:53, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
> >
> > In the current implementation of FIT_SIGNATURE, five parameters for
> > a RSA public key are required while only two of them are essential.
> > (See rsa-mod-exp.h and uImage.FIT/signature.txt)
> > This is a result of considering relatively limited computer power
> > and resources on embedded systems, while such a assumption may not
> > be quite practical for other use cases.
> >
> > In this patch, added is a function, rsa_gen_key_prop(), which will
> > generate additional parameters for other uses, in particular
> > UEFI secure boot, on the fly.
> >
> > Note: the current code uses some "big number" routines from BearSSL
> > for the calculation.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > include/u-boot/rsa-mod-exp.h | 23 ++
> > lib/rsa/Kconfig | 3 +
> > lib/rsa/Makefile | 1 +
> > lib/rsa/rsa-keyprop.c | 725 +++++++++++++++++++++++++++++++++++
> > 4 files changed, 752 insertions(+)
> > create mode 100644 lib/rsa/rsa-keyprop.c
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> I think it would help to have the change log in each patch as well as
> the cover letter. If you use patman it will do this for you.
Ah, I didn't know that.
It will take some time to learn more about patman.
Thanks,
-Takahiro Akashi
next prev parent reply other threads:[~2020-01-06 1:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 8:54 [PATCH v5 0/6] rsa: extend rsa_verify() for UEFI secure boot AKASHI Takahiro
2019-12-17 8:54 ` [PATCH v5 1/6] lib: rsa: decouple rsa from FIT image verification AKASHI Takahiro
2019-12-17 8:54 ` [PATCH v5 2/6] rsa: add CONFIG_RSA_VERIFY_WITH_PKEY config AKASHI Takahiro
2019-12-17 8:54 ` [PATCH v5 3/6] include: image.h: add key info to image_sign_info AKASHI Takahiro
2019-12-17 8:54 ` [PATCH v5 4/6] lib: rsa: generate additional parameters for public key AKASHI Takahiro
2019-12-28 2:26 ` Simon Glass
2020-01-06 1:32 ` AKASHI Takahiro [this message]
2019-12-17 8:54 ` [PATCH v5 5/6] lib: rsa: add rsa_verify_with_pkey() AKASHI Takahiro
2019-12-17 8:54 ` [PATCH v5 6/6] test: add rsa_verify() unit test AKASHI Takahiro
2019-12-28 2:26 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106013219.GA10835@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.