From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5A0C32767 for ; Mon, 6 Jan 2020 06:03:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E663C20848 for ; Mon, 6 Jan 2020 06:03:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="sR+EpT8V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJpHhyL6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E663C20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1912317D7; Mon, 6 Jan 2020 07:02:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1912317D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578290626; bh=xELEvbf8aaPBXrW/o4tp99EQFJduNpclqGOcuyWVWgU=; h=In-Reply-To:References:To:From:Date:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sR+EpT8VPJTfKQEl+Ti6tW7UImLoJlOAQ4kvpsUfMsRqPEisIS2z2nx+IZSNIJddy CcJDxyl56xp2sBz5w6nYLksqoVl+E+DUPLrXqJa01595ZeTOPmAMeLx29ED0XD4OSl dhN1fEVVSdKaUtE5x+HteYCfmygT4WvxP1eCHudg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7BDC6F80149; Mon, 6 Jan 2020 07:02:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F336F80159; Mon, 6 Jan 2020 07:02:53 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 00FC8F8010D for ; Mon, 6 Jan 2020 07:02:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 00FC8F8010D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJpHhyL6" Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A5720848; Mon, 6 Jan 2020 06:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578290566; bh=5hxva25df32tAsqNh8cqFx9odnLgu5hRKNw8HZPCLjk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:From; b=eJpHhyL6Zn+jn0TWh26dV/uWPfkkWmsibBqQhvb21LVcA6A7krW1p2EYvzXNOKOcK ZHOPLcOkOfPCnDSxRNQ3b9pxbUrX2wYkH4wWSFdwiASwgMB9KVTYbGmcU+0aeg6ay6 vV9ndySbUZQE22ipz4z55cTxtK2FyQVvBOuHX2Vk= MIME-Version: 1.0 In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> To: Andrew Morton , Masahiro Yamada From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-Id: <20200106060246.49A5720848@mail.kernel.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Julia Lawall , linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] treewide: remove redundent IS_ERR() before error code check X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1EFC32767 for ; Mon, 6 Jan 2020 06:02:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4A37218AC for ; Mon, 6 Jan 2020 06:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578290568; bh=5hxva25df32tAsqNh8cqFx9odnLgu5hRKNw8HZPCLjk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:List-ID:From; b=XBcLMHQekYwn0oT1XpukLzWCYCkR438qbubFhFJZYRLNAXCYUUAC5gkH0SHqLFAxZ yioJFmacCyRxfVKLbESuw/ItHCX6ovhoG8p5n7Eu6HQksgxOf6iz/rn1X1U2Qjbgho 9X4PUvcGyVDNiuDK8Dtr8ZjzbIzcp0HIDt+AUBkk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgAFGCr (ORCPT ); Mon, 6 Jan 2020 01:02:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:46416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgAFGCr (ORCPT ); Mon, 6 Jan 2020 01:02:47 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A5720848; Mon, 6 Jan 2020 06:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578290566; bh=5hxva25df32tAsqNh8cqFx9odnLgu5hRKNw8HZPCLjk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:From; b=eJpHhyL6Zn+jn0TWh26dV/uWPfkkWmsibBqQhvb21LVcA6A7krW1p2EYvzXNOKOcK ZHOPLcOkOfPCnDSxRNQ3b9pxbUrX2wYkH4wWSFdwiASwgMB9KVTYbGmcU+0aeg6ay6 vV9ndySbUZQE22ipz4z55cTxtK2FyQVvBOuHX2Vk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> Cc: Julia Lawall , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, Masahiro Yamada To: Andrew Morton , Masahiro Yamada Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-Id: <20200106060246.49A5720848@mail.kernel.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) =3D=3D -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. >=20 > The semantic patch that generates this commit is as follows: >=20 > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) =3D=3D - error_code) > +PTR_ERR(ptr) =3D=3D - error_code > // >=20 > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-ID: <20200106060246.49A5720848@mail.kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Morton Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Julia Lawall , linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9EA3C32767 for ; Mon, 6 Jan 2020 06:03:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C51220848 for ; Mon, 6 Jan 2020 06:03:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U638CxkW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJpHhyL6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C51220848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PxO+jArdGDiY5xypm6kmVuhiImUVS5QT3CH+XSzH5Qo=; b=U638CxkWQuYQOi pvRhEZrez2V8+uW814NsNI5sWEGb9nLGM0EAI6UKAU4sYc3cXNjfJbD4F5Rtl/I3Y+HdoovN+vqix LJXn1dQiw0YgHLAZKjbjnlW7KIE8VAg5wv9kfASwKG+4+mf2M7n8GKjeVZCPtVoZVXQ2OhiLAuFfn M/vZUHyuGk+cI0judajAht+NovuExLJnu0ya2SaHY6wwELemsWtApa8YKDYSrS5M+5jKOiIF4fZmZ G4kH2rt2sTZTF5cn17AVGH2kqepVoCVOvwYbzCtDFyAfMzyF16AexYIRVIsR2BXUVUOT1CU5OW9DC AZZWfu8b3n76vLuS1i5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioLTa-0005bQ-VL; Mon, 06 Jan 2020 06:02:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioLTS-0005TX-Vb; Mon, 06 Jan 2020 06:02:48 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A5720848; Mon, 6 Jan 2020 06:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578290566; bh=5hxva25df32tAsqNh8cqFx9odnLgu5hRKNw8HZPCLjk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:From; b=eJpHhyL6Zn+jn0TWh26dV/uWPfkkWmsibBqQhvb21LVcA6A7krW1p2EYvzXNOKOcK ZHOPLcOkOfPCnDSxRNQ3b9pxbUrX2wYkH4wWSFdwiASwgMB9KVTYbGmcU+0aeg6ay6 vV9ndySbUZQE22ipz4z55cTxtK2FyQVvBOuHX2Vk= MIME-Version: 1.0 In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> To: Andrew Morton , Masahiro Yamada Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-Id: <20200106060246.49A5720848@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200105_220247_037936_2102F9BD X-CRM114-Status: UNSURE ( 6.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Julia Lawall , linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C840AC32767 for ; Mon, 6 Jan 2020 06:02:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A022321775 for ; Mon, 6 Jan 2020 06:02:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sBUxsbiR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eJpHhyL6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A022321775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:Subject:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=joNGGOykgfXv3wNqakUSx8cI90vPN169oyPnbzw4BLw=; b=sBUxsbiRJX+/F3 uFZHH0B6wNZxH3jXiKH0VZCuiPhtXVcSroqg/KVGqvqTwZcRv9QoyYIA4xJcRfyqbBxMMXMz3QWCy DdupYXL0OTECdA07yMIdjgqgdxh/gDDteK9D1/Me4Brl9TMGcLmJawHnB9kDiJqm5ZF6jyktEEKu1 ltS0/GBinwGSlf7NyqjnMcn5eQSHqNBjHcNTi9uoeZC+n8WlK3gpBYDGrtZWAu6ltdnOraxxL+Wu3 Rm9lB8YtZF1oRgqQiFNDu2pMWl0E6pAlYp0ErdpOLJikE+b9kHTBzLoeIa98un63wDDKnv0dQnjGm u5lHlc1n7PhiG+iaLAYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioLTV-0005Tt-LX; Mon, 06 Jan 2020 06:02:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ioLTS-0005TX-Vb; Mon, 06 Jan 2020 06:02:48 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 49A5720848; Mon, 6 Jan 2020 06:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578290566; bh=5hxva25df32tAsqNh8cqFx9odnLgu5hRKNw8HZPCLjk=; h=In-Reply-To:References:Cc:To:Subject:From:Date:From; b=eJpHhyL6Zn+jn0TWh26dV/uWPfkkWmsibBqQhvb21LVcA6A7krW1p2EYvzXNOKOcK ZHOPLcOkOfPCnDSxRNQ3b9pxbUrX2wYkH4wWSFdwiASwgMB9KVTYbGmcU+0aeg6ay6 vV9ndySbUZQE22ipz4z55cTxtK2FyQVvBOuHX2Vk= MIME-Version: 1.0 In-Reply-To: <20200106045833.1725-1-masahiroy@kernel.org> References: <20200106045833.1725-1-masahiroy@kernel.org> To: Andrew Morton , Masahiro Yamada Subject: Re: [PATCH] treewide: remove redundent IS_ERR() before error code check From: Stephen Boyd User-Agent: alot/0.8.1 Date: Sun, 05 Jan 2020 22:02:45 -0800 Message-Id: <20200106060246.49A5720848@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200105_220247_037936_2102F9BD X-CRM114-Status: UNSURE ( 6.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, Masahiro Yamada , linux-kernel@vger.kernel.org, Julia Lawall , linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Masahiro Yamada (2020-01-05 20:58:33) > 'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p). > Hence, IS_ERR(p) is unneeded. > > The semantic patch that generates this commit is as follows: > > // > @@ > expression ptr; > constant error_code; > @@ > -IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code) > +PTR_ERR(ptr) == - error_code > // > > Signed-off-by: Masahiro Yamada > --- For > drivers/clk/clk.c | 2 +- Acked-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel