From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
jmorris@namei.org, Jerry Snitselaar <jsnitsel@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: [GIT PULL] tpmdd fixes for Linux v5.5-rc6
Date: Mon, 6 Jan 2020 19:43:28 +0200 [thread overview]
Message-ID: <20200106174328.GA16364@linux.intel.com> (raw)
There has been a bunch of reports (e.g. [*]) reporting that when this
commit is applied it causes on some machines boot freezes.
Unfortunately hardware where this commit causes a failure is not widely
available (only one I'm aware is Lenovo T490), which means we cannot
predict yet how long it will take to properly fix tpm_tis interrupt
probing.
Thus, the least worst short term action is to revert the code to the
state before this commit. In long term we need fix the tpm_tis probing
code to work on machines that Stefan's patches were supposed to fix.
With these patches reverted nothing fatal happens, TPM is fallbacked
to be used in polling mode (which is not in the end too bad because
there are no high throughput workloads for TPM).
[*] https://bugzilla.kernel.org/show_bug.cgi?id=205935
/Jarkko
The following changes since commit c79f46a282390e0f5b306007bf7b11a46d529538:
Linux 5.5-rc5 (2020-01-05 14:23:27 -0800)
are available in the Git repository at:
git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20200106
for you to fetch changes up to aa4a63dd981682b1742baa01237036e48bc11923:
tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's" (2020-01-06 19:36:09 +0200)
----------------------------------------------------------------
tpmdd fixes for Linux v5.5-rc6
----------------------------------------------------------------
Jarkko Sakkinen (1):
tpm: Revert "tpm_tis: reserve chip for duration of tpm_tis_core_init"
Stefan Berger (2):
tpm: Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts"
tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
drivers/char/tpm/tpm_tis_core.c | 34 +++++++++++++++-------------------
1 file changed, 15 insertions(+), 19 deletions(-)
next reply other threads:[~2020-01-06 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 17:43 Jarkko Sakkinen [this message]
2020-01-06 23:00 ` [GIT PULL] tpmdd fixes for Linux v5.5-rc6 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106174328.GA16364@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.