From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Dennis Schridde <devurandom@gmx.net>,
Denis Pronin <dannftk@yandex.ru>, Naohiro Aota <naota@elisp.net>,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf clang: Fix build with Clang 9
Date: Mon, 6 Jan 2020 19:15:15 -0300 [thread overview]
Message-ID: <20200106221515.GE11285@kernel.org> (raw)
In-Reply-To: <20191228171314.946469-2-mail@maciej.szmigiero.name>
Em Sat, Dec 28, 2019 at 06:13:14PM +0100, Maciej S. Szmigiero escreveu:
> LLVM D59377 (included in Clang 9) refactored Clang VFS construction a bit,
> which broke perf clang build.
> Let's fix it.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> Reviewed-by: Dennis Schridde <devurandom@gmx.net>
Thanks, applied.
- Arnaldo
> ---
> tools/perf/util/c++/clang.cpp | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/c++/clang.cpp b/tools/perf/util/c++/clang.cpp
> index fc361c3f8570..c8885dfa3667 100644
> --- a/tools/perf/util/c++/clang.cpp
> +++ b/tools/perf/util/c++/clang.cpp
> @@ -71,7 +71,11 @@ getModuleFromSource(llvm::opt::ArgStringList CFlags,
> CompilerInstance Clang;
> Clang.createDiagnostics();
>
> +#if CLANG_VERSION_MAJOR < 9
> Clang.setVirtualFileSystem(&*VFS);
> +#else
> + Clang.createFileManager(&*VFS);
> +#endif
>
> #if CLANG_VERSION_MAJOR < 4
> IntrusiveRefCntPtr<CompilerInvocation> CI =
--
- Arnaldo
next prev parent reply other threads:[~2020-01-06 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 17:13 [PATCH] perf clang: Fix build with Clang 9 Maciej S. Szmigiero
2020-01-06 22:15 ` Arnaldo Carvalho de Melo [this message]
2020-01-14 22:20 ` Arnaldo Carvalho de Melo
2020-01-14 23:18 ` Maciej S. Szmigiero
2020-01-20 8:27 ` [tip: perf/core] " tip-bot2 for Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106221515.GE11285@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dannftk@yandex.ru \
--cc=devurandom@gmx.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naota@elisp.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.