From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: rostedt@goodmis.org, Arnaldo Carvalho de Melo <acme@redhat.com>,
arnaldo.melo@gmail.com, linux-kernel@vger.kernel.org,
linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtraceevent: Add dependency on libdl
Date: Mon, 6 Jan 2020 19:19:55 -0300 [thread overview]
Message-ID: <20200106221955.GC16851@kernel.org> (raw)
In-Reply-To: <20191226224931.3458-1-sudipm.mukherjee@gmail.com>
Em Thu, Dec 26, 2019 at 10:49:31PM +0000, Sudip Mukherjee escreveu:
> event-plugin.c is calling dl_*() functions but it is not linked with
> libdl. As a result when we use ldd on the generated libtraceevent.so
> file, it does not list libdl as one of its dependencies.
> Add -ldl explicitly as done in tools/lib/lockdep.
Rostedt, can you ack this one? It applies just fine.
- Arnaldo
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> tools/lib/traceevent/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index c874c017c636..0d0575981cc7 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -143,7 +143,7 @@ $(TE_IN): force
> $(Q)$(MAKE) $(build)=libtraceevent
>
> $(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN)
> - $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
> + $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -ldl -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@
> @ln -sf $(@F) $(OUTPUT)libtraceevent.so
> @ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION)
>
> --
> 2.11.0
--
- Arnaldo
next prev parent reply other threads:[~2020-01-06 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 22:49 [PATCH] libtraceevent: Add dependency on libdl Sudip Mukherjee
2020-01-06 22:19 ` Arnaldo Carvalho de Melo [this message]
2020-01-06 22:40 ` Steven Rostedt
2020-01-07 20:14 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106221955.GC16851@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.